From: David Marchand <david.marchand@6wind.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, "John Daley (johndale)" <johndale@cisco.com>,
Nelson Escobar <neescoba@cisco.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler
Date: Tue, 20 Feb 2018 10:17:34 +0100 [thread overview]
Message-ID: <CALwxeUuYZrn_i1j06W6qH4cF0_bKQipxsfv=6G-iG1VkwAjp_w@mail.gmail.com> (raw)
In-Reply-To: <20180220054113.GA20756@HYONKIM-FTCPE.cisco.com>
Hello,
On Tue, Feb 20, 2018 at 6:41 AM, Hyong Youb Kim <hyonkim@cisco.com> wrote:
> On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote:
>> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement
>> primary mac address handler.
>>
>> Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Hi, thanks for taking a stab at this.
>
>> +static void enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev,
>> + struct ether_addr *addr)
>> +{
>> + enicpmd_remove_mac_addr(eth_dev, 0);
>> + enicpmd_add_mac_addr(eth_dev, addr, 0, 0);
>> +}
>
> Unfortunately, this does not work as expected. The caller updates
> mac_addrs[0] prior to calling mac_addr_set.
Indeed.
Btw, I had forgotten about the deprecation notice [1] sent by Olivier.
Just discussed it with him, let's wait for this change before looking
at the issue again.
1: http://dpdk.org/browse/dpdk/commit/doc?id=16a7009aeed5836d671aada0d9fe11b20a4c3ce5
--
David Marchand
next prev parent reply other threads:[~2018-02-20 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 12:42 David Marchand
2018-02-20 5:41 ` Hyong Youb Kim
2018-02-20 9:17 ` David Marchand [this message]
2018-02-20 12:16 ` Hyong Youb Kim
2018-04-06 17:33 ` Ferruh Yigit
2018-04-13 17:34 ` Ferruh Yigit
2018-04-16 9:40 ` [dpdk-dev] [PATCH v2] " David Marchand
2018-04-17 5:12 ` Hyong Youb Kim
2018-04-17 17:23 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALwxeUuYZrn_i1j06W6qH4cF0_bKQipxsfv=6G-iG1VkwAjp_w@mail.gmail.com' \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
--cc=neescoba@cisco.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).