From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f193.google.com (mail-io0-f193.google.com [209.85.223.193]) by dpdk.org (Postfix) with ESMTP id 81B4123C for ; Tue, 20 Feb 2018 10:17:55 +0100 (CET) Received: by mail-io0-f193.google.com with SMTP id t22so14192350ioa.7 for ; Tue, 20 Feb 2018 01:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=lbVAny+SGJhAAAghtijltc0baIvOlFUfX9I77WqOiNY=; b=DmENAEHHiGdX8F/nekdlmHcYd7HcdeV+nnZZVoOBGK7v2UcdO4rF0vMB0Gp6x9j305 NM5OM6cEeeo2ozutnF3rr9JNAuo2H4dIOsAVS1+8sm9DXEm+Qm+O5iJ4F//plFKJh+l6 x8uYIhEkwI2czDRnIdmaV2DN/p9Qksjf8/Mveh7vCC6zZ5f1GHNwt9jjs0Gu1zP9EQ4m Rb0cIpDQcFOT6XddnzgchGtSsz5evNZyvUtpVUU2rdKXNIIxzaPI7eE79nhscM0YwcDz Sv/i/nxbOQQIbG3AWRnt81NyhwoAH1ktTFKiB+7FzO44IMbWWHIqwS1xjiQQLuxoKA/O nebg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=lbVAny+SGJhAAAghtijltc0baIvOlFUfX9I77WqOiNY=; b=iakWes6J53X8umAglwWg2qxNa0ohPDZ66afnPJd7R4PMXGrLXNG2dEZBftwHS3FWe8 D+podgWa4iKcXhBH53z/5RQXHrzv3LXZZlYHiWlJikr4MvwNH9yVYO9fD9tBznUXjsmG 4vXjAqGjzzRVz2fN0Xv41wDM4a+UVk8QzaYXryUPLHVqZvUkrllZZxUQz5uqj8OoW1Wk YtECj7wFzy37Xm82j6TyJPmkf21Ttwzz0YbwExB1zK0OdAlMpiG3g24q2cWIOz4EJW7b BWaEcoJ/qkbFWnvnRHAMl1H1dhfSAZsjgnVCB7mPiazsTLxQrcNiDdX4PcWl3bCkAzjo mpbA== X-Gm-Message-State: APf1xPABEZoPY4VONMLufm9rWSZJ+qsBvJd97R7SwG+YBLGXTlGUgyMJ Pw08hArgYlDPa7JRirvbSTXl3f+7imuJUXct/AI3XQ== X-Google-Smtp-Source: AH8x224cvsa0qnbThUJxNhFPF3O+/zOhJ6xyiGKzr62UcfY1ad9Kp8z3UTCCUMImBirxTieN4L2O0qnDWzFD9VlRVPc= X-Received: by 10.107.162.84 with SMTP id l81mr22286829ioe.134.1519118274668; Tue, 20 Feb 2018 01:17:54 -0800 (PST) MIME-Version: 1.0 Received: by 10.2.137.14 with HTTP; Tue, 20 Feb 2018 01:17:34 -0800 (PST) In-Reply-To: <20180220054113.GA20756@HYONKIM-FTCPE.cisco.com> References: <20180219124227.19859-1-david.marchand@6wind.com> <20180220054113.GA20756@HYONKIM-FTCPE.cisco.com> From: David Marchand Date: Tue, 20 Feb 2018 10:17:34 +0100 Message-ID: To: Hyong Youb Kim Cc: dev@dpdk.org, "John Daley (johndale)" , Nelson Escobar , Olivier Matz Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/enic: add primary mac address handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Feb 2018 09:17:55 -0000 Hello, On Tue, Feb 20, 2018 at 6:41 AM, Hyong Youb Kim wrote: > On Mon, Feb 19, 2018 at 01:42:27PM +0100, David Marchand wrote: >> Reused the .mac_addr_add and .mac_addr_del callbacks code to implement >> primary mac address handler. >> >> Signed-off-by: David Marchand > > Hi, thanks for taking a stab at this. > >> +static void enicpmd_set_mac_addr(struct rte_eth_dev *eth_dev, >> + struct ether_addr *addr) >> +{ >> + enicpmd_remove_mac_addr(eth_dev, 0); >> + enicpmd_add_mac_addr(eth_dev, addr, 0, 0); >> +} > > Unfortunately, this does not work as expected. The caller updates > mac_addrs[0] prior to calling mac_addr_set. Indeed. Btw, I had forgotten about the deprecation notice [1] sent by Olivier. Just discussed it with him, let's wait for this change before looking at the issue again. 1: http://dpdk.org/browse/dpdk/commit/doc?id=16a7009aeed5836d671aada0d9fe11b20a4c3ce5 -- David Marchand