From: David Marchand <david.marchand@6wind.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Jan Viktorin <viktorin@rehivetech.com>
Subject: Re: [dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug
Date: Fri, 22 Jan 2016 08:15:05 +0100 [thread overview]
Message-ID: <CALwxeUunmqn9hiP_fiMSjekb6rh0wrAozYcEcBQiivmp+h8_XA@mail.gmail.com> (raw)
In-Reply-To: <1701908.3Qo6PKQGCI@xps13>
Hello,
On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 2016-01-21 19:06, David Marchand:
>> On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin <viktorin@rehivetech.com> wrote:
>> > This change modifies the return value from -EINVAL to -1. I don't know
>> > whether is this an issue but it looks suspicious.
>>
>> Should not be an issue, as the api does not give details on expected
>> negative return values.
>> Just noticed, this also introduces a new log message that was not
>> displayed before.
>>
>> To be safe, I suppose I should restore this.
>>
>> Thomas, opinion ?
>
> I'm OK with the log message added for this error case.
> I would just keep the -EINVAL return value.
Ok will do.
--
David Marchand
next prev parent reply other threads:[~2016-01-22 7:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 11:57 [dpdk-dev] [PATCH 0/2] minor cleanup in ethdev hotplug David Marchand
2016-01-21 11:57 ` [dpdk-dev] [PATCH 1/2] ethdev: remove useless null checks David Marchand
2016-01-21 19:02 ` [dpdk-dev] [dpdk-dev,1/2] " Jan Viktorin
2016-01-22 9:11 ` Thomas Monjalon
2016-01-21 11:57 ` [dpdk-dev] [PATCH 2/2] ethdev: move code to common place in hotplug David Marchand
2016-01-21 15:38 ` [dpdk-dev] [dpdk-dev, " Jan Viktorin
2016-01-21 18:06 ` David Marchand
2016-01-21 18:42 ` Thomas Monjalon
2016-01-22 7:15 ` David Marchand [this message]
2016-01-22 14:06 ` [dpdk-dev] [PATCH v2 0/2] minor cleanup in ethdev hotplug David Marchand
2016-01-22 14:06 ` [dpdk-dev] [PATCH v2 1/2] ethdev: remove useless null checks David Marchand
2016-01-26 15:50 ` Jan Viktorin
2016-01-27 9:40 ` David Marchand
2016-01-22 14:06 ` [dpdk-dev] [PATCH v2 2/2] ethdev: move code to common place in hotplug David Marchand
2016-01-26 15:48 ` Jan Viktorin
2016-01-27 15:10 ` [dpdk-dev] [PATCH v2 0/2] minor cleanup in ethdev hotplug Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALwxeUunmqn9hiP_fiMSjekb6rh0wrAozYcEcBQiivmp+h8_XA@mail.gmail.com \
--to=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).