From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-oi0-f46.google.com (mail-oi0-f46.google.com [209.85.218.46]) by dpdk.org (Postfix) with ESMTP id 2A83E8E79 for <dev@dpdk.org>; Fri, 22 Jan 2016 08:15:26 +0100 (CET) Received: by mail-oi0-f46.google.com with SMTP id w75so42027508oie.0 for <dev@dpdk.org>; Thu, 21 Jan 2016 23:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=LfClP0ez8rlMvxAXhxPBMSvOzkHc9ZtGRE8wonKeWJk=; b=2T2RuKTU5SzurtiMT/Tra/9o49/BRU4PwVmXla88s+2zTViPZDPxB5gZLyyoMdWR5/ AI8CG8BsoJynrf43v3kvUi1is7Omni4CWPZCwnvlCmgDkD+4wNsxi4FJctaoi0JS1IyU I7ZY3Y2QM3tlPuMERYIGMBMMj+PNwDHblSLxiPDWiipc3ZbysRgnqMOOdAkentSCDgCD 2VRhefPntWjFWuhcb3LlMEJ7SfdZFz6IznhtOjHVHcdg5h6LP2pZkEyanT5DbjmQjSNk wRXi4HfAd8Tk0IZlzWs8jmC/mMKRugKKFq8jTf5iiMBvKw9DiRVKyJ4HTj7I8USeJZKK tIPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=LfClP0ez8rlMvxAXhxPBMSvOzkHc9ZtGRE8wonKeWJk=; b=FGrsYjZwBwFyK2Cl6ienqffY5HGWIpdJEftUXFbzMrof5b9P1pXQ+3vq0aXHEQqCpr oNOPbywcrzP2YLvpTx+jpkfvkDyDGIzZwKoaOD8qOc5rEj+LcoYuCQ0JKTdbDoTHX4SC rvU1dyumEAYjYGuYn3Bp16mxAnm9sn438i1RFBqdp0ncHVPH9m4xqklDQpfYSRwJM8p0 qTU3gM7j0rouilLv4+klroO4XqvpDJkCRyF5ZSk/Btfszw4zSwQMyvWoZD9HoQI02fR4 BJUsMPYEG4/Oh7cSzdSaswXLbbpEwpuvQahRqEtPz7oDvMJbrjLLWc9cTeX99d7AbHiV 5jwg== X-Gm-Message-State: AG10YOQyetfTI+YlO0kpqpnKgcbeDiql1Wyl6oSrfgQlrL7m+cflsBW8S0D4j7EGzCjEDbFTcrPM1IfhWPtowHcP X-Received: by 10.202.91.195 with SMTP id p186mr1031355oib.51.1453446925478; Thu, 21 Jan 2016 23:15:25 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Thu, 21 Jan 2016 23:15:05 -0800 (PST) In-Reply-To: <1701908.3Qo6PKQGCI@xps13> References: <1453377431-25850-3-git-send-email-david.marchand@6wind.com> <20160121163836.0bcd405e@pcviktorin.fit.vutbr.cz> <CALwxeUsR0ZZFg7UopYyshV-xnwRJiV82h2qC6xmC=ONfz6S9xA@mail.gmail.com> <1701908.3Qo6PKQGCI@xps13> From: David Marchand <david.marchand@6wind.com> Date: Fri, 22 Jan 2016 08:15:05 +0100 Message-ID: <CALwxeUunmqn9hiP_fiMSjekb6rh0wrAozYcEcBQiivmp+h8_XA@mail.gmail.com> To: Thomas Monjalon <thomas.monjalon@6wind.com> Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" <dev@dpdk.org>, Jan Viktorin <viktorin@rehivetech.com> Subject: Re: [dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 22 Jan 2016 07:15:26 -0000 Hello, On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote: > 2016-01-21 19:06, David Marchand: >> On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin <viktorin@rehivetech.com> wrote: >> > This change modifies the return value from -EINVAL to -1. I don't know >> > whether is this an issue but it looks suspicious. >> >> Should not be an issue, as the api does not give details on expected >> negative return values. >> Just noticed, this also introduces a new log message that was not >> displayed before. >> >> To be safe, I suppose I should restore this. >> >> Thomas, opinion ? > > I'm OK with the log message added for this error case. > I would just keep the -EINVAL return value. Ok will do. -- David Marchand