From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id AA11972FA for <dev@dpdk.org>; Fri, 16 Sep 2016 16:30:03 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id b187so40241069wme.1 for <dev@dpdk.org>; Fri, 16 Sep 2016 07:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=59Cj5Qm2JBbf3CkmFoW+YmDEKmMte02eUnce5nIxruI=; b=TwANJ1AdBpR1nZFuPqGU5kEOyLqmtCwmpFY9XReEWHF21V2ZM6+NbOKxBPEj20kvCp +QYMcBXCVRSXdJul6SnCqsUngXi+yNc5XlBth9km9so9uM+LwTs21Q2fspFuHKrqFyl6 /+yIYRe5/qsUj3ia/9543eFRsDpUIlp55jnFvesBZS7792uvJnMtzdC4ZOeHCmLr5ckj wJ2mos2vaPJG02qAIJXK29OT0LqvrVHhO7wblSs3W6BjfQ2bAjtitOoV68mzji8zWWS0 FCR+TCZ/PrvFEqv4hb204+4Fny8j2Jhm1fb2jtTNvEn9sbEIZ3eN6k2/zg9YNeyxTm+N CEyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=59Cj5Qm2JBbf3CkmFoW+YmDEKmMte02eUnce5nIxruI=; b=YGOoXX2C4CG4RsG/UpvIho8DZxN9pp5NS0OkSsqCttHBNblXU4XErQz08A858k57f4 abwLZStysGmeDQMXQ1BZrF0Sqi3x3Q4U2c006+05MMmiPii09W98U0i0K8KL72Pnb/oM rcvVO6fiYc4cvy4HwzCfGNAn8VjEBXjdsZ7ICf35LqDdmZnAchHdNRACg8PvPZTlD3Xo Wado7rZqYcu58YePxOyOv8vz1R9f7TocLFAEMKxfIhrIt+hkpFCXggtxGBTaFAvkpVSF IvIqH7EwBauAGXffJSe4J9pG2edQA5R0WgrxTJUIV6ioRJHtVmoE6iGsAv68kn9T61bP lbWA== X-Gm-Message-State: AE9vXwN98+b5tn00LdWX6iOmrXO3PykL7N2teO/e80jey0u4GnwcLeDAv4M/hj3dwNU5dd1paVoQDKp/v/ynbqsJ X-Received: by 10.28.35.65 with SMTP id j62mr8030961wmj.33.1474036203361; Fri, 16 Sep 2016 07:30:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.95.130 with HTTP; Fri, 16 Sep 2016 07:29:42 -0700 (PDT) In-Reply-To: <CALwxeUusnzO9daPnHkkf5QhY6_g67f-9oDzKcrhzXj7X3Lm_kQ@mail.gmail.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1474000200-16705-1-git-send-email-shreyansh.jain@nxp.com> <CALwxeUusnzO9daPnHkkf5QhY6_g67f-9oDzKcrhzXj7X3Lm_kQ@mail.gmail.com> From: David Marchand <david.marchand@6wind.com> Date: Fri, 16 Sep 2016 16:29:42 +0200 Message-ID: <CALwxeUv5Dwa1fpPKX5c3F9a_=yjaWbvYALY-fZhqVM8j=gGx8g@mail.gmail.com> To: Shreyansh Jain <shreyansh.jain@nxp.com> Cc: Thomas Monjalon <thomas.monjalon@6wind.com>, Jan Viktorin <viktorin@rehivetech.com>, "dev@dpdk.org" <dev@dpdk.org> Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v10 00/25] Introducing rte_driver/rte_device generalization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 16 Sep 2016 14:30:04 -0000 Sorry dropped the ml. On Fri, Sep 16, 2016 at 4:21 PM, David Marchand <david.marchand@6wind.com> wrote: > Commenting in the cover letter because these are details and it is > easier to track down what is missing before push for Thomas. > > >> driver: init/uninit common wrappers for PCI drivers > > In this patch subject, init/uninit -> prove/remove. > > >> eal: define container macro > > This patch is fine, but not used in the patchset. I would postpone it > until we actually need it. > > >> eal: extract vdev infra > > This patch commit log tells that the vdev register macro does not call > DRIVER_EXPORT_NAME while it actually does so. > > >> eal: remove unused PMD types > > This patch commit log has some outdated note about pmdinfo. > > We still have a reference about PMD_REGISTER_DRIVER in the > documentation that could be replaced with a note on > DRIVER_REGISTER_PCI() > But I would do this in "drivers: convert all phy drivers as PCI drivers". > > >> eal/pci: replace PCI devinit/devuninit with probe/remove > > This patch only replaces the init/uninit methods with prove/remove for pci. > I would generalise this to vdev as well. -- David Marchand