From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id DFB8A2A58 for ; Mon, 12 Sep 2016 09:15:27 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id 1so127812004wmz.1 for ; Mon, 12 Sep 2016 00:15:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=KU3/jTBQ8WzS5dqk0T89QsCtryH3Nag1a26wmPsKv/w=; b=OWaljrFWZQbULmfvnHbAduRmayLK1YMSQwwbRGtR7KPuBdoFQPdhdVHO6DRsrFvNnw UpP542ZufKzKDTE4vyVUQnTsX/JyeLBK695jKIscOuSOuuKS6fZImKoVJELnAEHAgR+7 dMSz0g7QBpOUhpHJTw6caZKwZ4dzCTJykAoj9A7n4S7q9zEJ40Beuavp+o80Wj9mcdei N0HvQm0nGfINTMsoda6zrgj+5zqthplgLz+6IR033ZqxQkHQ6TCvL2Rp/LJjuvQeZr+6 G+6sNlm+sccb/cMy9W8B8v1r4cqbh8H4QQqefWJE688lmx1E6qz8JyCUomHpc6X6GUid hRhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=KU3/jTBQ8WzS5dqk0T89QsCtryH3Nag1a26wmPsKv/w=; b=eJf/WIqEeiPxndcceo5Yqu2F9eyGLPujcwU5oBbKpNj//xD+m7++lExWID9nQ/tQq5 M7tY72JJp9zuewsdBclm+q8NS/VRdWnXFz1c1ca5qPPMonfQxFddwPJvWH8HnpJzWAUN veaH/ySAFZLx7I6udp30dCIvgqusUfRk1Nnxb5PRvpROGuM9vxePdQlSGtEAa6QrNS+9 SLKotU4P5qwluhoZLuaDW8eKsoWCD6JG2+4op49Hx6dWialvWhSlUeqA9UDMZgxfyfLS YcNeBlVOSXwzRo3Wqsfa7P8Y1y6xh6g1gwhLIfzsOwoLqzDyhVgYBpBVK+7LKmNcUVxf No8Q== X-Gm-Message-State: AE9vXwOsCpSklehZTzM6F+hjwj5yLecMOQHNo18hCAGRSbebhN/mf0Q0gxGLrXx4IOAq1/hQEfD8NURjHSG/YdzB X-Received: by 10.194.192.35 with SMTP id hd3mr13648827wjc.27.1473664527708; Mon, 12 Sep 2016 00:15:27 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.97.213 with HTTP; Mon, 12 Sep 2016 00:15:07 -0700 (PDT) In-Reply-To: <1473257297-7221-7-git-send-email-shreyansh.jain@nxp.com> References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-1-git-send-email-shreyansh.jain@nxp.com> <1473257297-7221-7-git-send-email-shreyansh.jain@nxp.com> From: David Marchand Date: Mon, 12 Sep 2016 09:15:07 +0200 Message-ID: To: Shreyansh Jain Cc: "dev@dpdk.org" , hemant.agrawal@nxp.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v9 06/25] eal: introduce init macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 07:15:28 -0000 On Wed, Sep 7, 2016 at 4:07 PM, Shreyansh Jain wrote: > diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h > index fa74962..cf673e4 100644 > --- a/lib/librte_eal/common/include/rte_pci.h > +++ b/lib/librte_eal/common/include/rte_pci.h > @@ -470,6 +470,16 @@ void rte_eal_pci_dump(FILE *f); > */ > void rte_eal_pci_register(struct rte_pci_driver *driver); > > +/** Helper for PCI device registeration from driver (eth, crypto) instance */ Typo: registration > +#define DRIVER_REGISTER_PCI(nm, pci_drv) \ > +RTE_INIT(pciinitfn_ ##nm); \ > +static void pciinitfn_ ##nm(void) \ > +{ \ > + (pci_drv).name = RTE_STR(nm);\ > + rte_eal_pci_register(&pci_drv); \ > +}\ > +DRIVER_EXPORT_NAME(nm, __COUNTER__) Checkpatch complains about a missing space. -- David Marchand