From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 80BBB376D for ; Thu, 28 Jul 2016 14:18:49 +0200 (CEST) Received: by mail-wm0-f49.google.com with SMTP id o80so105212259wme.1 for ; Thu, 28 Jul 2016 05:18:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zfmEIWoNzQaUM6OTh7hOvbsJOjq5NtgypVU/LFUdNQA=; b=EOYjlA/TLcORW/kdvw0zb9I+Izgpqpmbqoy7Y5+PdapfNn0wACJBrJtxTEuxdeVeRX EOasnD/7xVFU3RKAzToUuFXhh8jxvcXhC4q7sXWvofb3wncOZdAUSJBAPK8XNOMnva0J eNjoX1ztBtM/Diha/r7lQyueyRLRMXu2DwdIQc4GNxinD2d6wl+LfGS3lnJbZrjh9EIn 6AlM3XvVNiqUKCVWH6XDXWgCreWPqlZcc3YJ5QDjXanyJHOD3+eZu9emcmEaBCwg49OE m4niq8mUxzt/ShDqsPBzV1VlkfaSng9qxoOTwTxbEktaAtndd0Rn7o6U+77bKQysovKk s/QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zfmEIWoNzQaUM6OTh7hOvbsJOjq5NtgypVU/LFUdNQA=; b=XgSbEz+rCB9L8ZMf+3IphscGUnzg252On8Wg/Pf+jVFZ3DgllAZv84PZsFPooBH3P0 KjeAB34ZI2t0jT460M52CeN3jMKTfcNJYao6b5SK6xJ+r/CORpD+Kiyq7fzdmDs0nRzk YfM9SOl69gWvw25ab/tAC7o8eN37I9jtcKjmQOostSjWGmI7KsUv+jIsS92pCsGftlFc 9iCi7M9ncg62dj7FEX7278+twcQqkMTsn7JYo3+sWWjY+o/a3MKyyql77Rwc5eViXeaZ 1y7DtWcwBpfRV5XTj85xb0XNE6XyISYEyq4vDz1nIe4IUASHSmodGnIBoDAL5ZVt/ubv hL2g== X-Gm-Message-State: ALyK8tI39HB5nLLvCjsTT2C8geXqXZ2n21MCFMkijLoKr/E/bGUc4uiNxp8RON8x9nCpz7vc3/kG/kRfVkHMK8eE X-Received: by 10.28.107.88 with SMTP id g85mr49564415wmc.49.1469708329227; Thu, 28 Jul 2016 05:18:49 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.175.210 with HTTP; Thu, 28 Jul 2016 05:18:28 -0700 (PDT) In-Reply-To: <1467643848-14780-1-git-send-email-pablo.de.lara.guarch@intel.com> References: <1467643848-14780-1-git-send-email-pablo.de.lara.guarch@intel.com> From: David Marchand Date: Thu, 28 Jul 2016 14:18:28 +0200 Message-ID: To: Pablo de Lara Cc: "dev@dpdk.org" , "Mcnamara, John" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] doc: announce API change for virtual device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2016 12:18:49 -0000 Hello Pablo, On Mon, Jul 4, 2016 at 4:50 PM, Pablo de Lara wrote: > In order to create a virtual device, user needs to call > rte_eal_vdev_init generally, but this function returns 0 > on success or negative number if error. Instead, something > more useful would be to return the port or device id of the > device created, so the user can call rte_eal_vdev_init > function and use the device straight away, using the id returned > by the function. > > Signed-off-by: Pablo de Lara > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index f502f86..60cc7c7 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -41,3 +41,8 @@ Deprecation Notices > * The mempool functions for single/multi producer/consumer are deprecated and > will be removed in 16.11. > It is replaced by rte_mempool_generic_get/put functions. > + > +* The rte_eal_vdev_init function will be changed in 16.11 to return > + the port/device id of the device created, instead of 0, when it has been > + initialized successfully, so user can use the returned value straight away > + to call all the device functions that require that parameter. > -- > 2.5.0 > This is a layer violation. EAL does not know a thing about "ports". This information should come from the crypto framework and so an api in crypto framework is the right place, not EAL. This is a NACK for me. -- David Marchand