From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f171.google.com (mail-ob0-f171.google.com [209.85.214.171]) by dpdk.org (Postfix) with ESMTP id 890862BAB for ; Thu, 10 Mar 2016 08:43:57 +0100 (CET) Received: by mail-ob0-f171.google.com with SMTP id ts10so72623129obc.1 for ; Wed, 09 Mar 2016 23:43:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=mz8kqBY+9WhYVeva9RpchcPhuvRDaU4gehGdy0uE92A=; b=oFClMuqBK7SfPQGZCe42t5Bu2FNdpbPmlem9ARQB6YJi6Reb0Qf4cHBe+KJ3cMV7ZQ fcLoJ+cyhdzfcx5jK9X9Ed6lwA1AWH5jb2bSRvaenKkCJyq9X3OAM9DCxHq1v1pIJpO8 ELWqW+1kksQOoZbpfhQVAKlYIF09lU1tSPMU+zKPvoR6wbDVI9sOsJ+ryK96EjUCYBtu adn9HQGlVcgtMy+VCxHG5Etwv/vdGDsKjxsBWS7U5rsz5YV8fypa0C3BiLtEPVhxFrKy 5s5F8NGq9ntPOZta8LOZbCU0SnoPst/fYKvIwJgfzy70sgfq2X2pNHylZK5izSUZHMBG X3gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=mz8kqBY+9WhYVeva9RpchcPhuvRDaU4gehGdy0uE92A=; b=hgwIUTGYHoymeFJEHdx2MZ86OPTq4/Zih2SNoPeRDWBJbXnA5H0ZXQjhVfrsjLb1t5 cAy7ZceyGb5Lng+sPTaOOnlImpsdGCiVqyhePIlaGzU9hP3j3545Zh2HtB20L0MU9C7a Q5gTBWiKC6Dwdi5apLQEhNXQe4/0QtT3BAflk5q/6BuCxz0KoC0pwiMxmtlSrGVtmIAB l5fJrpTL30hxiADRZ1z9foRPRZZNOxaXtbPBvJOjIMyPZZxaWLfAv403VLDv5Ah6ro/9 m8dbtvjZoqAGV37w7xJynrjst9LJPAYZG4bGNKhURcHR7vtrVriRqFUwQy3uDQnlERWO iF7A== X-Gm-Message-State: AD7BkJKgSMkiuDn/6MwxpNq/N5+WXjwqe0avpEJkjzgMVSBLuEZtR7ROqbUlbJckuTRzblewsg+UO1XGfQ3wlMUd X-Received: by 10.182.86.33 with SMTP id m1mr1150736obz.48.1457595836938; Wed, 09 Mar 2016 23:43:56 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Wed, 9 Mar 2016 23:43:37 -0800 (PST) In-Reply-To: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com> References: <1457593280-25412-1-git-send-email-yuanhan.liu@linux.intel.com> From: David Marchand Date: Thu, 10 Mar 2016 08:43:37 +0100 Message-ID: To: Yuanhan Liu Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] virtio: fix wrong features returned for legacy virtio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 07:43:57 -0000 On Thu, Mar 10, 2016 at 8:01 AM, Yuanhan Liu wrote: > Declare dst as type uint32_t instead of uint64_t, otherwise, we will get > a random upper 32 bit feature bits, as the following io port read reads > lower 32 bit only. It could lead a feature bits that include VIRTIO_F_VERSION_1 > (the 32th bit) for legacy virtio, which is obviously wrong. > > Fixes: b8f04520ad71 ("virtio: use PCI ioport API") > > Cc: David Marchand > Signed-off-by: Yuanhan Liu Argh, good catch. Relooked at my patch, this should be the only bug (of this kind ;-)). Reviewed-by: David Marchand -- David Marchand