From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by dpdk.org (Postfix) with ESMTP id B754B2BD0 for ; Mon, 7 Nov 2016 14:27:14 +0100 (CET) Received: by mail-wm0-f50.google.com with SMTP id t79so177174820wmt.0 for ; Mon, 07 Nov 2016 05:27:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=C+0wjDuTIPWobO2thgaIkjmWgA4YG4fpOO5I7ud6bss=; b=gl4X3zby6MqDgkbh7o8JKbOBGu1tzeW3R9J0VpVi84aPRSEZgZbGEyVCk0Q821+SFF RbVmKrz4lPpJ9fG9HbOeB0cYChXHQ75bDzz2qdo9SMevvAxTUZZaPFGYsmx5cnKTUJSY wkci5/dB7LTkvCvz+pdVSnzpoEr2zGHHBlfRo/9MvxVQutlcnnjQCcbBT8lvVQ3g0Mx5 EJC5oLq1yZhptXwnmy5JB6pgGJ0xIrk9UwAjt8pFaCOUFn8oTHYhCJFI9zmuo30FhLf0 a5elgRlrwkFwROfieCxuqbMaco/NvcabTO8JFXPelTF5MQ6RpGyqPJGQQ3ozRYxgeQDa DNiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C+0wjDuTIPWobO2thgaIkjmWgA4YG4fpOO5I7ud6bss=; b=hXi7cuwA5MBSUaJFxRtoetupDPOsYgfqaAZZZMSa/ui6gK1TtKJT9uz7JpzGOb+xTQ 621esMCvYsUCOG5PXCSVCz1OPxqb9IP3hRV9+xr7OQeU8cX1W61u+IkdSOz8A+d8CgHb bYVaKLAuMCgOwLtdAfsBF9eKaOFrZMWq4iu3OaRIJEzm1aVdIbY3HyDycdkEKyGCqpLP TjuCMI9Flp8GWHj39P7TXopgzTkOBENLg3BqBoosXbz9CTvI8H9JCLIdfYbKUo60jHiv R6/cHBlU3M8lE6wFBsDTMVh2aRxbmCL2GfDPitZ3mPv4RNGLi64VfpZnngkyStKNdo8R cdiA== X-Gm-Message-State: ABUngvesLE2R/uSn/Mwbbt2GGu8RsrJ6RHnR42u8HXXETowZH3mPItmQFcxwqblQNorV17fiDjAk5SCIK1ckLel9 X-Received: by 10.194.168.129 with SMTP id zw1mr7168027wjb.26.1478525234462; Mon, 07 Nov 2016 05:27:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.188.6 with HTTP; Mon, 7 Nov 2016 05:26:53 -0800 (PST) In-Reply-To: <1470311406-38841-1-git-send-email-iryzhov@nfware.com> References: <1470311406-38841-1-git-send-email-iryzhov@nfware.com> From: David Marchand Date: Mon, 7 Nov 2016 14:26:53 +0100 Message-ID: To: Igor Ryzhov Cc: "dev@dpdk.org" Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH] pci: fix one device probing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2016 13:27:14 -0000 On Thu, Aug 4, 2016 at 1:50 PM, Igor Ryzhov wrote: > The rte_eal_pci_probe_one function could return false positive result if > no driver is found for the device. > > Signed-off-by: Igor Ryzhov > --- > lib/librte_eal/common/eal_common_pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/common/eal_common_pci.c b/lib/librte_eal/common/eal_common_pci.c > index 7248c38..bfb6fd2 100644 > --- a/lib/librte_eal/common/eal_common_pci.c > +++ b/lib/librte_eal/common/eal_common_pci.c > @@ -344,7 +344,7 @@ rte_eal_pci_probe_one(const struct rte_pci_addr *addr) > continue; > > ret = pci_probe_all_drivers(dev); > - if (ret < 0) > + if (ret) > goto err_return; > return 0; > } Acked-by: David Marchand -- David Marchand