From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.marchand@6wind.com> Received: from mail-ob0-f178.google.com (mail-ob0-f178.google.com [209.85.214.178]) by dpdk.org (Postfix) with ESMTP id E37C193B0 for <dev@dpdk.org>; Wed, 27 Jan 2016 10:40:36 +0100 (CET) Received: by mail-ob0-f178.google.com with SMTP id is5so2656101obc.0 for <dev@dpdk.org>; Wed, 27 Jan 2016 01:40:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=0hxgCnuO/lL4haj2gSqfe7A00OxOqBr2HDBXNa5SxdA=; b=N6SQ9h+YUpoxYGeMUWyoHIE7q63SIS8reHXXSAnFAb+wMMCvNFUgQypBcXO/zYQptD cbZ9voBnoRt9lLDeflpV6DXW0k85LhPY0W/5wjOL/QgceseStFpEgbznxFfvZBZR6DPW 7Rm5RxEAboFMIV4P1qrPY2CSgT8BHQwPa1gIun60ToO6/ixoO8WdtPPgaFqWlCc/BucW jbQty1LmWFl0pCfSDFay61T7TailtEhiBScLu3DgbpDq5FMXmzMdH+z3rNM/ufDKFqF1 mXsgM/b3WRD/pgZevZETts+38LWbPOC+FmxElgDe+bTt/xCp+DMB3f58MlMSXq5AjtB1 2M3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=0hxgCnuO/lL4haj2gSqfe7A00OxOqBr2HDBXNa5SxdA=; b=XqVums07BcTgL21CyO0o1amOxduUr0+POVbIwHcjqkD9kDxdj28jzOC4BvZwCpK8Cx uo4DnfLD5FPq6G4iFsOiXItcARar0O4sAMd2Bf7jYWIrtYaWzId4vpHQ6eRZhL5FIo4p 4NBLvWSx3msliPR84g8xKVSJwl17joZAisMH15/rUiYXPBLVjdK4k0Adbtm7q3FMkxRs aLYJzf6lnf5Vu/elpjLvaZz7JJ//eM7CmUnKDC7KIYNQ29jYA2CdugU3BJT5xzPPeJaQ 1eGWar5wQf1cDF3EympvCzRDi+hMihzyQlhYUMZ+Cg/cVrAk8b4czvqyQFhpgAlv6A12 dljw== X-Gm-Message-State: AG10YOTNgPesrljI8Woz2cFSLOtz0UMfwK46794fes0eMMp50oy4zo1ilKRDB8EGHYdXCnABiJ3lt5x0B7X6vg5U X-Received: by 10.60.82.229 with SMTP id l5mr17482949oey.6.1453887636335; Wed, 27 Jan 2016 01:40:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Wed, 27 Jan 2016 01:40:16 -0800 (PST) In-Reply-To: <20160126165026.21738001@pcviktorin.fit.vutbr.cz> References: <1453377431-25850-1-git-send-email-david.marchand@6wind.com> <1453471618-29722-1-git-send-email-david.marchand@6wind.com> <1453471618-29722-2-git-send-email-david.marchand@6wind.com> <20160126165026.21738001@pcviktorin.fit.vutbr.cz> From: David Marchand <david.marchand@6wind.com> Date: Wed, 27 Jan 2016 10:40:16 +0100 Message-ID: <CALwxeUva3rtq0UJ=RVDCEYceTfGm2C4DyAUx9FAZ4bdN2pMcbw@mail.gmail.com> To: Jan Viktorin <viktorin@rehivetech.com> Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v2 1/2] ethdev: remove useless null checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 27 Jan 2016 09:40:37 -0000 On Tue, Jan 26, 2016 at 4:50 PM, Jan Viktorin <viktorin@rehivetech.com> wrote: > What about the RTE_VERIFY? I think, it's more appropriate here. Well, here, I am removing useless checks in static functions. But for the rest of ethdev api, I agree we could add some RTE_VERIFY. > Otherwise, feel free to add: > > Reviewed-by: Jan Viktorin <viktorin@rehivetech.com> Thanks. -- David Marchand