From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com [209.85.218.41]) by dpdk.org (Postfix) with ESMTP id 91FE15A50 for ; Mon, 2 Nov 2015 17:06:14 +0100 (CET) Received: by oiad129 with SMTP id d129so97360408oia.0 for ; Mon, 02 Nov 2015 08:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind_com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=7PvtkPEsNSGTgliy9gVG3Dn0HMSZqwp+UXvp4pig8v8=; b=OUkbCn/D7XSeTrXHBUv3qaKi0yvogh9rFoCtm1+L7DX8NUH4kkHjFVxELzedBfV9J+ V28jeoqGgpEJgIEGCOCu/ZUbkO8iypD6kdZRSYdBf3HjQMdFO9VokruHGp9eP2sRyhP6 RsascEScXWzLX+3OmpOXMp1xgL+O0KGuj9WhBJ7t/6WgyVy5OKZBmk5FSBajEJ93CSnc HiG5HYrj5TakEotUyfTakEry7xO0DhskSbx1W+/Ex5urldlM0lkrlL83LgbY5CaXOaC/ /eTJAByRhkbZqwaYLaXo70ZGZMLqjxsq5V2T19lPeJ56mbvwxxwR7GRdYuDayGNKECD+ jQ+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=7PvtkPEsNSGTgliy9gVG3Dn0HMSZqwp+UXvp4pig8v8=; b=A/JBmw9VQ8YXPHsH+OmgeDKsr+zz/GhtQEyLAEPazAyH1dlR6F7UAKv5vjbOsyo5vt KXiS727QQXgIsk5+VAFfzIp/4ISGe2te/0f6ua8SxZsEEoG1zQegmQh11wToa9U0Ty1q yumuJg8uJLR19brBwkf6AiSUyKkslw18t8b1zWcfxJ2JoeSHsGthfmhpfQxCa7OTtd3D LBDnkVNi7k+QiAQlJcQPt4bMTSpfbjJqw1oZPj93mWzYw67ZIhk9HRiwS+u95J89Ol5Z l9B90sYp8SEdDy0FPiYdZpixFtIsDFKUNR7ypSfl3cmiA+DxALh22py30ibOQuRZCATV M6eA== X-Gm-Message-State: ALoCoQn+1m8gqY1cFdgQC1MSyRLkv+avBh8GgkWzVRelLA2/ix0OlpwM7RXsyQjh7m+19wJDdcT9 MIME-Version: 1.0 X-Received: by 10.202.69.85 with SMTP id s82mr14193864oia.46.1446480374066; Mon, 02 Nov 2015 08:06:14 -0800 (PST) Received: by 10.76.131.166 with HTTP; Mon, 2 Nov 2015 08:06:14 -0800 (PST) In-Reply-To: <1446182873-28814-8-git-send-email-cunming.liang@intel.com> References: <1443072831-19065-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-1-git-send-email-cunming.liang@intel.com> <1446182873-28814-8-git-send-email-cunming.liang@intel.com> Date: Mon, 2 Nov 2015 17:06:14 +0100 Message-ID: From: David Marchand To: Cunming Liang Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2 07/11] ixgbevf: cleanup unnecessary interrupt handler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Nov 2015 16:06:14 -0000 On Fri, Oct 30, 2015 at 6:27 AM, Cunming Liang wrote: > As ixgbe vf doesn't support lsc, the patch removes those unused code. > In addition, it does some tiny cleanup. > Please, can you describe this tiny cleanup ? Did it trigger some bug ? > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 366923f..794171c 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > [snip] > @@ -3492,11 +3442,11 @@ ixgbevf_dev_start(struct rte_eth_dev *dev) > ixgbevf_dev_rxtx_start(dev); > > /* check and configure queue intr-vector mapping */ > - if (dev->data->dev_conf.intr_conf.rxq != 0) > + if (dev->data->dev_conf.intr_conf.rxq != 0) { > intr_vector = dev->data->nb_rx_queues; > - > - if (rte_intr_efd_enable(intr_handle, intr_vector)) > - return -1; > + if (rte_intr_efd_enable(intr_handle, intr_vector)) > + return -1; > + } > > -- David Marchand