From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f174.google.com (mail-ob0-f174.google.com [209.85.214.174]) by dpdk.org (Postfix) with ESMTP id 305AC8E7A for ; Thu, 21 Jan 2016 12:33:43 +0100 (CET) Received: by mail-ob0-f174.google.com with SMTP id yo10so7270111obb.2 for ; Thu, 21 Jan 2016 03:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=xWePM5E5uS4uEbExPZNoMqvlMHaHSVPf+ymmFtkOMSo=; b=w6GhkTodT/Qm9xR5rU/xJxlWslWorxF4pz3KlTwfhMRpDGufXI7EYvKyGu1OnctdkN qTUKDCkk8bgwW/3kMO9YyLwkr2RUUWiTTqBhAiVKwR7/Jge/kFLkHs48Vbfr4b0Kj3Qs WFX9vGBpPOL5G1Xpvgj9799AIb0r3NXRmIXm4uDscWUSoURaytdQRRyacSR8S7SVGz9N Ij3iamP/c+mNcEZbGOVayR4r0XsLdoz3Cjfq4ZCE41jJbQ0tSUvXp9SmsKXEFY1JuRJE 3BuJMY7PoKYZkPc/GZWrOWyRM6uN4bRsqZHppfhfTz0dpzwhPOgGdlFOFlJS45T7Gu3W rnyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=xWePM5E5uS4uEbExPZNoMqvlMHaHSVPf+ymmFtkOMSo=; b=gMuH2pfsakXiSlbZHHNAA+tXZDUDort0Au8TwaXM4BVBT1+CDmhtJeQisiIFRYtW1z 5wagZYMcjQyFqgWYPOPHRCm7C4usQrvwEhIhBnFCHkcfatT4r56QQTU5LjicK0XGRk8A Hsj+HFtmMy0nA9DcxU6EWCVgGcbB8ktyiTn7s85LWTtppdjxHMMXTuV2xwaIcuLVcLbk uc6lq5us9b6I3J1U5lSqpgv6wQoCeT0q5P27vt2yHf/8rvLA+ZgE3mFMJjzeALD1SIYU qCFxUZUaceCb8uF7We2XKTiD4UGjmZs7nN+bgqbRyAxvRKxCOGggVuvnGtgzmsYZLX9u VhcA== X-Gm-Message-State: ALoCoQnofihe0s52nRj57B6hq9PCVWH3gW4kH/qwE+l+FnOho0nIN/Zu7547q1ovDdYkBaz+cTY00TL32BANNOmnGuHHFp7o/AktzOa5wc4rS/q30XbAYR0= X-Received: by 10.182.28.162 with SMTP id c2mr31672080obh.76.1453376022590; Thu, 21 Jan 2016 03:33:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.76.180.72 with HTTP; Thu, 21 Jan 2016 03:33:23 -0800 (PST) In-Reply-To: <3415689.rt0oTMTjK5@xps13> References: <1453375399-25576-1-git-send-email-david.marchand@6wind.com> <3415689.rt0oTMTjK5@xps13> From: David Marchand Date: Thu, 21 Jan 2016 12:33:23 +0100 Message-ID: To: Thomas Monjalon Content-Type: text/plain; charset=UTF-8 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH] no need to test for NULL when freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jan 2016 11:33:43 -0000 On Thu, Jan 21, 2016 at 12:30 PM, Thomas Monjalon wrote: > 2016-01-21 12:23, David Marchand: >> free() already handles NULL pointer. >> >> Signed-off-by: David Marchand >> --- >> app/test/test_devargs.c | 3 +- >> app/test/test_link_bonding.c | 6 ++-- >> app/test/test_pci.c | 3 +- >> app/test/test_ring.c | 36 ++++++++-------------- >> drivers/net/xenvirt/rte_eth_xenvirt.c | 6 ++-- >> drivers/net/xenvirt/rte_mempool_gntalloc.c | 9 ++---- >> examples/ip_pipeline/cpu_core_map.c | 3 +- >> .../pipeline/pipeline_flow_classification_be.c | 6 ++-- >> examples/vhost_xen/vhost_monitor.c | 3 +- >> examples/vhost_xen/xenstore_parse.c | 33 +++++++------------- >> lib/librte_eal/common/eal_common_devargs.c | 3 +- >> lib/librte_eal/linuxapp/eal/eal_memory.c | 3 +- >> lib/librte_ether/rte_ethdev.c | 6 ++-- >> lib/librte_kvargs/rte_kvargs.c | 4 +-- >> 14 files changed, 41 insertions(+), 83 deletions(-) > > Have you used a coccinelle script? Nop, some shell script of mine with manual checks. -- David Marchand