From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yw1-f67.google.com (mail-yw1-f67.google.com [209.85.161.67]) by dpdk.org (Postfix) with ESMTP id A96794C90 for ; Mon, 10 Sep 2018 07:56:59 +0200 (CEST) Received: by mail-yw1-f67.google.com with SMTP id p206-v6so7418732ywg.12 for ; Sun, 09 Sep 2018 22:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7TtA+DR8EpQUDPXC4+ZHBlHE/WtopA9C01p+2yW1ueQ=; b=hX+fxL0HwztFz1hDceOodueLKmViI8SO9Og240fx06uL7eDjxgL4zKyGW6rLRJE3/i V/jqn8oR985tGZIAkqjsM7G/Cc74oLbXlZ7OObd/ewX3YAo9bX4kd2xaw+GKuHL87fWs tNiPbohItajdHmQ9WF2ZzOLFXWfJjNLir2lwhzpFjO3HwwgCZo8r0lsQU458DEZAhLOx 3bmUEQ6e+0/lHgikMrJy1Ewf4TCMMm2XBeuovFPY/FUBwkhRVKSmODpZ8+70CL7vehzZ kLTcoD63HgWZJ8wrYC5CEBcO/eEK4OM7ow4cmEBhx+hjxAqCTwLoQ2leZdBW9R2DWnPl 6A/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7TtA+DR8EpQUDPXC4+ZHBlHE/WtopA9C01p+2yW1ueQ=; b=ZN5XXF1gOZIA93qdiWnuYIJ9t4etKTJ+ZiN7Ba/703tSw00ZEcb4lwwF+9ozzHjE1/ eEMUwvMqGDvwlhaxhTs6AUjN+pasKB/DgSpm1plTJ4UM8y65hQhVJ/2SnK3BPQEMJ+xb QIoYQ8fUuYPI8x7ZKDVD7n0CoEgGMgRC4h6Dzer6N6yb8dAiY4v6Ex6A7YDRoSNWR2ld dqRZ2ryjkHXf/mhkajihLV5kIgiMcVvElNkSY5N+ibI8Xf77R15jUC9NpAGkKKOa9fNU F0x+j+K+/ay2RaLHW4seDt47lmOEbynFXQ8b9HzdRXVAPS+m50Syg6ZMSTXWdJGsGT5y ISgw== X-Gm-Message-State: APzg51BZ1Hj3Yi12P70gjGLsJh3XiOXXG2EBhKkUdAjtOuIL/lyfFrpR iTf+xSGjC1UQ20QagPQPFj551wRwujhzt/F1hnyvgQ== X-Google-Smtp-Source: ANB0Vdbt/yol6nzoDNPzG0q6SMUJA5SmFIQ+QwsPvN3IydtA0a+bLP6dHj5WsdT3qm7DG7z0hDGI9+MGC/RQlhe1Qik= X-Received: by 2002:a81:9dc8:: with SMTP id u191-v6mr9732351ywg.274.1536559018858; Sun, 09 Sep 2018 22:56:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:4bc3:0:0:0:0:0 with HTTP; Sun, 9 Sep 2018 22:56:38 -0700 (PDT) In-Reply-To: <20180910054547.18494-3-david.marchand@6wind.com> References: <20180910054547.18494-1-david.marchand@6wind.com> <20180910054547.18494-3-david.marchand@6wind.com> From: David Marchand Date: Mon, 10 Sep 2018 07:56:38 +0200 Message-ID: To: Neil Horman Cc: Olivier Matz , "Lu, Wenzhuo" , "Wu, Jingjing" , "Iremonger, Bernard" , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/3] mbuf: add a non fatal sanity check helper X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2018 05:57:00 -0000 On Mon, Sep 10, 2018 at 7:45 AM, David Marchand wrote: > Let's add a little helper that does the same as rte_mbuf_sanity_check but > without the panic. > > Signed-off-by: David Marchand > --- > lib/librte_mbuf/Makefile | 2 + > lib/librte_mbuf/meson.build | 2 + > lib/librte_mbuf/rte_mbuf.c | 74 ++++++++++++++++++++-------- > lib/librte_mbuf/rte_mbuf.h | 23 +++++++++ > lib/librte_mbuf/rte_mbuf_version.map | 6 +++ Applied a little patch on devtools/check-symbol-change.sh @@ -115,7 +115,7 @@ check_for_rule_violations() if [ $? -ne 0 ] then echo -n "ERROR: symbol $symname " - echo -n "is added in a section " + echo -n "is added in $secname section " echo -n "other than the EXPERIMENTAL " echo "section of the version map" ret=1 And here is what I get when I check my patch with it: marchand@gribouille:~/git/dpdk$ ./devtools/check-symbol-change.sh sanity/0002-mbuf-add-a-non-fatal-sanity-check-helper.patch ERROR: symbol rte_mbuf_check is added in +EXPERIMENTAL section other than the EXPERIMENTAL section of the version map Is this because the EXPERIMENTAL section is added in the same patch ? -- David Marchand