From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ob0-f175.google.com (mail-ob0-f175.google.com [209.85.214.175]) by dpdk.org (Postfix) with ESMTP id 6ADC9C728 for ; Fri, 19 Jun 2015 11:54:30 +0200 (CEST) Received: by obbkn5 with SMTP id kn5so42679838obb.0 for ; Fri, 19 Jun 2015 02:54:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=l92/xMU/NhtZykBT9RGkBN+vxGWPAF9bbCWfmBamXSk=; b=AXVYzo84p0s85ceYGfbxzxSJTg59Nt+TMvR5ycP550EOX+nvjcHXNSzlA/lo/k1CVK eoNdqUW1XBKBZxrLXerT7gBNgzDD4i6ZGH2lY0yp2rlum2eyVbc1P5Z6YwYMOcYQFwEQ Ln2f2V4YhSPyvBSk2N4usi+gZuegFDzpP2LPiYV+E19COehPjHTbKP6+dRAgrkEjQgyi lDSBsHoBYjGtWPpoAuw627JBVefhN+3KSHKYMW8nbnMYJj1Olbk4y+HUqx5VMpiXW+T+ 9P+WpaQMY+jim+lNyoiOnYMUABMghQiZGPyB1C4ETlvyKcSS9ENZCQsEyTa33Mu15h2M eO+g== X-Gm-Message-State: ALoCoQniDxSOC7uv3TzGrwzMmk2y/hgYP1LlAJy3N9jwFKSr3LaDDVjf1Q6KOtvk7D4BY/b2gJVO MIME-Version: 1.0 X-Received: by 10.202.178.70 with SMTP id b67mr12279271oif.0.1434707669857; Fri, 19 Jun 2015 02:54:29 -0700 (PDT) Received: by 10.76.25.69 with HTTP; Fri, 19 Jun 2015 02:54:29 -0700 (PDT) In-Reply-To: <1433800552-90338-1-git-send-email-keith.wiles@intel.com> References: <1433635446-78275-1-git-send-email-keith.wiles@intel.com> <1433800552-90338-1-git-send-email-keith.wiles@intel.com> Date: Fri, 19 Jun 2015 11:54:29 +0200 Message-ID: From: David Marchand To: Keith Wiles Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v2] eal:Fix log messages always being printed from rte_eal_cpu_init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 09:54:30 -0000 Hello Keith, On Mon, Jun 8, 2015 at 11:55 PM, Keith Wiles wrote: > The RTE_LOG(DEBUG, ...) messages in rte_eal_cpu_init() are printed > even when the log level on the command line was set to INFO or lower. > > The problem is the rte_eal_cpu_init() routine was called before > the command line args are scanned. Setting --log-level=7 now > correctly does not print the messages from the rte_eal_cpu_init() routine. > > Signed-off-by: Keith Wiles > --- > lib/librte_eal/bsdapp/eal/eal.c | 42 > ++++++++++++++++++++++++++++++++++----- > lib/librte_eal/linuxapp/eal/eal.c | 42 > ++++++++++++++++++++++++++++++++++----- > 2 files changed, 74 insertions(+), 10 deletions(-) > We could have a different solution, but this patch is the quickest answer to the described problem. Please, fix the checkpatch error / warnings, then, ack. -- David Marchand