From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot0-f194.google.com (mail-ot0-f194.google.com [74.125.82.194]) by dpdk.org (Postfix) with ESMTP id E21C54C93 for ; Fri, 30 Mar 2018 16:16:08 +0200 (CEST) Received: by mail-ot0-f194.google.com with SMTP id m22-v6so9649737otf.10 for ; Fri, 30 Mar 2018 07:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9uIRnarQIVuPq0aPxpTDAx7tVXkU6rU3r0y8oIbX0J0=; b=WtYlWoBK9JzlK4mIAaPB8pgRsH8IkYuTUYjZmVfDxl8PDUt+X1Gxw2PMjx8i0kaeBv 4UAO1NU6aXrNQxVf8b3J+9zjPBWHYXo4Hqr/d5piQMyh8L7iLhYWI+gF+bslZwtJH5Pj iW+pkhmtDjQDJDHnIei7KlkDCrq6wa3tqZo3rZZ9CLJeK2LBtJQZrr28ijdXKf7g9lZ1 P0790nxknnTU03MFImy1qLImqGCc5ov6TUT2wlU1trkLdglb9t6uz9mGsptxqvP/MeBI IUlBD+bx9q0UZ6P40FjLxCVcX76q6gbNRro2B07lEoVXctHy0lDp79KvxOfULKNta6Bc uvPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9uIRnarQIVuPq0aPxpTDAx7tVXkU6rU3r0y8oIbX0J0=; b=hF1SQ6DYcJ4CJ/bwM/xywkpI8uDvw69WCIgj35cc6462y/iSphfNcUc23aRDLuo87Q +bn+VSl3YJCOWYgXg/M+VH0718opRRaMVwBvKpT9sLlmIq9zlHhWBo38IcV+wI/yHEaS 9/VgNN1dMC1y+roZkINTg/zNIRvSH8a9Ulkp2I58ei2ZPoTy11kM7cTYfFMdw3ZxaTGN Uv2qgxPzHeF1SsQmlUyMFWRqolj0SlXoqBelvcDX504ZA2jL4CyJ9R6UP8hBZlIReh+b TS+k87kiUd/AdNG1mBPW5wwI7Kwii5yUxDTXjTtPcCR5pV3miPl0nk5UuPVgUEcZm1Nj xLLA== X-Gm-Message-State: AElRT7GdNwl6IyDpEtIDNP/J0+XvsigwFMTIPgRq9LdBsyoXux2ILYX0 60iPKEbikjaSRnEx6eoEibqzzqfCRY4SJWStPo+11w== X-Google-Smtp-Source: AIpwx48fzj0bUjTcXZ9OnsWs4EbsPEbwR0GVYvzKGVQ0EnODZ23bCK9O0rAApZfc/sL8JWk3EQP0HzANybfZE0T+cnY= X-Received: by 2002:a9d:1920:: with SMTP id j32-v6mr7894257ota.383.1522419368044; Fri, 30 Mar 2018 07:16:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.198.16 with HTTP; Fri, 30 Mar 2018 07:16:07 -0700 (PDT) In-Reply-To: <98626f3d-c959-37d2-c238-6babc6272745@intel.com> References: <93d00a28-d52d-25b3-42d0-84b1d95c756a@redhat.com> <98626f3d-c959-37d2-c238-6babc6272745@intel.com> From: Tonghao Zhang Date: Fri, 30 Mar 2018 22:16:07 +0800 Message-ID: To: Ferruh Yigit Cc: Maxime Coquelin , Andrew Rybchenko , "dev@dpdk.org" , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] Build is broken in dpdk-next-net X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 14:16:09 -0000 On Fri, Mar 30, 2018 at 10:13 PM, Ferruh Yigit wro= te: > On 3/30/2018 2:27 PM, Maxime Coquelin wrote: >> Hi Andrew, >> >> On 03/30/2018 03:18 PM, Andrew Rybchenko wrote: >>> Hi all, >>> >>> Build is broken in dpdk-next-net for me on Ubuntu 16.04.4: >>> >>> lib/librte_vhost/fd_man.c: In function =E2=80=98fdset_pipe_read_cb=E2= =80=99: >>> lib/librte_vhost/fd_man.c:284:2: error: ignoring return value of =E2=80= =98read=E2=80=99, declared with attribute warn_unused_result [-Werror=3Dunu= sed-result] >>> read(readfd, charbuf, sizeof(charbuf)); >>> ^ >>> lib/librte_vhost/fd_man.c: In function =E2=80=98fdset_pipe_notify=E2=80= =99: >>> lib/librte_vhost/fd_man.c:324:2: error: ignoring return value of =E2=80= =98write=E2=80=99, declared with attribute warn_unused_result [-Werror=3Dun= used-result] >>> write(fdset->u.writefd, "1", 1); >>> ^ >>> >>> $ gcc --version >>> gcc (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609 >> >> Thanks for reporting, I don't catch it with my Fedora build system: >> $ gcc --version >> gcc (GCC) 7.3.1 20180303 (Red Hat 7.3.1-5) >> >>> >>> As I understand it is broken in ad94ade905454401b705be9e06b19e54a1c7814= 8 >>> vhost: add pipe event for optimizing negotiating >> >> I confirm it is this patch. >> >> Xiangxia, can you provide a fix please? >> >> Ferruh, how do you want to proceed? >> Would you revert it? > > next-net not pulled yet, lets try to fix first, at last resort if there i= s no > solution we can think about revert I will fix it soon. >> >> Thanks, >> Maxime >>> Andrew. >>> >