From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) by dpdk.org (Postfix) with ESMTP id F348E1B67E for ; Thu, 12 Apr 2018 04:11:16 +0200 (CEST) Received: by mail-oi0-f66.google.com with SMTP id q71-v6so3693314oic.6 for ; Wed, 11 Apr 2018 19:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=xZBSJcPAaWEv1FyJLSRuY2tn+hoYpuX3agUbLzXX6Qo=; b=k577UiJtdmebvGs79EqK0VlZpBBfrmPZdk11n6kKTVIF0OUWVjFH8aaotwik2yw7Rc f0zfMKt1G/qhnN9vVdjo/zvh1RnwP0ZGkGO7eAYVrzB3W2OAPcebNlDH2R1bAgYkyJsV vTX9cV+MBqZZDpIPYMWH9tLZtCWAF7Zo3fHpPuQth5/LkCpzHaj5AhY5PBrx6fEl117S jkoRiO9U5ysKOCTWsL35k5xlkaTKIjJA0XAC2x6IQSB5PkromKf15KWT21QsjKK3xVkC 6CNpd+6j1XDTSz6bIb2IpbpOsSyxmhHfrH0s09tEZ3bSz01h/Uz3k2KUqlLwmpusAiKV cznA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=xZBSJcPAaWEv1FyJLSRuY2tn+hoYpuX3agUbLzXX6Qo=; b=PhAHpcJ+5YFfkN+SvbXLAJBc0QCYF972MrP7BXk5Sf1Q/u4yvLxYYHhl5UZTtR0pOg eeS6FyFgyQgLmSf53QF04wUAszNx3RKMFFR3jwESA+2TM7Rr3vh84ik2oq1pd3PXadjT xYznqngAHqHGCDA6wAB78k1hNDoDGVQSIBv2sQNXTC6cpsPyocCkA0jZZh+Chz7297wE 9zx6gOgVVXAxJQXoNJ21q5iOJHRfVSQ+pG/QuXqVaY2ZJUDRWmpRyTOavwUWfHPWvdv6 vQb2fWPdlJIUsM4phsKTA0BMwM9YFgrzaOPMi+7ZXI/CYTDLbtZFgqCWSpwhhlN/v+zA Mo2A== X-Gm-Message-State: ALQs6tBn/Wxwd9Ly8EybMvHteyNwez6RiLZ5w1O8XxNRu/8dT7x2V940 gqKxZS33xSyWkoQiq7LOsqhKpPSuQtK2QYEZ9JQ= X-Google-Smtp-Source: AIpwx4+NiRGHuIwfLip3mvk+jL7r4u4ox5v6h0Zu8v5rD+QERlC0WI/v5j8e0j3TvcR4uUb9UgrUEtzwqCABKAwykXM= X-Received: by 2002:aca:3303:: with SMTP id z3-v6mr4778880oiz.67.1523499076066; Wed, 11 Apr 2018 19:11:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.146.137 with HTTP; Wed, 11 Apr 2018 19:11:15 -0700 (PDT) In-Reply-To: <039ED4275CED7440929022BC67E706115318FA76@SHSMSX103.ccr.corp.intel.com> References: <1517791895-3061-1-git-send-email-xiangxia.m.yue@gmail.com> <039ED4275CED7440929022BC67E706115318107C@SHSMSX103.ccr.corp.intel.com> <039ED4275CED7440929022BC67E706115318FA76@SHSMSX103.ccr.corp.intel.com> From: Tonghao Zhang Date: Thu, 12 Apr 2018 10:11:15 +0800 Message-ID: To: "Zhang, Qi Z" Cc: "Xing, Beilei" , "Dai, Wei" , "Zhang, Helin" , "Lu, Wenzhuo" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 02:11:17 -0000 On Wed, Apr 11, 2018 at 8:21 PM, Zhang, Qi Z wrote: > Hi tonghao: > >> -----Original Message----- >> From: Tonghao Zhang [mailto:xiangxia.m.yue@gmail.com] >> Sent: Monday, April 9, 2018 8:53 AM >> To: Zhang, Qi Z >> Cc: Xing, Beilei ; Dai, Wei ; Zhang, >> Helin ; Lu, Wenzhuo ; >> dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. >> >> On Wed, Apr 4, 2018 at 10:48 AM, Zhang, Qi Z wrote: >> > >> > >> >> -----Original Message----- >> >> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang >> >> Sent: Thursday, March 8, 2018 6:57 PM >> >> To: Xing, Beilei ; Dai, Wei >> >> ; Zhang, Helin ; Lu, >> >> Wenzhuo >> >> Cc: dev@dpdk.org; Tonghao Zhang >> >> Subject: Re: [dpdk-dev] [PATCH v3 0/5] ixgbe: fix bugs or just improve. >> >> >> >> ping .... >> >> >> >> On Mon, Feb 5, 2018 at 8:51 AM, wrote: >> >> > From: Tonghao Zhang >> >> > >> >> > The patches in the patchset have no dependency. But all of them is >> >> > about ixgbe or ixgbevf. The patch 1 and 2 add the itr configuration >> >> > for ixgbe and ixgbevf, the user and developer can configure it for >> >> > their platform. Other patches refine the ixgbe or ixgbevf. >> >> > >> >> > v2 --> v3: >> >> > remove the patch: http://dpdk.org/dev/patchwork/patch/33698 >> >> > >> >> > Tonghao Zhang (5): >> >> > net/ixgbevf: set the inter-interrupt interval for EITR. >> >> > net/ixgbe: set the ITR via configuration. >> >> > net/ixgbe: write disable to ITR counter. >> >> > net/ixgbevf: save IXGBE_VTEIMS to intr->mask for performance. >> >> > net/ixgbe: remove the unnecessary call rte_intr_enable. >> >> > >> >> > config/common_base | 2 + >> >> > drivers/net/ixgbe/ixgbe_ethdev.c | 79 >> >> > +++++++++++++++++++++++----------------- >> >> > drivers/net/ixgbe/ixgbe_ethdev.h | 12 ++++++ >> >> > drivers/net/ixgbe/ixgbe_rxtx.c | 3 +- >> >> > 4 files changed, 61 insertions(+), 35 deletions(-) >> >> > >> >> > -- >> >> > 1.8.3.1 >> >> > >> > >> > Review-by: Qi Zhang >> > >> > Minor typo error in patch1 need to be fixed. >> Should I sent v4 ? > > One more capture on patch 5, > https://dpdk.org/dev/patchwork/patch/36433/ > Remove rte_intr_enable in interrupt handler may not work with legacy interrupt mode which ixgbe supposed to support. Remove it, and thanks for your review. > It's better to so some test on that mode if you want patch 5 be applied, > or we can just remove patch 5 and I'd like to ack patch 1-4, what do you think? > > Regards > Qi > >