From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f68.google.com (mail-oi0-f68.google.com [209.85.218.68]) by dpdk.org (Postfix) with ESMTP id 38A791B1B0 for ; Tue, 9 Jan 2018 16:28:02 +0100 (CET) Received: by mail-oi0-f68.google.com with SMTP id y141so4362335oia.0 for ; Tue, 09 Jan 2018 07:28:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=HjY77OUWHTtJCHHjDp8zesu5Lwe1BgKmhRF8ybONoBY=; b=UsZSkhsWIyBMJZotL3CDQQCFwbCtiduDBcd1pRBvYS3NPBQ53Ae4S5LvRd1WlCiayL hdtJ/Ydd02K1tgk8SHOYAqwndwZB9eyEdHZs41awvmIuy4jVXq3gbAUxLhWdnVGSPyY3 K+u/BA+VCtfkwoaNkfoFOPIy1bWFdb8e8KfCoMT8NPbH1G5ZMC5cPyX3Qh6XLLabb3h2 /p3APcdd7L8/LDSZHuPTBQokiYaxnMOs457nEv8rS9+saWA89H94eGIA76t5jB7uHPy4 LeQYNoTgEgA4zyiTTTbIlxwYQGBKV13hNH2FNJi1k/jtMd0UwGJuykBmpKwCM+yZ4nZf DDZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=HjY77OUWHTtJCHHjDp8zesu5Lwe1BgKmhRF8ybONoBY=; b=O7OkNa8G0oLhJcUkxfvxodGJEzAOzKDwSNcMtLPZzW+SmdTO40pmPywBff/m8PStV/ RZisRq/E/NOWLfQ111DY8qH2ac3cPBEv13rAZbRsNrpHTchoftjnJVBOYBEHgxTTYbg/ IUNzHjzn0T8wTsggwAnKibtWQhFDt5iB5Nd1SiT2iU7U3v33O6Fb5GZwWUMkPl1CgUMY qI2vwVDvSSDefIwWEIVwY6ha96Q6X8wQqjPVUKxbrG8BKibPYpXJakQM9T/8HKwfRmPC tqCqexdjtFx+gN/lVr+SWn3lf98UFSgKchE5xmWxG8VpVcyDwZwy8qxqJ0Fn5Bu1s3oG E/8w== X-Gm-Message-State: AKGB3mJopXa/gPRusHf52fL6qZeNAfysuoTDZoU8Vt68X9jydkf6vqWh HHk/ntdspfxk0Cxjm9nc+jdy20et6pyHC4aQyWG2WQ== X-Google-Smtp-Source: ACJfBotMfQ7TYIHwwYBxlqnVB+nrhOTCxFXOh3J4TFSXxqEQeskG2qjUMXqFUcVoGkbFxx5R08NfctrzPGbbWDVLi14= X-Received: by 10.202.89.139 with SMTP id n133mr8763056oib.109.1515511682198; Tue, 09 Jan 2018 07:28:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.74.151.65 with HTTP; Tue, 9 Jan 2018 07:28:01 -0800 (PST) In-Reply-To: <20180109134037.GO29540@yliu-mob> References: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com> <1515161439-4792-5-git-send-email-xiangxia.m.yue@gmail.com> <20180109131243.GJ29540@yliu-mob> <20180109134037.GO29540@yliu-mob> From: Tonghao Zhang Date: Tue, 9 Jan 2018 23:28:01 +0800 Message-ID: To: Yuanhan Liu Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/5] vhost: add reconnect thread name for client mode. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 15:28:03 -0000 Thanks for your review. On Tue, Jan 9, 2018 at 9:40 PM, Yuanhan Liu wrote: > On Tue, Jan 09, 2018 at 09:12:43PM +0800, Yuanhan Liu wrote: >> On Fri, Jan 05, 2018 at 06:10:39AM -0800, Tonghao Zhang wrote: >> > This patch adds the name for vhost-user reconnect thread. >> > It can help us to know whether the thread is running. >> > >> > Signed-off-by: Tonghao Zhang >> > --- >> > lib/librte_vhost/socket.c | 8 ++++++++ >> > 1 file changed, 8 insertions(+) >> > >> > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c >> > index d44a0f1..c2e34e0 100644 >> > --- a/lib/librte_vhost/socket.c >> > +++ b/lib/librte_vhost/socket.c >> > @@ -433,6 +433,7 @@ struct vhost_user_reconnect_list { >> > vhost_user_reconnect_init(void) >> > { >> > int ret; >> > + char thread_name[RTE_MAX_THREAD_NAME_LEN]; >> > >> > ret = pthread_mutex_init(&reconn_list.mutex, NULL); >> > if (ret < 0) { >> > @@ -449,6 +450,13 @@ struct vhost_user_reconnect_list { >> > RTE_LOG(ERR, VHOST_CONFIG, >> > "failed to destroy reconnect mutex"); >> > } >> > + } else { >> > + snprintf(thread_name, RTE_MAX_THREAD_NAME_LEN, >> > + "vhost-reconn"); >> > + >> > + if (rte_thread_setname(reconn_tid, thread_name)) >> > + RTE_LOG(DEBUG, VHOST_CONFIG, >> > + "Failed to set thread name for vhost-user reconnect"); >> >> Applied to dpdk-next-virtio, with the intendation fixed. > > Note that I have just applied this patch only. The rest of this patchset > belongs to the ixgbe PMD driver, which need another maintainer for review. > > That also means, it's better if you could send them sperately next time > when they are not related. More specifically, in this case, one patch > for vhost-user, another patchset for all the rest ixgbe changes. > > --yliu