From: "Rafał Kozik" <rk@semihalf.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, "Marcin Wojtas" <mw@semihalf.com>,
"Michał Krawczyk" <mk@semihalf.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Schmeilin, Evgeny" <evgenys@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Chauskin, Igor" <igorch@amazon.com>,
stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/ena: fix out of order completion
Date: Wed, 21 Nov 2018 17:14:34 +0100 [thread overview]
Message-ID: <CAMG3L49ZHzM_+MTL6W750fn91F9bE0rrGDZqRHPSPfD158vHgQ@mail.gmail.com> (raw)
In-Reply-To: <fbb37c0e-1985-44c7-5dde-3300f527b913@intel.com>
Hello Ferruh,
this patch fix issue in Rx path which could have caused receive of
wrong packets.
If it is possible, I would be very grateful if this patch could be
applied to v18.11.
Best regards,
Rafal
śr., 21 lis 2018 o 16:16 Ferruh Yigit <ferruh.yigit@intel.com> napisał(a):
>
> On 11/21/2018 8:21 AM, Rafal Kozik wrote:
> > rx_buffer_info should be refill not linearly, but out of order.
> > IDs should be taken from empty_rx_reqs array.
> >
> > rx_refill_buffer is introduced to temporary storage
> > bulk of mbufs taken from pool.
> >
> > In case of error unused mbufs are put back to pool.
> >
> > Fixes: c2034976673d ("net/ena: add Rx out of order completion")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Rafal Kozik <rk@semihalf.com>
> > Acked-by: Michal Krawczyk <mk@semihalf.com>
>
> Hi Rafal,
>
> This patch sent after rc4, I suggest pushing this out to next release, any
> objection? Is this really a critical patch to get in at this stage?
next prev parent reply other threads:[~2018-11-21 16:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-20 15:31 [dpdk-dev] [PATCH] " Rafal Kozik
2018-11-20 16:26 ` [dpdk-dev] [PATCH v2] " Rafal Kozik
2018-11-21 8:21 ` [dpdk-dev] [PATCH v3] " Rafal Kozik
2018-11-21 15:16 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2018-11-21 16:14 ` Rafał Kozik [this message]
2018-11-22 8:48 ` Ferruh Yigit
2018-11-22 9:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMG3L49ZHzM_+MTL6W750fn91F9bE0rrGDZqRHPSPfD158vHgQ@mail.gmail.com \
--to=rk@semihalf.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=ferruh.yigit@intel.com \
--cc=gtzalik@amazon.com \
--cc=igorch@amazon.com \
--cc=matua@amazon.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).