From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f193.google.com (mail-qt0-f193.google.com [209.85.216.193]) by dpdk.org (Postfix) with ESMTP id C3006FA3A for ; Fri, 25 Nov 2016 20:38:28 +0100 (CET) Received: by mail-qt0-f193.google.com with SMTP id n34so5018048qtb.3 for ; Fri, 25 Nov 2016 11:38:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=e5bLl34fZA3BwGULPiJqQ+vSaLxe7IwmuKpfQR/2sCY=; b=ltGFS8hTaMfsadqm2nMq5jMFnJYfFIToUETF8nAvcDLE/t+ppLLeLoMyBn+p3hvu2F 02WWacL8QyQANEkOzw0+hy47EBc3o3Y9t9XNa3UYFRJ/msaSpJNlBVgUlxV+9XoUg1Hl o5y46fv75GP5YzWm2lcIgxvjcCFbFt83OekPtv5ia913Y8tOxQqMHWWnP1u8QHavTBc2 68pKNKMQm4joysxw1qDagpxcSl/F3lS23iIh/q/aN+Atl3tyB0QZp9IJLr01I6bR+siJ KTSLgTTXoMHeNgbknViHrFq/rgeCZpXpjwYmjlQDKnSl9mClnKlLaYaU2miz8VMZ0MYx 68Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=e5bLl34fZA3BwGULPiJqQ+vSaLxe7IwmuKpfQR/2sCY=; b=jrQJU+JbBKvvojxourjfzQpPVPxZk1gn/dVlVEnSEOKEGOgzDUiwWbPibxFswvzVj9 x/t+7DvTO+W5iKRNVtjVDSF49Af2qRE5PsxTtRzPw8yXHEHBWNfaUIRRhaljlyY9mYa3 vzskS1oetoX92e+O9ho4Eiw6AhfQdjylLaNLV+mE+x2y/WTHZfGDMtYHidVZxV0AfSot xt/qMvq6gvASMRn5Z6B8EA4BgLjFT5Xcji2VYHlzEPHetQbVnGptl6yMp98DGJSqwxnj qFdUlbMMGIFLEo0d9mdhvIQJTzZin1Zquveer8GlbuxNmqLZtSN9MrrhGTCjn23BqDfQ GjEQ== X-Gm-Message-State: AKaTC02I4ycP4XWUhL/1QkqTO8DDpSZYiiiso7TtTQxbrz/7znASiC1K9JaTmUWg5UlbmYNn7LAm18Vtg62z3Q== X-Received: by 10.200.37.76 with SMTP id 12mr8231483qtn.129.1480102708286; Fri, 25 Nov 2016 11:38:28 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.85.244 with HTTP; Fri, 25 Nov 2016 11:38:07 -0800 (PST) In-Reply-To: References: <1474423220-10207-1-git-send-email-keith.wiles@intel.com> <1476396234-44694-1-git-send-email-keith.wiles@intel.com> From: Aws Ismail Date: Fri, 25 Nov 2016 14:38:07 -0500 Message-ID: To: Ferruh Yigit Cc: Keith Wiles , DPDK , pmatilai@redhat.com, yuanhan.liu@linux.intel.com Content-Type: text/plain; charset=UTF-8 Subject: Re: [dpdk-dev] [PATCH v9] drivers/net:new PMD using tun/tap host interface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Nov 2016 19:38:29 -0000 Keith, This won't build when integrated with v16.11. The register macro prefix has been renamed. a v10 is needed. diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 7f303db..297d4b6 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -752,5 +752,6 @@ static struct rte_vdev_driver pmd_tap_drv = { .remove = rte_pmd_tap_remove, }; -DRIVER_REGISTER_VDEV(net_tap, pmd_tap_drv); -DRIVER_REGISTER_PARAM_STRING(net_tap, "iface=,speed=N"); +RTE_PMD_REGISTER_VDEV(net_tap, pmd_tap_drv); +RTE_PMD_REGISTER_ALIAS(net_tap, eth_tap); +RTE_PMD_REGISTER_PARAM_STRING(net_tap, "iface=,speed=N"); On Mon, Nov 21, 2016 at 7:56 AM, Ferruh Yigit wrote: > On 10/13/2016 11:03 PM, Keith Wiles wrote: >> The rte_eth_tap.c PMD creates a device using TUN/TAP interfaces >> on the local host. The PMD allows for DPDK and the host to >> communicate using a raw device interface on the host and in >> the DPDK application. The device created is a Tap device with >> a L2 packet header. >> >> v9 - Fix up the docs to use correct syntax >> v8 - Fix issue with tap_tx_queue_setup() not return zero on success. >> v7 - Reword the comment in common_base and fix the data->name issue >> v6 - fixed the checkpatch issues >> v5 - merge in changes from list review see related emails >> fixed many minor edits >> v4 - merge with latest driver changes >> v3 - fix includes by removing ifdef for other type besides Linux >> Fix the copyright notice in the Makefile >> v2 - merge all of the patches into one patch >> Fix a typo on naming the tap device >> Update the maintainers list >> >> Signed-off-by: Keith Wiles >> --- > > Just a reminder, this is a new PMD and waiting for community review.