From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A3BA41C66; Sat, 11 Feb 2023 04:07:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAF5740E50; Sat, 11 Feb 2023 04:07:44 +0100 (CET) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id 7B22B40E0F for ; Sat, 11 Feb 2023 04:07:43 +0100 (CET) Received: by mail-ej1-f53.google.com with SMTP id dr8so20269572ejc.12 for ; Fri, 10 Feb 2023 19:07:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atomicrules-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=LmiF8sPMmEa6zZAfowj0VjMapADgmpCiY3J4qByYrX8=; b=Keg3i0CHElsHj60OXKSLTn9TZkp8kLjwa3bIhEXpvtxCRRBSTWQUawNN6cLlqzJ7qA 2m+mU4l9cBI0TIlEDEZ4brRIJLrexkCeF92r+XUFQG9Sg/n8Do47ENu7pNVE40tOOBxh oum+R3vo7No01DZxoQy6AqFW9FBHd0LT2ICP0WU+c8ADhLBjmlhMcBucVtVDwE46KYOf BTW/NLzZ6PBK+wnb/2ArzKB69nu65Yiaqud/xpnLBd0Zu5nUA/zoS8HvlUFuUbfwRBzZ 5Jb5uQMfwYPqnAjDPYS3g1dIOjwHtto3G8rW0fh3/hC/O1ktXi3YzGc26kFXWHa6Znx7 /MrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LmiF8sPMmEa6zZAfowj0VjMapADgmpCiY3J4qByYrX8=; b=XnsO6ClzgIiJYv8Cgs9/Gh65qz+4/mUToaIuaZ8lZBZkxqRWKq2oBQn/PIjoZdLwFd fse85Pibl0snfAzP0dlDIfWhZD0xK4W8wxrf0/8wrKFVneUnCn0lwm1ran53muIet1VH 7yyw3d/4A17WChBvMEgd+VCWDouAwwwh5VpbLyNUfsO4Jd8YUGI2WGXQblY34p8HHdav roHfsVnuAy/vjvDnc73xAM8cDoH6CG2CyN5VrUq6f0uG715cySbcd6FcuskFCiwcDo7Q sCl1wmaWyOayu/hVFsvT7jMW5O/KYGaXxqPUkOFibBvPc8bz+hMttumNrhWlSrYgfN6B BDfA== X-Gm-Message-State: AO0yUKXMfa6TsIbAXeWo/1wOmDWp8OxYArsyWBQKQKagzooNkz6brakQ KaW8KuUHhVPQIPnaV4Y/bAwkcBQtMlVqPnFG/HNoDw== X-Google-Smtp-Source: AK7set+e10cZBhIo8c5zGFkT7F0AlsYppPsdeXMpnFxDScCaiFy/H7RlmqEfAVMKIchAjiAMVQQRjp3VFFEW7TkhjJU= X-Received: by 2002:a17:906:84b:b0:888:6294:a1fc with SMTP id f11-20020a170906084b00b008886294a1fcmr2008032ejd.7.1676084863085; Fri, 10 Feb 2023 19:07:43 -0800 (PST) MIME-Version: 1.0 References: <20230210193837.2604100-1-shepard.siegel@atomicrules.com> <20230211012659.2611391-1-shepard.siegel@atomicrules.com> <20230211012659.2611391-2-shepard.siegel@atomicrules.com> <833c253a-8595-14c0-a07e-1e027a08302b@amd.com> In-Reply-To: <833c253a-8595-14c0-a07e-1e027a08302b@amd.com> From: Shepard Siegel Date: Fri, 10 Feb 2023 22:07:31 -0500 Message-ID: Subject: Re: [PATCH v3 2/2] doc: add Arkville FX2 PCIe device description To: Ferruh Yigit Cc: ed.czeck@atomicrules.com, dev@dpdk.org, John Miller Content-Type: multipart/alternative; boundary="000000000000e0c3a305f463ea43" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000e0c3a305f463ea43 Content-Type: text/plain; charset="UTF-8" Hi Ferruh, I don't think the submission system will allow your request of a single patch with both a code change and document change since they are in different directories. I must say I'm confused by your request. In the current v3 which is not your preference, we split up the new device into the 0001 and the doc on the new device in the 0002. Your current ask of "Can you please add new device related documentation to patch that adds new device?" was what we did back on v2. Guessing you don't like the mention of any other devices in the FX2 addition? It feels crazy to have to have three different patches to essentially add a one-liner to our PCIe device alowlist! Am I making this way more complicated than it needs to be? We will produce the sequence of three patches in the morning. Would a cover letter help explain when we are doing with this patch? If there are elements that are not clear, let me know and we will work to clarify it. Thank you for your efforts in this and countless other DPDK pushes! best, Shep On Fri, Feb 10, 2023 at 9:13 PM Ferruh Yigit wrote: > On 2/11/2023 1:26 AM, Shepard Siegel wrote: > > Update net/ark guide for clarity. > > Include list of FX0, FX1 and FX2 PCIe devices. > > > > Signed-off-by: Shepard Siegel > > --- > > doc/guides/nics/ark.rst | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > > index ba00f14e80..39cd75064d 100644 > > --- a/doc/guides/nics/ark.rst > > +++ b/doc/guides/nics/ark.rst > > @@ -52,6 +52,10 @@ board. While specific capabilities such as number of > physical > > hardware queue-pairs are negotiated; the driver is designed to > > remain constant over a broad and extendable feature set. > > > > +* FPGA Vendors Supported: AMD/Xilinx and Intel > > +* Number of RX/TX Queue-Pairs: up to 128 > > +* PCIe Endpoint Technology: Gen3, Gen4, Gen5 > > + > > Intentionally, Arkville by itself DOES NOT provide common NIC > > capabilities such as offload or receive-side scaling (RSS). > > These capabilities would be viewed as a gate-level "tax" on > > @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe > instances including: > > * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function] > > * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for Agilex > R-Tile] > > * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device] > > +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agilex] > > Can you please add new device related documentation to patch that adds > new device? > At least above line is related to it, but if any other updates in this > document is related to this new device that part also can go to other > patch. > > Or if it make more sense you can first introduce the document update > patch for old devices, and later add new device and new device related > documentation, like: > > First patch adds: > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4) > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5) > > Second patch adds new device and appends following: > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only) > > > > + > > +Arkville RTL Core Configurations > > +------------------------------------- > > + > > +Arkville's RTL core may be configured by the user for three different > > +datapath widths to balance throughput against FPGA logic area. The ARK > PMD > > +has introspection on the RTL core configuration and acts accordingly. > > +All three configurations present identical RTL user-facing AXI stream > > +interfaces for both AMD/Xilinx and Intel FPGAs. > > + > > +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4) > > +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5) > > +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only) > > > > DPDK and Arkville Firmware Versioning > > ------------------------------------- > > @@ -334,6 +352,8 @@ Supported Features > > ------------------ > > > > * Dynamic ARK PMD extensions > > +* Dynamic per-queue MBUF (re)sizing up to 32KB > > +* SR-IOV, VF-based queue-segregation > > * Multiple receive and transmit queues > > * Jumbo frames up to 9K > > * Hardware Statistics > > --000000000000e0c3a305f463ea43 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi Ferruh,

I don't think the submis= sion system will allow your request of a single patch with both a code chan= ge and document change since=C2=A0they are in different directories. I must= say I'm confused by your request. In the current v3 which is not your = preference, we split up the new device into the 0001 and the doc on the new= device in the 0002.

Your current ask of "Can= you please add new device related documentation to patch that adds new dev= ice?" was what we did back on v2. Guessing you don't like the ment= ion of any other devices in the FX2 addition?

It f= eels crazy to have to have three different=C2=A0patches to essentially add = a one-liner to our PCIe device alowlist! Am I making=C2=A0this way more com= plicated than it needs to be?

We will produce the = sequence of three patches in the morning.=C2=A0

Wo= uld a cover letter help=C2=A0explain=C2=A0when we are doing with this patch= ?
If there are elements that are not clear, let me know and we wi= ll work to clarify it.

Thank you for your efforts= =C2=A0in this and countless other DPDK pushes!

bes= t, Shep




On Fri, Feb 10, 2= 023 at 9:13 PM Ferruh Yigit <fer= ruh.yigit@amd.com> wrote:
On 2/11/2023 1:26 AM, Shepard Siegel wrote:
> Update net/ark guide for clarity.
> Include list of FX0, FX1 and FX2 PCIe devices.
>
> Signed-off-by: Shepard Siegel <shepard.siegel@atomicrules.com>
> ---
>=C2=A0 doc/guides/nics/ark.rst | 20 ++++++++++++++++++++
>=C2=A0 1 file changed, 20 insertions(+)
>
> diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst
> index ba00f14e80..39cd75064d 100644
> --- a/doc/guides/nics/ark.rst
> +++ b/doc/guides/nics/ark.rst
> @@ -52,6 +52,10 @@ board. While specific capabilities such as number o= f physical
>=C2=A0 hardware queue-pairs are negotiated; the driver is designed to >=C2=A0 remain constant over a broad and extendable feature set.
>=C2=A0
> +* FPGA Vendors Supported: AMD/Xilinx and Intel
> +* Number of RX/TX Queue-Pairs: up to 128
> +* PCIe Endpoint Technology: Gen3, Gen4, Gen5
> +
>=C2=A0 Intentionally, Arkville by itself DOES NOT provide common NIC >=C2=A0 capabilities such as offload or receive-side scaling (RSS).
>=C2=A0 These capabilities would be viewed as a gate-level "tax&quo= t; on
> @@ -302,6 +306,20 @@ ARK PMD supports the following Arkville RTL PCIe = instances including:
>=C2=A0 * ``1d6c:101c`` - AR-ARK-SRIOV-VF [Arkville Virtual Function] >=C2=A0 * ``1d6c:101e`` - AR-ARKA-FX1 [Arkville 64B DPDK Data Mover for = Agilex R-Tile]
>=C2=A0 * ``1d6c:101f`` - AR-TK242 [2x100GbE Packet Capture Device]
> +* ``1d6c:1022`` - AR-ARKA-FX2 [Arkville 128B DPDK Data Mover for Agil= ex]

Can you please add new device related documentation to patch that adds
new device?
At least above line is related to it, but if any other updates in this
document is related to this new device that part also can go to other patch= .

Or if it make more sense you can first introduce the document update
patch for old devices, and later add new device and new device related
documentation, like:

First patch adds:
=C2=A0 +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
=C2=A0 +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)

Second patch adds new device and appends following:
=C2=A0 +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)


> +
> +Arkville RTL Core Configurations
> +-------------------------------------
> +
> +Arkville's RTL core may be configured by the user for three diffe= rent
> +datapath widths to balance throughput against FPGA logic area. The AR= K PMD
> +has introspection on the RTL core configuration and acts accordingly.=
> +All three configurations present identical RTL user-facing AXI stream=
> +interfaces for both AMD/Xilinx and Intel FPGAs.
> +
> +* ARK-FX0 - 256-bit 32B datapath (PCIe Gen3, Gen4)
> +* ARK-FX1 - 512-bit 64B datapath (PCIe Gen3, Gen4, Gen5)
> +* ARK-FX2 - 1024-bit 128B datapath (PCIe Gen5x16 Only)
>=C2=A0
>=C2=A0 DPDK and Arkville Firmware Versioning
>=C2=A0 -------------------------------------
> @@ -334,6 +352,8 @@ Supported Features
>=C2=A0 ------------------
>=C2=A0
>=C2=A0 * Dynamic ARK PMD extensions
> +* Dynamic per-queue MBUF (re)sizing up to 32KB
> +* SR-IOV, VF-based queue-segregation
>=C2=A0 * Multiple receive and transmit queues
>=C2=A0 * Jumbo frames up to 9K
>=C2=A0 * Hardware Statistics

--000000000000e0c3a305f463ea43--