From: 王志宏 <wangzhihong.wzh@bytedance.com>
To: "Singh, Aman Deep" <aman.deep.singh@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, xiaoyun.li@intel.com
Subject: Re: [dpdk-dev] [External] Re: [PATCH v2] app/testpmd: flowgen support ip and udp fields
Date: Tue, 10 Aug 2021 15:30:33 +0800 [thread overview]
Message-ID: <CAMne5nCwSXPcCxztNkh-O2+Os_HzWbSMC91=+XcnBrXuiT44XQ@mail.gmail.com> (raw)
In-Reply-To: <c6dfe07b-f576-95cb-f52e-539334f42e7e@intel.com>
Hi Aman,
On Mon, Aug 9, 2021 at 8:21 PM Singh, Aman Deep
<aman.deep.singh@intel.com> wrote:
>
> Hi Wang,
>
> On 8/9/2021 12:22 PM, Zhihong Wang wrote:
>
> This patch aims to:
> 1. Add flexibility by supporting IP & UDP src/dst fields
> 2. Improve multi-core performance by using per-core vars
>
> v2: fix assigning ip header cksum
>
> Signed-off-by: Zhihong Wang <wangzhihong.wzh@bytedance.com>
> ---
> <snip>
>
> From defination of flowgen as per the documentation-
>
> flowgen: Multi-flow generation mode. Originates a number of flows (with varying destination IP addresses), and terminate receive traffic.
>
> So changing the src IP address may not fit the defination of a source generating real traffic.
>
> I would like to check this part further.
Thanks for the review. The purpose of introducing them is to emulate
pkt generators behaviors.
Do you think keeping cfg_n_ip_src & cfg_n_udp_src while setting them =
1 by default makes sense? Or maybe update the documentation?
next prev parent reply other threads:[~2021-08-10 7:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-09 6:25 [dpdk-dev] [PATCH] " Zhihong Wang
2021-08-09 6:52 ` [dpdk-dev] [PATCH v2] " Zhihong Wang
2021-08-09 12:21 ` Singh, Aman Deep
2021-08-10 7:30 ` 王志宏 [this message]
2021-08-09 15:18 ` Ferruh Yigit
2021-08-10 7:57 ` [dpdk-dev] [External] " 王志宏
2021-08-10 9:12 ` Ferruh Yigit
2021-08-11 2:48 ` 王志宏
2021-08-11 10:31 ` Ferruh Yigit
2021-08-12 9:32 ` 王志宏
2021-08-12 11:11 ` [dpdk-dev] [PATCH v3 0/4] app/testpmd: flowgen fixes and improvements Zhihong Wang
2021-08-12 11:11 ` [dpdk-dev] [PATCH v3 1/4] app/testpmd: fix tx retry in flowgen Zhihong Wang
2021-08-12 11:11 ` [dpdk-dev] [PATCH v3 2/4] app/testpmd: use rte_ipv4_cksum " Zhihong Wang
2021-08-12 11:11 ` [dpdk-dev] [PATCH v3 3/4] app/testpmd: record rx_burst and fwd_dropped " Zhihong Wang
2021-08-12 11:11 ` [dpdk-dev] [PATCH v3 4/4] app/testpmd: use per-core variable " Zhihong Wang
2021-08-12 13:18 ` [dpdk-dev] [PATCH v4 0/4] app/testpmd: flowgen fixes and improvements Zhihong Wang
2021-08-12 13:18 ` [dpdk-dev] [PATCH v4 1/4] app/testpmd: fix tx retry in flowgen Zhihong Wang
2021-08-13 1:33 ` Li, Xiaoyun
2021-08-13 2:27 ` [dpdk-dev] [External] " 王志宏
2021-08-12 13:18 ` [dpdk-dev] [PATCH v4 2/4] app/testpmd: use rte_ipv4_cksum " Zhihong Wang
2021-08-13 1:37 ` Li, Xiaoyun
2021-08-12 13:19 ` [dpdk-dev] [PATCH v4 3/4] app/testpmd: record rx_burst and fwd_dropped " Zhihong Wang
2021-08-13 1:44 ` Li, Xiaoyun
2021-08-12 13:19 ` [dpdk-dev] [PATCH v4 4/4] app/testpmd: use per-core variable " Zhihong Wang
2021-08-13 1:56 ` Li, Xiaoyun
2021-08-13 2:35 ` [dpdk-dev] [External] " 王志宏
2021-08-13 8:05 ` [dpdk-dev] [PATCH v5 0/4] app/testpmd: flowgen fixes and improvements Zhihong Wang
2021-08-13 8:05 ` [dpdk-dev] [PATCH v5 1/4] app/testpmd: fix tx retry in flowgen Zhihong Wang
2021-08-13 8:05 ` [dpdk-dev] [PATCH v5 2/4] app/testpmd: use rte_ipv4_cksum " Zhihong Wang
2021-08-13 8:05 ` [dpdk-dev] [PATCH v5 3/4] app/testpmd: record rx_burst and fwd_dropped " Zhihong Wang
2021-08-13 8:05 ` [dpdk-dev] [PATCH v5 4/4] app/testpmd: use per-core variable " Zhihong Wang
2021-08-24 17:21 ` [dpdk-dev] [PATCH v5 0/4] app/testpmd: flowgen fixes and improvements Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMne5nCwSXPcCxztNkh-O2+Os_HzWbSMC91=+XcnBrXuiT44XQ@mail.gmail.com' \
--to=wangzhihong.wzh@bytedance.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).