From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 9C4941B4D2 for ; Fri, 5 Apr 2019 15:10:29 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id b6so4967345iog.0 for ; Fri, 05 Apr 2019 06:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKLAJZUxuJkbpbNypYgnMPaVNToviCD9WX+0yhxZEiY=; b=E09QLF90e9FxBozn3YuUA206bjb6gpAu6iqDzKL61+iw1SaMWB1o52pCPfXf9+KzoK 90teGBHlQ8i9lUHr5qjb8aiBTyE2GnWtU00Wmaa/dIos6uGp9eMrhhk+GBbDAZb+4f0B k223V8JwdzA2QnOVbhRHWn6Yg5LhK67uoCVYOa2jWHdtbPcLC68aMONt+odls9jIkGlP Ej0TPk9s3Z9li3nX57wMZjSujUP9DSZOF2Kxb7ts3e6Lz/h9alSER9x0AdKPW6IFUu5W FN+0QDAxD4epAZ4Rvq0w2ZnJbCM5lfaynmy41UrBUux024/TPtTkk0Ykrcmh6+OPwF7G uw5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKLAJZUxuJkbpbNypYgnMPaVNToviCD9WX+0yhxZEiY=; b=Xz/HTYwj3uHFBGBfVWoyypUVcaUPNciWhQdt0yVu1AnkusOOZyaIs3Ldud1egsoxyc 4mCN/r7XaDTE0tW/J3mcpn5o9BZ9JLAqJUP5FBtg9gt6ZidC73gpwydLEBBvs7coVFHE optXKHx1cSY20VVjnjSeZqlO0POz20R/p3MhsWpylhKAV/Kou66F9XJ8Go16G9zv3lTp BbhmIeENb/C5Ko6K57feZHP786Z7FZuhzd5mlE3607/veV+Qo45LatneYjHbFocS7Pk8 PCja7Kq+QAbDqXSQjY7/pfZ9ywkCkFl5c2MV2c2LA4K5ve5IlBpp7Y2KE83zUgaqWDeA DkLg== X-Gm-Message-State: APjAAAVgVfBUhPFNTCipiiYApDkMHvIR5EmvR06jTxntXYjy1Iuz8zkN bqH7RaV0gTZlNT3Vgk4eqxToNjZi1pPNEcaVjOE= X-Google-Smtp-Source: APXvYqwLFVgCEqYfZitpijqNLSG42cYjjxPhLgZewh2tLj83/Jm2qFf6mLr3Tg4NShA9EsIxIPP497pWJzcaOtJjqQI= X-Received: by 2002:a5d:9159:: with SMTP id y25mr8887630ioq.146.1554469829010; Fri, 05 Apr 2019 06:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20190219064840.12046-1-ndabilpuram@marvell.com> <20190405120403.5446-1-nithind1988@gmail.com> <55d9253c-66bb-9547-8145-c47afe03de30@intel.com> In-Reply-To: <55d9253c-66bb-9547-8145-c47afe03de30@intel.com> From: Nithin Kumar D Date: Fri, 5 Apr 2019 18:40:17 +0530 Message-ID: To: Ferruh Yigit Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , dev@dpdk.org, Wang Xiao W , Nithin Dabilpuram Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/2] app/testpmd: fix Tx VLAN and QinQ dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Apr 2019 13:10:29 -0000 Hi Ferruh, Yes, our mail server had some issue and was inserting CRLF chars. So I sent the same v3 as v4 from gmail. Thanks Nithin On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit wrote: > On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > > > Tx VLAN & QinQ insert enable need not depend on > > Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN > > insert enable, error check is now to see if QinQ was enabled > > but only single VLAN id is set. > > > > Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx > VLAN") > > Cc: xiao.w.wang@intel.com > > > > Signed-off-by: Nithin Dabilpuram > > Acked-by: Bernard Iremonger > > --- > > v4: > > * Resend v3 from different mailserver to avoid > > CRLF > > v3: > > * Add back error check in tx_vlan_set() to check if QinQ is > > already enabled. Also fix headline. > > v2: > > * Split change into two seperate patches as suggested. > > > > Hi Nithin, > > I just merged the v3 and about to send the mail :) > > What is different in v4? avoid CRLF? > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9381FA0679 for ; Fri, 5 Apr 2019 15:10:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EE081B4D7; Fri, 5 Apr 2019 15:10:30 +0200 (CEST) Received: from mail-io1-f65.google.com (mail-io1-f65.google.com [209.85.166.65]) by dpdk.org (Postfix) with ESMTP id 9C4941B4D2 for ; Fri, 5 Apr 2019 15:10:29 +0200 (CEST) Received: by mail-io1-f65.google.com with SMTP id b6so4967345iog.0 for ; Fri, 05 Apr 2019 06:10:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKLAJZUxuJkbpbNypYgnMPaVNToviCD9WX+0yhxZEiY=; b=E09QLF90e9FxBozn3YuUA206bjb6gpAu6iqDzKL61+iw1SaMWB1o52pCPfXf9+KzoK 90teGBHlQ8i9lUHr5qjb8aiBTyE2GnWtU00Wmaa/dIos6uGp9eMrhhk+GBbDAZb+4f0B k223V8JwdzA2QnOVbhRHWn6Yg5LhK67uoCVYOa2jWHdtbPcLC68aMONt+odls9jIkGlP Ej0TPk9s3Z9li3nX57wMZjSujUP9DSZOF2Kxb7ts3e6Lz/h9alSER9x0AdKPW6IFUu5W FN+0QDAxD4epAZ4Rvq0w2ZnJbCM5lfaynmy41UrBUux024/TPtTkk0Ykrcmh6+OPwF7G uw5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKLAJZUxuJkbpbNypYgnMPaVNToviCD9WX+0yhxZEiY=; b=Xz/HTYwj3uHFBGBfVWoyypUVcaUPNciWhQdt0yVu1AnkusOOZyaIs3Ldud1egsoxyc 4mCN/r7XaDTE0tW/J3mcpn5o9BZ9JLAqJUP5FBtg9gt6ZidC73gpwydLEBBvs7coVFHE optXKHx1cSY20VVjnjSeZqlO0POz20R/p3MhsWpylhKAV/Kou66F9XJ8Go16G9zv3lTp BbhmIeENb/C5Ko6K57feZHP786Z7FZuhzd5mlE3607/veV+Qo45LatneYjHbFocS7Pk8 PCja7Kq+QAbDqXSQjY7/pfZ9ywkCkFl5c2MV2c2LA4K5ve5IlBpp7Y2KE83zUgaqWDeA DkLg== X-Gm-Message-State: APjAAAVgVfBUhPFNTCipiiYApDkMHvIR5EmvR06jTxntXYjy1Iuz8zkN bqH7RaV0gTZlNT3Vgk4eqxToNjZi1pPNEcaVjOE= X-Google-Smtp-Source: APXvYqwLFVgCEqYfZitpijqNLSG42cYjjxPhLgZewh2tLj83/Jm2qFf6mLr3Tg4NShA9EsIxIPP497pWJzcaOtJjqQI= X-Received: by 2002:a5d:9159:: with SMTP id y25mr8887630ioq.146.1554469829010; Fri, 05 Apr 2019 06:10:29 -0700 (PDT) MIME-Version: 1.0 References: <20190219064840.12046-1-ndabilpuram@marvell.com> <20190405120403.5446-1-nithind1988@gmail.com> <55d9253c-66bb-9547-8145-c47afe03de30@intel.com> In-Reply-To: <55d9253c-66bb-9547-8145-c47afe03de30@intel.com> From: Nithin Kumar D Date: Fri, 5 Apr 2019 18:40:17 +0530 Message-ID: To: Ferruh Yigit Cc: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , dev@dpdk.org, Wang Xiao W , Nithin Dabilpuram Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/2] app/testpmd: fix Tx VLAN and QinQ dependency X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190405131017.QyL-FYlB6ax-HTPSCYxNgDc6zewzvOuXS24m1H_Dayg@z> Hi Ferruh, Yes, our mail server had some issue and was inserting CRLF chars. So I sent the same v3 as v4 from gmail. Thanks Nithin On Fri, Apr 5, 2019 at 5:36 PM Ferruh Yigit wrote: > On 4/5/2019 1:04 PM, Nithin Dabilpuram wrote: > > From: Nithin Dabilpuram > > > > Tx VLAN & QinQ insert enable need not depend on > > Rx VLAN offload ETH_VLAN_EXTEND_OFFLOAD. For Tx VLAN > > insert enable, error check is now to see if QinQ was enabled > > but only single VLAN id is set. > > > > Fixes: 6a34f91690d0 ("app/testpmd: fix error message when setting Tx > VLAN") > > Cc: xiao.w.wang@intel.com > > > > Signed-off-by: Nithin Dabilpuram > > Acked-by: Bernard Iremonger > > --- > > v4: > > * Resend v3 from different mailserver to avoid > > CRLF > > v3: > > * Add back error check in tx_vlan_set() to check if QinQ is > > already enabled. Also fix headline. > > v2: > > * Split change into two seperate patches as suggested. > > > > Hi Nithin, > > I just merged the v3 and about to send the mail :) > > What is different in v4? avoid CRLF? > >