From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5283742BF1; Mon, 5 Jun 2023 14:51:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 411884021F; Mon, 5 Jun 2023 14:51:50 +0200 (CEST) Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by mails.dpdk.org (Postfix) with ESMTP id 2B0C84003C for ; Mon, 5 Jun 2023 14:51:49 +0200 (CEST) Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-3f7f864525fso52994201cf.1 for ; Mon, 05 Jun 2023 05:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685969508; x=1688561508; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=/pbxkIzgybl3GEzJILs0TbAwI2pDjXmlwmXBf9qQPgo=; b=AqUx31WWOhbIavlc5zIURQ1nVhUcS6jwZBEoeuuqvqqyzxZGNXEC94yZdbIbl6vpK5 hMzY6XU3EjTEJQiMj4F+uk4V+9gFjNq1HC94ZKnThA60oBnlyXLWdd1JWdWL/RLKcM9r fCPpSNGueX7rxP1nUZgK0vfxeEE3X8jzRchP2Nc/kqmEC10uAYE1yD/Vv1N4GnTs0AFI rmepPS0/fkT+Dc84lmHJRHanG6L0eyBiGZeg37Js8wSobhszDFA1h5rDp4Y6irAbSCz/ OosH9MF3/yz7OCpVDLnnZiRxMwLzo5GWHbnKmVzF09V1VvlEihj2IlTuFM/2fhZGQOZv Ub3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685969508; x=1688561508; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/pbxkIzgybl3GEzJILs0TbAwI2pDjXmlwmXBf9qQPgo=; b=NmgVf6xhj/fuhoOmjxF9b6l+RU7H92nKajRyVpDIKAcRwlgcW01c/uWb0oKkc67cLk zl489D8qjIVyXWmUA4JxyclhQAq4hL1uMz+pey3QSfQE4+OS7Ufbc5uatDrmD6/rAP2C klLjPGQaQkDg4gA0+MpwZNGQCvaFojn3pU5GvEOepuu3vC+alMo6QvOpxAPpMhi7NTwU EG2Q5GutZyobAxoDUDMLNafy+EmTGLjXNVAnfv0pU1zBMx1Hsukuo+dYObHOjk9VCTNL rQu5EPO8wq0O0L+SytRwSrpdVF+FdIVdROiqN6NY+wuY6iftA9Cv/Bp05Q+GahHwU4qX HNIg== X-Gm-Message-State: AC+VfDw8fyV01qq/A4ynYyHdl8lIJIeVq/qoAN67KTllKA8v1/2RmhUb NOEaQzjxGhdXcO+uph1g1UTKOs0UumZhbjgFCck= X-Google-Smtp-Source: ACHHUZ4NpPTwiUVNkVtfW+pf1Z0khHH+f7aLMkssqDEsVI1DaqI+pH8d5svRresxtc7QVZfO8G6beE3BxC5HyieOWFQ= X-Received: by 2002:a05:622a:19a5:b0:3f6:b1e9:843c with SMTP id u37-20020a05622a19a500b003f6b1e9843cmr10056335qtc.44.1685969508556; Mon, 05 Jun 2023 05:51:48 -0700 (PDT) MIME-Version: 1.0 References: <20230425131516.3308612-1-vattunuru@marvell.com> <20230602162216.1868870-1-vattunuru@marvell.com> <20230602162216.1868870-4-vattunuru@marvell.com> In-Reply-To: <20230602162216.1868870-4-vattunuru@marvell.com> From: Nithin Dabilpuram Date: Mon, 5 Jun 2023 18:21:37 +0530 Message-ID: Subject: Re: [PATCH v3 3/3] node/ethdev_rx: remove hardcoded node next details To: Vamsi Attunuru Cc: dev@dpdk.org, thomas@monjalon.net, jerinj@marvell.com, ndabilpuram@marvell.com, zhirun.yan@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Nithin Dabilpuram On Fri, Jun 2, 2023 at 9:52=E2=80=AFPM Vamsi Attunuru wrote: > > For ethdev_rx node, node_next details can be populated > during node cloning time and same gets assigned to > node context structure during node initialization. > > Patch removes overriding node_next details in node > init(). > > Signed-off-by: Vamsi Attunuru > --- > lib/node/ethdev_ctrl.c | 1 + > lib/node/ethdev_rx.c | 3 --- > 2 files changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/node/ethdev_ctrl.c b/lib/node/ethdev_ctrl.c > index 37df0431b8..496f791cee 100644 > --- a/lib/node/ethdev_ctrl.c > +++ b/lib/node/ethdev_ctrl.c > @@ -82,6 +82,7 @@ rte_node_eth_config(struct rte_node_ethdev_config *conf= , uint16_t nb_confs, > memset(elem, 0, sizeof(ethdev_rx_node_elem_t)); > elem->ctx.port_id =3D port_id; > elem->ctx.queue_id =3D j; > + elem->ctx.cls_next =3D ETHDEV_RX_NEXT_PKT_CLS; > elem->nid =3D id; > elem->next =3D rx_node_data->head; > rx_node_data->head =3D elem; > diff --git a/lib/node/ethdev_rx.c b/lib/node/ethdev_rx.c > index a19237b42f..d131034991 100644 > --- a/lib/node/ethdev_rx.c > +++ b/lib/node/ethdev_rx.c > @@ -194,8 +194,6 @@ ethdev_rx_node_init(const struct rte_graph *graph, st= ruct rte_node *node) > > RTE_VERIFY(elem !=3D NULL); > > - ctx->cls_next =3D ETHDEV_RX_NEXT_PKT_CLS; > - > /* Check and setup ptype */ > return ethdev_ptype_setup(ctx->port_id, ctx->queue_id); > } > @@ -215,7 +213,6 @@ static struct rte_node_register ethdev_rx_node_base = =3D { > > .nb_edges =3D ETHDEV_RX_NEXT_MAX, > .next_nodes =3D { > - /* Default pkt classification node */ > [ETHDEV_RX_NEXT_PKT_CLS] =3D "pkt_cls", > [ETHDEV_RX_NEXT_IP4_LOOKUP] =3D "ip4_lookup", > }, > -- > 2.25.1 >