From: Nithin Dabilpuram <nithind1988@gmail.com>
To: Rakesh Kudurumalla <rkudurumalla@marvell.com>
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>,
dev@dpdk.org, jerinj@marvell.com
Subject: Re: [PATCH 1/1] node: remove MAX macro from all nodes
Date: Wed, 27 Sep 2023 10:52:50 +0530 [thread overview]
Message-ID: <CAMuDWKTg00OXmb0Fuqn+zO4ok2WJ4R88Px7ayJAiK1D6ouJKBg@mail.gmail.com> (raw)
In-Reply-To: <20230801084916.1542854-1-rkudurumalla@marvell.com>
Acked-by: Nithin Dabilpuram <ndabilpuram@marvell.com>
On Tue, Aug 1, 2023 at 2:19 PM Rakesh Kudurumalla
<rkudurumalla@marvell.com> wrote:
>
> Removed MAX macro from all graph nodes to extend
> edges to nodes at ease
>
> Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>
> ---
>
> v2: Update changes to TOT and resolve
> dependecy related issues
>
> lib/node/ip4_lookup.c | 2 +-
> lib/node/ip6_lookup.c | 2 +-
> lib/node/rte_node_ip4_api.h | 2 --
> lib/node/rte_node_ip6_api.h | 2 --
> 4 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c
> index 8bce03d7db..72fd760512 100644
> --- a/lib/node/ip4_lookup.c
> +++ b/lib/node/ip4_lookup.c
> @@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node = {
>
> .init = ip4_lookup_node_init,
>
> - .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_MAX,
> + .nb_edges = RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1,
> .next_nodes = {
> [RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] = "ip4_rewrite",
> [RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c
> index 646e466551..6f56eb5ec5 100644
> --- a/lib/node/ip6_lookup.c
> +++ b/lib/node/ip6_lookup.c
> @@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node = {
>
> .init = ip6_lookup_node_init,
>
> - .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> + .nb_edges = RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1,
> .next_nodes = {
> [RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] = "ip6_rewrite",
> [RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] = "pkt_drop",
> diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h
> index 3397da0ae8..0f997761b6 100644
> --- a/lib/node/rte_node_ip4_api.h
> +++ b/lib/node/rte_node_ip4_api.h
> @@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next {
> RTE_NODE_IP4_LOOKUP_NEXT_REWRITE,
> /**< Rewrite node. */
> RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP,
> - /**< Packet drop node. */
> - RTE_NODE_IP4_LOOKUP_NEXT_MAX,
> /**< Number of next nodes of lookup node. */
> };
>
> diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h
> index f3b5a1002a..a538dc2ea7 100644
> --- a/lib/node/rte_node_ip6_api.h
> +++ b/lib/node/rte_node_ip6_api.h
> @@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next {
> /**< Rewrite node. */
> RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP,
> /**< Packet drop node. */
> - RTE_NODE_IP6_LOOKUP_NEXT_MAX,
> - /**< Number of next nodes of lookup node. */
> };
>
> /**
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-09-27 5:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 12:30 Rakesh Kudurumalla
2023-08-01 8:49 ` Rakesh Kudurumalla
2023-09-27 5:22 ` Nithin Dabilpuram [this message]
2023-09-28 9:14 ` [PATCH v3 " Rakesh Kudurumalla
2023-10-17 11:07 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuDWKTg00OXmb0Fuqn+zO4ok2WJ4R88Px7ayJAiK1D6ouJKBg@mail.gmail.com \
--to=nithind1988@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=rkudurumalla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).