From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2274E4264D; Wed, 27 Sep 2023 07:23:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E997340277; Wed, 27 Sep 2023 07:23:03 +0200 (CEST) Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) by mails.dpdk.org (Postfix) with ESMTP id DAE9D40271 for ; Wed, 27 Sep 2023 07:23:02 +0200 (CEST) Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-418af4d7df3so20130861cf.1 for ; Tue, 26 Sep 2023 22:23:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695792182; x=1696396982; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E5hGuBGwsftUe/a7ASus0yC/1DDyJdMmJExYgDuzz64=; b=aAk+iZxEll+TObcHkbKCLZpTKEN5UwsOFlKVltWxKNEDB2X4/wnSQImkxh4oylTnWK W+DKJYc/+AnYRaotlb3OQWXNHbOhIbM6EoTWo0bBt/S/w4RRVNkDYVAkz/LPr0uxYyjA zjCNNnlSH776A6m+M5FZ7sJ+hTIzf58KMHTvXPaKPBBATrbnNcRKrHESq5NjbnWUOLg6 LQ0WW6wKZAhJwUfZ71hKf4Hs7YL39f+9br7e6CWQnsaS+Sm/39cgX+I6IqZ9wG0d0Kyj PX6PIXRyp197ctNsiw8KOW/f1UEIYUUggcoCljmB+latpJUmJlvVumLmYDfiVdDnGjbu uJVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695792182; x=1696396982; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E5hGuBGwsftUe/a7ASus0yC/1DDyJdMmJExYgDuzz64=; b=r2KoMhgbBTltW0LdQHVE5e7TSNGmI2A4vUjF+QpajoXMH2c+HJhKCdbdqRSp5msx9e lxjsEEYjr6LTsPffIFuK84MIFiAKCec5EHrefx9zJy5l1omrkK3ZlIJKFx+c3OVjUyg6 uDDn8vNHDJIaasD6lnLUU8T5YSEWiOyuyaSKwOkXgqQvQXJD798TWYQUP8ZxemxiIOC3 5wYD6LsqusIWSOrHMaaEwIf9nmuuDH6AFjUNHgxvbwiV0dcxHOvOdsgPCdGha3voXMAg v6FI31qW7aCohXTuY7Y/AiFrqt8Mx2Fh1mnz7IcClDe0c9jyJzJUk+5ASuyCs/Uol9aD dZRw== X-Gm-Message-State: AOJu0YxqhgIUR1OmQPSiG2HLiQ+sCqzmBWi++G7CrgXmaKXqmE2YyM0t qaVELmdY+jEK4AcmZXFpxXfnQhekoYMu1xv8K8o= X-Google-Smtp-Source: AGHT+IGu1W46K+Yi6KnJIMofIolJWZ2Fgks+z+yil87WifOCD202MhGvI8d0qzdIROy6zAxqaiw/TZSDLV5aWD8opVo= X-Received: by 2002:ac8:5b12:0:b0:418:80:f4d4 with SMTP id m18-20020ac85b12000000b004180080f4d4mr1416443qtw.67.1695792182146; Tue, 26 Sep 2023 22:23:02 -0700 (PDT) MIME-Version: 1.0 References: <20230719123013.600659-1-rkudurumalla@marvell.com> <20230801084916.1542854-1-rkudurumalla@marvell.com> In-Reply-To: <20230801084916.1542854-1-rkudurumalla@marvell.com> From: Nithin Dabilpuram Date: Wed, 27 Sep 2023 10:52:50 +0530 Message-ID: Subject: Re: [PATCH 1/1] node: remove MAX macro from all nodes To: Rakesh Kudurumalla Cc: Nithin Dabilpuram , Pavan Nikhilesh , dev@dpdk.org, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Nithin Dabilpuram On Tue, Aug 1, 2023 at 2:19=E2=80=AFPM Rakesh Kudurumalla wrote: > > Removed MAX macro from all graph nodes to extend > edges to nodes at ease > > Signed-off-by: Rakesh Kudurumalla > --- > > v2: Update changes to TOT and resolve > dependecy related issues > > lib/node/ip4_lookup.c | 2 +- > lib/node/ip6_lookup.c | 2 +- > lib/node/rte_node_ip4_api.h | 2 -- > lib/node/rte_node_ip6_api.h | 2 -- > 4 files changed, 2 insertions(+), 6 deletions(-) > > diff --git a/lib/node/ip4_lookup.c b/lib/node/ip4_lookup.c > index 8bce03d7db..72fd760512 100644 > --- a/lib/node/ip4_lookup.c > +++ b/lib/node/ip4_lookup.c > @@ -225,7 +225,7 @@ static struct rte_node_register ip4_lookup_node =3D { > > .init =3D ip4_lookup_node_init, > > - .nb_edges =3D RTE_NODE_IP4_LOOKUP_NEXT_MAX, > + .nb_edges =3D RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP + 1, > .next_nodes =3D { > [RTE_NODE_IP4_LOOKUP_NEXT_REWRITE] =3D "ip4_rewrite", > [RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP] =3D "pkt_drop", > diff --git a/lib/node/ip6_lookup.c b/lib/node/ip6_lookup.c > index 646e466551..6f56eb5ec5 100644 > --- a/lib/node/ip6_lookup.c > +++ b/lib/node/ip6_lookup.c > @@ -362,7 +362,7 @@ static struct rte_node_register ip6_lookup_node =3D { > > .init =3D ip6_lookup_node_init, > > - .nb_edges =3D RTE_NODE_IP6_LOOKUP_NEXT_MAX, > + .nb_edges =3D RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP + 1, > .next_nodes =3D { > [RTE_NODE_IP6_LOOKUP_NEXT_REWRITE] =3D "ip6_rewrite", > [RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP] =3D "pkt_drop", > diff --git a/lib/node/rte_node_ip4_api.h b/lib/node/rte_node_ip4_api.h > index 3397da0ae8..0f997761b6 100644 > --- a/lib/node/rte_node_ip4_api.h > +++ b/lib/node/rte_node_ip4_api.h > @@ -29,8 +29,6 @@ enum rte_node_ip4_lookup_next { > RTE_NODE_IP4_LOOKUP_NEXT_REWRITE, > /**< Rewrite node. */ > RTE_NODE_IP4_LOOKUP_NEXT_PKT_DROP, > - /**< Packet drop node. */ > - RTE_NODE_IP4_LOOKUP_NEXT_MAX, > /**< Number of next nodes of lookup node. */ > }; > > diff --git a/lib/node/rte_node_ip6_api.h b/lib/node/rte_node_ip6_api.h > index f3b5a1002a..a538dc2ea7 100644 > --- a/lib/node/rte_node_ip6_api.h > +++ b/lib/node/rte_node_ip6_api.h > @@ -30,8 +30,6 @@ enum rte_node_ip6_lookup_next { > /**< Rewrite node. */ > RTE_NODE_IP6_LOOKUP_NEXT_PKT_DROP, > /**< Packet drop node. */ > - RTE_NODE_IP6_LOOKUP_NEXT_MAX, > - /**< Number of next nodes of lookup node. */ > }; > > /** > -- > 2.25.1 >