From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7CD4E4406C; Sun, 19 May 2024 19:24:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 150B24026A; Sun, 19 May 2024 19:24:07 +0200 (CEST) Received: from mail-yw1-f178.google.com (mail-yw1-f178.google.com [209.85.128.178]) by mails.dpdk.org (Postfix) with ESMTP id 045CB40144 for ; Sun, 19 May 2024 19:24:06 +0200 (CEST) Received: by mail-yw1-f178.google.com with SMTP id 00721157ae682-61ae4743d36so17031087b3.2 for ; Sun, 19 May 2024 10:24:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716139445; x=1716744245; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Pi4yG62yuV5lVldb+aJIavppIIqGarufw8hSzBkyWos=; b=UfAE5Me9yFzBqnlUpUGuz/wWFUJI7YvuA5FpVbeQYlF746dGe+kUYsKmW4wWA2tjaI ZvrFGJLG7J60mdekNy9twF4R3bVxGfkzkLzZRlDgNmXZjsqStyEJExvS8aaLURTR12S6 LzZnUtuFUvpGYMguLjx/LAKCkZM0YaNHqeLxQB8yQxhB/cxf6HL0GqCg0UsHlMMYd/f/ 1GLZPpjREZGm3+QUqucNONbjLunuKn/7XiGbzhy+ogmiCXqsp3Qn4R/z+RrC5QHcVFLf n2Y4I55HEWOvjzN/X6Vc2NQuaPfNSyxEvljhAuPHLmXuZ5Oz6aZ5j2b/xS3NHztMJ5LV sqAQ== X-Forwarded-Encrypted: i=1; AJvYcCX3F+KhDZP0xu8oUFpjDTeSoF1TLmEXushvhineotjOWUI2ME31iASp3BR65rtjA+/SqFR469/gPjee5Ww= X-Gm-Message-State: AOJu0YwrSHdp/3GKHMLM3OijTdorep5e4uAOWLy3YoC49SRMklr4C2jg koSyE/UesyI5en6kvS4hJCkK3CgMi3XhPk7r3hIbfDDzpf3bQ0VSbNMetJpN X-Google-Smtp-Source: AGHT+IGLEu3TbLwZWfkh+T4yQvjhan8WUCDTrCH0x6y4KFlHxK8J5jMi+AD0bPhVmlAO7WKjQXzbWw== X-Received: by 2002:a05:690c:7010:b0:617:c383:42ac with SMTP id 00721157ae682-622b016d63emr270242327b3.51.1716139445134; Sun, 19 May 2024 10:24:05 -0700 (PDT) Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com. [209.85.219.170]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6209e48a06dsm46806257b3.130.2024.05.19.10.24.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 19 May 2024 10:24:04 -0700 (PDT) Received: by mail-yb1-f170.google.com with SMTP id 3f1490d57ef6-dee9943a293so1703064276.0 for ; Sun, 19 May 2024 10:24:04 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCUSkv2/qe9y8Uh1Fz9/YTz+LrSlYV+uQyNf8yQJYu7dxWiK5HtugisQpiEQ0WUPo67Jb3+uLy+4D1iL6rQ= X-Received: by 2002:a05:6902:1b8f:b0:df4:a2e7:dd6 with SMTP id 3f1490d57ef6-df4a2e70f8bmr1456609276.0.1716139444711; Sun, 19 May 2024 10:24:04 -0700 (PDT) MIME-Version: 1.0 References: <20230629125838.1995751-1-christian.ehrhardt@canonical.com> <24173311.ouqheUzb2q@thomas> <2121200.bB369e8A3T@thomas> In-Reply-To: <2121200.bB369e8A3T@thomas> From: Luca Boccassi Date: Sun, 19 May 2024 18:23:53 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] doc: ensure sphinx output is reproducible To: Thomas Monjalon Cc: Christian Ehrhardt , Bruce Richardson , dev@dpdk.org, david.marchand@redhat.com, "Mcnamara, John" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, 19 May 2024 at 18:13, Thomas Monjalon wrote: > > 19/05/2024 18:36, Luca Boccassi: > > On Sun, 19 May 2024 at 15:01, Thomas Monjalon wrote: > > > 17/05/2024 13:29, Luca Boccassi: > > > > On Mon, 27 Nov 2023 at 17:04, Bruce Richardson > > > > wrote: > > > > > > > > > > On Mon, Nov 27, 2023 at 05:45:52PM +0100, Thomas Monjalon wrote: > > > > > > I would prefer adding an option for reproducible build > > > > > > (which is not a common requirement). > > > > > > > > > > > Taking a slightly different tack, is it possible to sort the searchindex.js > > > > > file post-build, so that even reproducible builds get the benefits of > > > > > parallelism? > > > > > > > > Given the recent attacks with malicious sources being injected in open > > > > source projects, reproducible builds are more important than ever and > > > > should just be the default. > > > > > > Yes it should be the default when packaging. > > > Why should it be the default for normal builds? > > > > Build reproducibility is everyone's responsibility, not just Linux > > distributions. There should be no difference between a "normal build" > > and a "packaging build". As far as I know, it is still fully supported > > for DPDK consumers to take the git repository, build it and ship it > > themselves - those cases also need their builds to be reproducible. > > Sorry I really don't understand this point. > The goal of a reproducible build is to maintain a stable hash, right? > This hash needs to be stable only when it is published, isn't it? > So isn't it enough to give a build option for having a reproducible build? The goal is that issues breaking reproducibility are bugs and treated as such. You wouldn't have a build option to allow buffer overflows or null pointer dereferences, and so on. "The program builds reproducibly" today and in the future has the same importance as "the program doesn't write beyond bounds" or "the program doesn't crash" - they are not optional qualities, they are table stakes, and regulations are only going to get stricter.