Re: [PATCH] Revert "eal/unix: fix thread creation"

[Luca Boccassi <luca.boccassi@gmail.com>]

On Wed, 30 Oct 2024 at 19:52, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Wed, 30 Oct 2024 19:08:41 +0000
> luca.boccassi@gmail.com wrote:
>
> > From: Luca Boccassi <luca.boccassi@gmail.com>
> >
> > This commit introduced a regression on arm64, causing a deadlock.
> > lcores_autotest gets stuck and never terminates:
> >
> > [ 1077s] EAL: Detected CPU lcores: 4
> > [ 1077s] EAL: Detected NUMA nodes: 1
> > [ 1077s] EAL: Detected shared linkage of DPDK
> > [ 1077s] EAL: Multi-process socket /tmp/dpdk/rte/mp_socket
> > [ 1077s] EAL: Selected IOVA mode 'VA'
> > [ 1077s] APP: HPET is not enabled, using TSC as default timer
> > [ 1077s] RTE>>lcores_autotest
> > [ 1127s] DPDK:fast-tests / lcores_autotest time out (After 50.0 seconds)
> >
> > This is 100% reproducible when running the fast tests suite
> > after a package build on OBS. Reverting it reliably fixes the
> > issue.
> >
> > This reverts commit b28c6196b132d1f25cb8c1bf781520fc41556b3a.
> > ---
> > I have bisected this long standing issue and identified the commit
> > that introduced it. If anybody can provide a different fix that would
> > be better, but if it's not possible to find another solution, it would
> > be good to revert it until it can be found, to resolve the regression.
> >
> >  lib/eal/unix/rte_thread.c | 73 +++++++++++++++------------------------
> >  1 file changed, 28 insertions(+), 45 deletions(-)
>
> Missing DCO (no Signed-off-by) which is required even for a Revert.
>
> Also Luca usually uses either Debian or Microsoft email address
> getting one from gmail is different and not in mailmap.

Yeah forgot the signed-off, sent v2, thanks