From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA0D945B82; Wed, 30 Oct 2024 21:32:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9501432D4; Wed, 30 Oct 2024 21:32:03 +0100 (CET) Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by mails.dpdk.org (Postfix) with ESMTP id B636542F2B for ; Wed, 30 Oct 2024 21:32:02 +0100 (CET) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-6ea50585bf2so2113307b3.3 for ; Wed, 30 Oct 2024 13:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730320322; x=1730925122; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=PFNx+S1vRv0hyJ85LIidbblR2RLvpTF2hGM2lFxUpn0=; b=AnV9C71PDAfbkDWG20TjmPjf5L9+E+vyG22EECjwdK9f/R6kOyBYP3HZTAsxKoYPAQ AEhj/uG6iSwo38m6993FXdqJZzpqJFc/DsqCdsHXyRdaR5qYtPaMoLweE86uCwAW+LVu ti+DyXgD7eXGBqy1wZGjsUaxkWClBfbZg4PCvUoDqVdKWEIASE+ib5nRo9LHIY/jZGui cp8h9btnHHEdHObW8N2xf0Q3tnXAo8ybe5MT1w/gRiZ6g+pUX7pL+Z5JmaldT76fSBJd K4m47hU6iTCaJJzHAzLLylTkbUHfxEV6Z0x1jL8ZJL9xsllldSCpS3vfsf6a82TjGPkz iACw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730320322; x=1730925122; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PFNx+S1vRv0hyJ85LIidbblR2RLvpTF2hGM2lFxUpn0=; b=YRi1jXS0dBBwzglQebUqMsjN1ZZAtJvwlvQsw3nwgvVfSBZ1MPDZMHfYuXamAlivJK vPyUkAiicc2bGDUByP8JHP6Hjsf8gIsgR3Pl0KIFxQudIXNHmXSjZ7e5uDwUm7DSUK7g 4bW/8PJ3wRWwE43Wlvb4VFAgi6y3g2cWJQEzLWPwWm1TtTof5Mmk677/cOL5nY1736Dm 10QOBzg2Xy7c24Gaf1dEPWnYSt1Fsdq8oIv/cgWi4MOim+ZdNXb8pIcfwDlvUzZ2/INR tbJpdn1DS6gBJix2c4tMMEbRUBiaS7AJt+g4CnxMIfMJKQBru6VTy6UO9/Eltz48gKoX IYcw== X-Gm-Message-State: AOJu0Yw0VZxJxnjlYLkQGIrVLL407R6FiLCd/3GuTep7tenLmsqi1R2n GzNaivDZAnrXoObyXLl/waSLzTc9QoCv8vMxAUfTaqMffSs3uC9AeA6iE9/halZIHJ+X1kZ73sI cxB1Z3W88TzJnUenuZWRYmMS5jFg= X-Google-Smtp-Source: AGHT+IH5NhM4OQR4lscJPQH8GhWpYRCESyFqS5HlZ+PWpHDhbJXmh1uMuGmeNrYa6n0PYRdjmCyVXxuRqjh8yNJUO44= X-Received: by 2002:a05:690c:60c1:b0:6de:2ae:811f with SMTP id 00721157ae682-6e9d8b34729mr195908367b3.35.1730320322042; Wed, 30 Oct 2024 13:32:02 -0700 (PDT) MIME-Version: 1.0 References: <20241030190945.409721-1-luca.boccassi@gmail.com> <20241030125214.0274b37b@hermes.local> In-Reply-To: <20241030125214.0274b37b@hermes.local> From: Luca Boccassi Date: Wed, 30 Oct 2024 20:31:50 +0000 Message-ID: Subject: Re: [PATCH] Revert "eal/unix: fix thread creation" To: Stephen Hemminger Cc: dev@dpdk.org, david.marchand@redhat.com, roretzla@linux.microsoft.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Oct 2024 at 19:52, Stephen Hemminger wrote: > > On Wed, 30 Oct 2024 19:08:41 +0000 > luca.boccassi@gmail.com wrote: > > > From: Luca Boccassi > > > > This commit introduced a regression on arm64, causing a deadlock. > > lcores_autotest gets stuck and never terminates: > > > > [ 1077s] EAL: Detected CPU lcores: 4 > > [ 1077s] EAL: Detected NUMA nodes: 1 > > [ 1077s] EAL: Detected shared linkage of DPDK > > [ 1077s] EAL: Multi-process socket /tmp/dpdk/rte/mp_socket > > [ 1077s] EAL: Selected IOVA mode 'VA' > > [ 1077s] APP: HPET is not enabled, using TSC as default timer > > [ 1077s] RTE>>lcores_autotest > > [ 1127s] DPDK:fast-tests / lcores_autotest time out (After 50.0 seconds) > > > > This is 100% reproducible when running the fast tests suite > > after a package build on OBS. Reverting it reliably fixes the > > issue. > > > > This reverts commit b28c6196b132d1f25cb8c1bf781520fc41556b3a. > > --- > > I have bisected this long standing issue and identified the commit > > that introduced it. If anybody can provide a different fix that would > > be better, but if it's not possible to find another solution, it would > > be good to revert it until it can be found, to resolve the regression. > > > > lib/eal/unix/rte_thread.c | 73 +++++++++++++++------------------------ > > 1 file changed, 28 insertions(+), 45 deletions(-) > > Missing DCO (no Signed-off-by) which is required even for a Revert. > > Also Luca usually uses either Debian or Microsoft email address > getting one from gmail is different and not in mailmap. Yeah forgot the signed-off, sent v2, thanks