From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 61329A04DE;
	Fri, 30 Oct 2020 17:33:50 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 95DA0377E;
	Fri, 30 Oct 2020 17:33:48 +0100 (CET)
Received: from mail-lf1-f67.google.com (mail-lf1-f67.google.com
 [209.85.167.67]) by dpdk.org (Postfix) with ESMTP id 0A088354D
 for <dev@dpdk.org>; Fri, 30 Oct 2020 17:33:46 +0100 (CET)
Received: by mail-lf1-f67.google.com with SMTP id j30so8652827lfp.4
 for <dev@dpdk.org>; Fri, 30 Oct 2020 09:33:46 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=8+qNLWvvzYmT6sr8dgD24gHItuoVZ1iQMBTrGkAXcWY=;
 b=DMujqhB7lgm8ipygcSHcFOJP+195yuknliiWfs+JifxvppdDLFA3gX0OTkXrDAgYwj
 z9QC5s59QjdWvhIvMDafHMYukveHBAAOuT5tSZX+3ZuuxnJ64ipx37ALFB6dG91S/yud
 Js2HFFwEPRzDmbmdcHtKQR3c+imD1HVoy7Nx7SdLQqzbO0GU3kLjDhpK268rFoGKFxyN
 S643eWQgnD5eq+r+GLIb1p6jFZxNXA0FJA7xtomI0M88D4CPp0Kx+M2xKcUNI+44X1AE
 Hign978oSgY4zbUV9hk0YoFYCkGZP5sZdjddJTzw5XbkLAQd98SHQ3LMRqbvsUGWLqkx
 xqrQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=8+qNLWvvzYmT6sr8dgD24gHItuoVZ1iQMBTrGkAXcWY=;
 b=l2wO/G/RfjpUe7BRFJDbfmHrBNax5hXATwiKZ4oVzGFj5ADSgw375uC2H0i1Xzbs6y
 hgqRxDH3AAL6O3GE0BhMJ5dkNOFClRKU606nD0kqf5XmQTK22cPnIgrnYeP21rIn2cw0
 goxZr3wUAy9A/r6/J/ky0BRjhL3S6Lvlm7n/A7ixCcDRHtR2XzA3xdc7WUrZ7/bhPJ6E
 LFUZiJc7+z5FQr1SuYsj6KkJLiSe4YDMsr/F9vFB4jy/y4r75nndX1e5o1p2SiZEIJUD
 LrzfglLmk9ARH6JzAhKr4xo4nW4P320te19QcTOk988r61H2AGteJdHJpNOcv9k/1EwP
 8qXw==
X-Gm-Message-State: AOAM530XUYhPW92U+ZDB9oFDY+l+64dpH4lEDcBwyoT/qnksngM5j+Zo
 nmPKm2kOs8WxHEoKJECvYPFtcbj9EYGIoLYbBNJdklp147Y=
X-Google-Smtp-Source: ABdhPJwn0kATbKp3SJh12mv1sGiE9+RLZLhf9Q3wnb36wklFvRryKw/8nbulyNTD3iMNWdlSYVNf4yMNFgs/1ACcOms=
X-Received: by 2002:a19:8457:: with SMTP id g84mr1185676lfd.500.1604075624420; 
 Fri, 30 Oct 2020 09:33:44 -0700 (PDT)
MIME-Version: 1.0
References: <20201028181557.3662981-1-luca.boccassi@gmail.com>
 <1663315.mKj0e5xtuq@thomas>
In-Reply-To: <1663315.mKj0e5xtuq@thomas>
From: Luca Boccassi <luca.boccassi@gmail.com>
Date: Fri, 30 Oct 2020 16:33:30 +0000
Message-ID: <CAMw=ZnS992ivG2O7KqwwbQjKTcLfi8jnMde44YJc-fsjTB8AGA@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in
	Kbuild
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 29 Oct 2020, 20:58 Thomas Monjalon, <thomas@monjalon.net> wrote:

> 28/10/2020 19:15, luca.boccassi@gmail.com:
> > From: Luca Boccassi <luca.boccassi@microsoft.com>
> >
> > Necessary to get build flags from DKMS.
> >
> > See:
> >
> > https://git.dpdk.org/dpdk/commit/?id=816d967717
> [...]
> > --- a/linux/igb_uio/Kbuild
> > +++ b/linux/igb_uio/Kbuild
> > @@ -1 +1,2 @@
> > +ccflags-y := $(MODULE_CFLAGS)
> >  obj-m := igb_uio.o
>
> Yes this patch was not migrated because I though it was referring
> to a DPDK-specific variable.
> So you mean MODULE_CFLAGS is from the kernel build system?
>

Yeah dkms uses it

>