* [PATCH] test: fix 32 bit overflow in pcapng test
@ 2024-07-18 17:42 Stephen Hemminger
2024-07-18 19:07 ` Luca Boccassi
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2024-07-18 17:42 UTC (permalink / raw)
To: dev; +Cc: Luca Boccassi, Stephen Hemminger, Reshma Pattan
The conversion from seconds to nanoseconds in the pcapng test
would overflow on 32 bit platforms leading to this test failing.
Reported-by: Luca Boccassi <bluca@debian.org>
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
app/test/test_pcapng.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_pcapng.c b/app/test/test_pcapng.c
index 89535efad0..2665b08c76 100644
--- a/app/test/test_pcapng.c
+++ b/app/test/test_pcapng.c
@@ -235,7 +235,7 @@ parse_pcap_packet(u_char *user, const struct pcap_pkthdr *h,
* but the file is open in nanonsecond mode therefore
* the timestamp is really in timespec (ie. nanoseconds).
*/
- ns = h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
+ ns = (uint64_t)h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
if (ns < ctx->start_ns || ns > ctx->end_ns) {
char tstart[128], tend[128];
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] test: fix 32 bit overflow in pcapng test
2024-07-18 17:42 [PATCH] test: fix 32 bit overflow in pcapng test Stephen Hemminger
@ 2024-07-18 19:07 ` Luca Boccassi
2024-07-29 16:33 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Luca Boccassi @ 2024-07-18 19:07 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Reshma Pattan
On Thu, 18 Jul 2024 at 18:43, Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The conversion from seconds to nanoseconds in the pcapng test
> would overflow on 32 bit platforms leading to this test failing.
>
> Reported-by: Luca Boccassi <bluca@debian.org>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> app/test/test_pcapng.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test/test_pcapng.c b/app/test/test_pcapng.c
> index 89535efad0..2665b08c76 100644
> --- a/app/test/test_pcapng.c
> +++ b/app/test/test_pcapng.c
> @@ -235,7 +235,7 @@ parse_pcap_packet(u_char *user, const struct pcap_pkthdr *h,
> * but the file is open in nanonsecond mode therefore
> * the timestamp is really in timespec (ie. nanoseconds).
> */
> - ns = h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
> + ns = (uint64_t)h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
> if (ns < ctx->start_ns || ns > ctx->end_ns) {
> char tstart[128], tend[128];
Thanks this fixes the issue, the build is now green
Tested-by: Luca Boccassi <bluca@debian.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] test: fix 32 bit overflow in pcapng test
2024-07-18 19:07 ` Luca Boccassi
@ 2024-07-29 16:33 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2024-07-29 16:33 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: dev, Reshma Pattan, Luca Boccassi
18/07/2024 21:07, Luca Boccassi:
> On Thu, 18 Jul 2024 at 18:43, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The conversion from seconds to nanoseconds in the pcapng test
> > would overflow on 32 bit platforms leading to this test failing.
> >
> > Reported-by: Luca Boccassi <bluca@debian.org>
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> > - ns = h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
> > + ns = (uint64_t)h->ts.tv_sec * NS_PER_S + h->ts.tv_usec;
>
> Thanks this fixes the issue, the build is now green
>
> Tested-by: Luca Boccassi <bluca@debian.org>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-29 16:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-18 17:42 [PATCH] test: fix 32 bit overflow in pcapng test Stephen Hemminger
2024-07-18 19:07 ` Luca Boccassi
2024-07-29 16:33 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).