From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A605A09FF; Thu, 7 Jan 2021 02:42:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB177140E49; Thu, 7 Jan 2021 02:42:41 +0100 (CET) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) by mails.dpdk.org (Postfix) with ESMTP id A50EC140E48 for ; Thu, 7 Jan 2021 02:42:40 +0100 (CET) Received: by mail-yb1-f172.google.com with SMTP id u203so4696246ybb.2 for ; Wed, 06 Jan 2021 17:42:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tRwsq89nBAJ9bCJHMAOXwuH4NXdcOb+3VqQM5N6E2qc=; b=jOtXXS95zSiGae24+gqdc6VNDgNIZVPkTrBXEQlIwvMkEVVwuJcbAmBhXLjgoy+/Ov N01uRlYUyrAGaKFgdNg0+reIPdjLx8BhkgNMin7pHlWWJNFRIfDbkWBcqlkKGvFOFH5O Nr4YpFzaV3cs9eje46Q5p8TIQuCz6x07ipVd2HRETUBYQQT6u/1iwn//zgZWk74ZksB4 mF2AduTMboRSL861bGgZ/tvUukcG+wOwtauk0mS/d6VX5s90Njt0K6TG71z8hnEC2kOn /2qGQ3R3ApsiNnpHy2jhvzKi7yxF3b8exSy5Ewfil/Wxf2K/1bvKoEtUbL6kP/dgU4In tnDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tRwsq89nBAJ9bCJHMAOXwuH4NXdcOb+3VqQM5N6E2qc=; b=cAoIGtz4oTsEH8KJYzqNI0S5LkHVzidujk+fWSXVIjilEnu+6J5BDSq7jy9fxhvNn4 MpXt1SiCKcUvuCp90NP/5I8GYXSmMJ2LpExnOY2bHpKUJ4T6rnQHJ5ZvfXUsN3qaJeUv n1w0M34/PwhFZpgoSZ4bylqmmn7pnwbg1y30a2BDzz99W7teg9QgoGnLhmzO1fgwL6l6 Lk8Z41ULAgOmUnoo+BSCQHXXSR9yZ0VfMsdnGNhG6XggxhudeM+U+9bJCVF+x6QXd2FY 8qruFMxVH1f8aTreOlL7auWJWo+IvxubDZBLSqGsZbybfSzOk/z6kqUH+KxvbsGchreu Yf5g== X-Gm-Message-State: AOAM533FxgI/20Hbprg4DodxQzEiDqeIk8pko9KtdHsguw4HSXJUh5Et nOwIkE8or9rEMjJwemcm3pzNv+Fv9oQzfuwpqt7JWUKLPyZ1sg== X-Google-Smtp-Source: ABdhPJwPmllht+637Nl/id8vu4GYqerdC9hs/Pq32p3hMPL1GTRUZuR07MGwsz+LnEqOcCY3HZ2WW3EuZhGVlK/H19M= X-Received: by 2002:a25:d392:: with SMTP id e140mr10938752ybf.70.1609983760085; Wed, 06 Jan 2021 17:42:40 -0800 (PST) MIME-Version: 1.0 References: <20201229194144.17824-1-ashish.sadanandan@gmail.com> <20201229121008.3644fed4@hermes.local> <20210106132132.GK2631@platinum> In-Reply-To: <20210106132132.GK2631@platinum> From: Ashish Sadanandan Date: Wed, 6 Jan 2021 18:42:13 -0700 Message-ID: To: Olivier Matz Cc: stephen@networkplumber.org, dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: add extern "C" to rte_mbuf_dyn.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Olivier, On Wed, Jan 6, 2021 at 6:21 AM Olivier Matz wrote: > > Hi Ashish, > > Yes, it should reference the patch that introduced the issue. In this case, > it should be: > > Fixes: 4958ca3a443a ("mbuf: support dynamic fields and flags") > > Can you please also change the title to start with "fix", for > instance like this: > > mbuf: fix inclusion from c++ > > You can also add "Cc: stable@dpdk.org" in the commit log. > > Some documentation can be found in doc/guides/contributing/patches.rst Thanks for the pointers. I've made the changes above. However I don't know if I'm using the message ID for --in-reply-to correctly, since I seem to be creating a new thread each time. Thanks, Ashish. > > Thanks, > Olivier > > > > PS: this is my first time submitting a patch to DPDK, so forgive me if this > > is covered in the contributing doc, but I couldn't find anything that > > applied to this situation > > > > On Tue, Dec 29, 2020 at 1:10 PM Stephen Hemminger < > > stephen@networkplumber.org> wrote: > > > > > On Tue, 29 Dec 2020 12:41:44 -0700 > > > Ashish Sadanandan wrote: > > > > > > > The header was missing the extern "C" directive which causes name > > > > mangling of functions by C++ compilers, leading to linker errors > > > > complaining of undefined references to these functions. > > > > > > > > Signed-off-by: Ashish Sadanandan > > > > > > Could you add a Fixes tag please? > > >