From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua0-f179.google.com (mail-ua0-f179.google.com [209.85.217.179]) by dpdk.org (Postfix) with ESMTP id 129B7354D for ; Fri, 12 Jan 2018 11:57:48 +0100 (CET) Received: by mail-ua0-f179.google.com with SMTP id l35so3750069uad.4 for ; Fri, 12 Jan 2018 02:57:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1kaoPH4Y7HkmCZ8HVyMhGOXfGbxHFSDuFceSST2Ke0w=; b=vhjdAcH6A+jBM9gojwEtUfRlTi/Eix9lhnR+YCI/OrqPeRibdQyr/fB+aFJzpLqJ7B a6P8HY150C58IyW/18kGB9zWHUNdEgmfqNWJcqXnmXvZHaNw4Y50XR3BpBPLHDNDU/gS CaydA9O/b9kASXGWwVzbfI8uRDpj747f1MiUj2ASh2ctMPjN0AnhH64V7Cc9U0M2dnVV b4ZszYtzoyXXt/u+yIwnVhRWacbj9of63iitZIUh+WDRrN2DMYoyqSov3Eb0LVnot7S0 0R3n/2kgAIX74ggQVDacWVL0sAaQp0qDS+A5GyQy6tQ4yP5R1gaO0/qJNXG8amAod3wl /nHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1kaoPH4Y7HkmCZ8HVyMhGOXfGbxHFSDuFceSST2Ke0w=; b=kvbYgQqPyuWktLSzPI9dz0n3TqGAU/T8/1n1Xko3fnJrwsuVvsuyDLB4/svEqmT3zH LBxnbM3WPvDpkt2sKqys5fVFbplRNNUGIfdvZen97ptDFs4eGYZePZtk1oJdp3GHou5B i/cibjM7p1qlBKGHb7xXoiFB2+mqrh/9yPrS5Cnw3wakxWP0y9X1BOb+LaABal+lr0JF jJkF7AmCHkBx3l3oaz3PhXqVJouYoP/1QUwsqWj2Mwzk5kifJ2RDiOZb2oLNukOgiq1m P9SpGTtSisbhazPU315PwkqndIwGHSQ5PYUULP04eCWgpO5lZc5vMJUodfnTvp2NcwMe TU8Q== X-Gm-Message-State: AKwxyteZSTXDG12jpRunrDYRJ0svb/OojFwxSt2qAJKDHYkRO16I/6uS PVbj43buRCH5HqCEVKIL1rb6+iEmkxcksjtMYZg= X-Google-Smtp-Source: ACJfBovpG45VlNBMYSGenyn+3xB388jzZK7CfDESh9e4c7EmKPpWXgHGE7wLfjMODTqJMFFa3oGjBhHuOXBjlKhS8Dk= X-Received: by 10.176.4.102 with SMTP id 93mr17126541uav.128.1515754667345; Fri, 12 Jan 2018 02:57:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.38.134 with HTTP; Fri, 12 Jan 2018 02:57:46 -0800 (PST) In-Reply-To: <20180112103834.br6bq5z3sm7o2tkz@bidouze.vm.6wind.com> References: <20180112103834.br6bq5z3sm7o2tkz@bidouze.vm.6wind.com> From: george.dit@gmail.com Date: Fri, 12 Jan 2018 11:57:46 +0100 Message-ID: To: =?UTF-8?Q?Ga=C3=ABtan_Rivet?= Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Move flow parsing from test-pmd to librte_cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 10:57:48 -0000 Hi Gaetan, Thanks for your quick and positive reply, I will submit a patch today. Best regards, Georgios On Fri, Jan 12, 2018 at 11:38 AM, Ga=C3=ABtan Rivet wrote: > Hi George, > > On Fri, Jan 12, 2018 at 10:21:41AM +0100, george.dit@gmail.com wrote: > > Dear DPDK developers, > > > > In an attempt to integrate the Flow API into a third party application > and > > allow the e.g., insertion/deletion of NIC classification rules from tha= t > > application, I noticed that flow command parsing as per the most recent > > DPDK versions (i.e., 17.08 or 17.11) might benefit from some useful > > modifications. > > > > Specifically, librte_cmdline provides libraries for parsing a flow > command > > into tokens, but then the library for e.g., creating/deleting a flow ru= le > > for a DPDK NIC resides in test-pmd (app/test-pmd/cmdline_flow.c). > > > > My proposal is to move the app/test-pmd/cmdline_flow.c library into > > librte_cmdline, thus facilitate flow parsing for third party DPDK > > applications. > > I have a working prototype for both DPDK 17.08 and 17.11. This prototyp= e > > extends librte_cmdline with 2 additional files (cmdline_flow.h and .c) > and > > removes this functionality from test-pmd. > > The benefit is that the functions in cmdline_flow.h can now be re-used = by > > any DPDK applications, which was not the case before. > > > > Do you think that the DPDK community will benefit from my patch? If so,= I > > am happy to send you the patch for review and get your feedback to > further > > improve it. > > In case I missed some other way to achieve my goal (without the need to > > patch DPDK), please let me know. > > > > Best regards, > > My opinion would that it might be interesting to have parsing helpers > available for complex APIs such as this one, ready to be dropped into > applications. > > There were contentions not too long ago about the status of rte_cmdline, > but in any case I think it could be interesting to have your input on > this. > > So don't hesitate to send it. > > Cheers, > -- > Ga=C4=97tan Rivet > 6WIND > --=20 Georgios Katsikas Industrial Ph.D. Student Network Intelligence Group Decision, Networks, and Analytics (DNA) Lab RISE SICS E-Mail: georgios.katsikas@ri.se