From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f48.google.com (mail-vk0-f48.google.com [209.85.213.48]) by dpdk.org (Postfix) with ESMTP id 966571E35 for ; Fri, 12 Jan 2018 10:21:43 +0100 (CET) Received: by mail-vk0-f48.google.com with SMTP id w75so3219053vkd.7 for ; Fri, 12 Jan 2018 01:21:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=ZZfrXpKQr4BKMwk3bkIvZsgLWCKfNnKO21feiwe6S0M=; b=mjJQHOU0vqNhxyjbbT58BPY9M14H8+SPXxNblV+doqTBqOzw5llb5i0zJJUUlbHqIL xkuOqti14gFGPZ87mJLEgyKAdHULI8Pv6tTRdQHn0G4Ewq0E13kISuhyWKcM07VWRbiB KaHjVKwyFL6+amwSwyVt75yEXb74/9iHIpIyd+2Y7JCfdX+wa5JXxQKpuMsCy9mabCeo fLS6MNOTsq+E5yTdog05JbXkNwVYjJlU+MUIxiDm9PD4Cnb00w3b0IJQp+0sntNQsMjn lM1F23xO9+1ibf3qo475f6lXuG5t/MC/Aj2HU0KYYUQKdYxXSBmJfobwhMkzrqHgQyEl yIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=ZZfrXpKQr4BKMwk3bkIvZsgLWCKfNnKO21feiwe6S0M=; b=FT7gU3zq8JVdkRdIzVochor35JN3GbXbfZUQa1Th8SK/Sq0mw5qQdH5Bg+m20ix1TF 2OBx+s2KNxW6pr7qtY+XvqiXuYgXwoL/INvnUK4YY9DxCXYkdb8ljrtsb7J8c7XVRwQ0 kI+jVmxJVZJrrYJTthcHJP1WLpPo02QiN8sbJ3BICIEbbnO3ZjklhAMwmQMVgbqdwlmL 6tRDiG92iq1UVfAPRAKugBSItYu4Sv6xLaeK7TVRnWvtvNwOz/+3Q7iI2ojLZPSnzF5R SiqfAumWpzhk6yd8VAbm5VIO6Z/dpAAoLhyhmsWQq4WyTPDMgxWGwvNzwFRWUje46x02 r/fw== X-Gm-Message-State: AKwxyteaIEILkui6EBbKh1KE8qGKt2EOFb+TQmSc0SesB/WETVdnhfvl wfpaql6DBtoalmjQY58dTm8Bjyo7Exe7knZ6XiFR5Q== X-Google-Smtp-Source: ACJfBosAm8WMMZq3ak3JuMOCEAHUcOkV0W5LGFUTIC9FNfYJQXgEIYTWDVzlFXAmZNU0I+vSU020em2yb23bnfnFyi4= X-Received: by 10.31.15.84 with SMTP id 81mr23222758vkp.1.1515748902568; Fri, 12 Jan 2018 01:21:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.103.38.134 with HTTP; Fri, 12 Jan 2018 01:21:41 -0800 (PST) From: george.dit@gmail.com Date: Fri, 12 Jan 2018 10:21:41 +0100 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Move flow parsing from test-pmd to librte_cmdline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 09:21:43 -0000 Dear DPDK developers, In an attempt to integrate the Flow API into a third party application and allow the e.g., insertion/deletion of NIC classification rules from that application, I noticed that flow command parsing as per the most recent DPDK versions (i.e., 17.08 or 17.11) might benefit from some useful modifications. Specifically, librte_cmdline provides libraries for parsing a flow command into tokens, but then the library for e.g., creating/deleting a flow rule for a DPDK NIC resides in test-pmd (app/test-pmd/cmdline_flow.c). My proposal is to move the app/test-pmd/cmdline_flow.c library into librte_cmdline, thus facilitate flow parsing for third party DPDK applications. I have a working prototype for both DPDK 17.08 and 17.11. This prototype extends librte_cmdline with 2 additional files (cmdline_flow.h and .c) and removes this functionality from test-pmd. The benefit is that the functions in cmdline_flow.h can now be re-used by any DPDK applications, which was not the case before. Do you think that the DPDK community will benefit from my patch? If so, I am happy to send you the patch for review and get your feedback to further improve it. In case I missed some other way to achieve my goal (without the need to patch DPDK), please let me know. Best regards, -- Georgios Katsikas Industrial Ph.D. Student Network Intelligence Group Decision, Networks, and Analytics (DNA) Lab RISE SICS E-Mail: georgios.katsikas@ri.se