From: Vladimir Medvedkin <medvedkinv@gmail.com>
To: Conor Fogarty <conor.fogarty@intel.com>
Cc: dev@dpdk.org, pablo.de.lara.guarch@intel.com, "Medvedkin,
Vladimir" <vladimir.medvedkin@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH] hash: fix segfault by adding param name NULL check
Date: Fri, 1 Mar 2024 17:16:50 +0000 [thread overview]
Message-ID: <CANDrEHkZBADvofiwVZgy6zhigxD05gDTXp1VxsLo93okvgmZ_A@mail.gmail.com> (raw)
In-Reply-To: <20230706152626.476775-1-conor.fogarty@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1858 bytes --]
+cc stable@
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
чт, 6 июл. 2023 г. в 16:26, Conor Fogarty <conor.fogarty@intel.com>:
> Add NULL pointer check to params->name, which is later
> copied into the hash datastructure. Without this check
> the code segfaults on the strlcpy() of a NULL pointer.
>
> Fixes: 48a399119619 ("hash: replace with cuckoo hash implementation")
>
> Signed-off-by: Conor Fogarty <conor.fogarty@intel.com>
>
> ---
> Cc: pablo.de.lara.guarch@intel.com
> ---
> lib/hash/rte_cuckoo_hash.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c
> index d92a903bb3..0aab091c4d 100644
> --- a/lib/hash/rte_cuckoo_hash.c
> +++ b/lib/hash/rte_cuckoo_hash.c
> @@ -166,6 +166,7 @@ rte_hash_create(const struct rte_hash_parameters
> *params)
> /* Check for valid parameters */
> if ((params->entries > RTE_HASH_ENTRIES_MAX) ||
> (params->entries < RTE_HASH_BUCKET_ENTRIES) ||
> + (params->name == NULL) ||
> (params->key_len == 0)) {
> rte_errno = EINVAL;
> RTE_LOG(ERR, HASH, "rte_hash_create has invalid
> parameters\n");
> --
> 2.25.1
>
> --------------------------------------------------------------
> Intel Research and Development Ireland Limited
> Registered in Ireland
> Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
> Registered Number: 308263
>
>
> This e-mail and any attachments may contain confidential material for the
> sole
> use of the intended recipient(s). Any review or distribution by others is
> strictly prohibited. If you are not the intended recipient, please contact
> the
> sender and delete all copies.
>
>
--
Regards,
Vladimir
[-- Attachment #2: Type: text/html, Size: 2809 bytes --]
prev parent reply other threads:[~2024-03-01 17:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 15:26 Conor Fogarty
2024-03-01 17:16 ` Vladimir Medvedkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANDrEHkZBADvofiwVZgy6zhigxD05gDTXp1VxsLo93okvgmZ_A@mail.gmail.com \
--to=medvedkinv@gmail.com \
--cc=conor.fogarty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).