From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 53A63CFD8 for ; Fri, 27 Apr 2018 19:51:05 +0200 (CEST) Received: by mail-qt0-f196.google.com with SMTP id j42-v6so3338312qtj.12 for ; Fri, 27 Apr 2018 10:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gFM8z2Q/zJUN0nv4cvSGTrXlD+uhU8LSXEdz5MReNks=; b=RPNmFqpLNcXsVMU8VwIJyH0zTMtxrgGLYOgSzktFWxzK0rkIScC6h/5EABtOgtmQpE dy5niSGI3cK3vaqSmZsKEo7i+0MlXb3iooDlXuxn6Xs3HUCzABxFcWJW0Zp/5isEO2Ar JtjSMdbTix5tnurnTvtI2nX/F8559dmSrneegQU0hGj877nnD5niIc7SfYMkpDymlWjX F1N++Iv5nILvy/IqhYBgQTeCQtl1iPW7XBuw9ax9FiPxSL/VaJX/WemvJPjSwnoMakrh uTnyXlvWLbf8FbV4IOIFYDXp0/81h9i4zkUVt8ITufAH77Toc92bv8zEf8x2dXiiMjsX q3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gFM8z2Q/zJUN0nv4cvSGTrXlD+uhU8LSXEdz5MReNks=; b=YBoyXuYXaDPQqC8xDeSOSIp/xJBPXwol4gMJx1c91kTnTUGovuL70dCbmWTCoKmrB8 r2lLcdSDCdeVYSGU7K/Qf2OHnieXvp4gIxZFIPDNU6jOBbweCyJ7sKG8YwebiennMoEe ftSkI99w8QxjvuI1d+lTvTrXqjMuJtYJepVHsdTuvzSysZiq0aepbotiFgYDx5VVJypt Fz42jxGXfPTO3CmcGuEWqBPAMWaEeFLWOGgJZJnr1wAshYYfIk/3Uq4BAFJQmBF0fjgp P5+QSyWBe5z+1p4YhvptphQ7NnFjbcTY88GKgh+t+UgzkfzCKQICf5eg62Ikest18vJM SVEg== X-Gm-Message-State: ALQs6tAr7eZLjUOIOwM1c7gs/uRId3zSKQ6eT5UjQ5ZHjEAlA+HdtAYf mSANVvQYAw7zGa7pUMyJdvULkelTf7tcFJ2c1qc= X-Google-Smtp-Source: AB8JxZoJG9rxZmC55/5f8QiHsCrFWW+1mcoK1qMSPxLrP3oxkAsFJuNAET3y738N4TMnZEdex7Kqz+KW3AUw8djmxAA= X-Received: by 2002:a0c:e002:: with SMTP id j2-v6mr3007643qvk.62.1524851464798; Fri, 27 Apr 2018 10:51:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.200.37.27 with HTTP; Fri, 27 Apr 2018 10:51:04 -0700 (PDT) In-Reply-To: <20180427135129.GA89888@bricha3-MOBL.ger.corp.intel.com> References: <20180418210521.277384-1-bruce.richardson@intel.com> <20180427134928.4716-1-bruce.richardson@intel.com> <20180427134928.4716-3-bruce.richardson@intel.com> <20180427135129.GA89888@bricha3-MOBL.ger.corp.intel.com> From: Vladimir Medvedkin Date: Fri, 27 Apr 2018 20:51:04 +0300 Message-ID: To: Bruce Richardson Cc: dev@dpdk.org, hemant.agrawal@nxp.com, bluca@debian.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 17:51:05 -0000 Hi, 2018-04-27 16:51 GMT+03:00 Bruce Richardson : > On Fri, Apr 27, 2018 at 02:49:27PM +0100, Bruce Richardson wrote: > > When we check for libbsd we were just checking for the library itself. > > However, on some distros, e.g. CentOS, libbsd will be found even though > > it's not usable by DPDK as it's missing the string header. Therefore we > > should check for both the library and the header file. > > > > Fixes: 5364de644a4b ("eal: support strlcpy function") > > > > Sorry, forgot to add: > > Reported-by: Vladimir Medvedkin > > > Signed-off-by: Bruce Richarson > > --- > > config/meson.build | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/config/meson.build b/config/meson.build > > index 5815b5602..2179c689c 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -43,7 +43,8 @@ if numa_dep.found() and cc.has_header('numaif.h') > > endif > > > > # check for strlcpy > > -if host_machine.system() == 'linux' and cc.find_library('bsd', > required: false).found() > > +if host_machine.system() == 'linux' and cc.find_library('bsd', > > + required: false).found() and cc.has_header('bsd/string.h') > > dpdk_conf.set('RTE_USE_LIBBSD', 1) > > add_project_link_arguments('-lbsd', language: 'c') > > dpdk_extra_ldflags += '-lbsd' > > -- > > 2.14.3 > > > Acked-by: Vladimir Medvedkin -- Regards, Vladimir