From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8FA35A04B5; Wed, 30 Sep 2020 13:06:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C063C1D67D; Wed, 30 Sep 2020 13:06:33 +0200 (CEST) Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by dpdk.org (Postfix) with ESMTP id 9D4E51D673 for ; Wed, 30 Sep 2020 13:06:32 +0200 (CEST) Received: by mail-ej1-f67.google.com with SMTP id j11so2216993ejk.0 for ; Wed, 30 Sep 2020 04:06:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OLnoZlsICa6lTWMpp1i68KjprV5Ux61p7wQiVJAu2ok=; b=UBVBfBc28AIeYKlOJQRtfIlX3MEO6kVCfmna/z5DtERW4BNvsMT8HqsB+LzUaJRfKH bfIZ2uKv9f0DLe0nTEUqrb8ccfT+sQwJpMVkEkNf3fbYXzZbsI10nn+10kd/zsA7He9y 4mV2BIGKcDVj3O0wwaFnIwfzoK4Dpt+VBiaCBkLLIwEEqiLhiSQjL7MsL0g+/63o5tom nCi6rY4IYMMQYPsgmeip2+UzGKpA/lgL7NxxIMiJ8MKHuhGCGpK7lbydztEFfcSxAqyU 4e7ZrSckQCU0my60tzlIe6gvcjhfAWJ9gu+35M5u0wLlNuKulFh4Km/4q2lEien5S2Lh +x5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OLnoZlsICa6lTWMpp1i68KjprV5Ux61p7wQiVJAu2ok=; b=D9O8xYJjAHl9zogfSDt53L3F+WEns3do35rHqnjTPW1lzBEHbps1T7I/HMlxvNPsMI JSHnc+cjP4piMIOIhEEl5ejRWb1NHqx1QFQXn5DoIgUJYyCjwX9Of1izDGl0ORICFnGY 3xfddZwayWIn6z/ePRy7d5EobQ0ang32TAbcOun9ao11Mu9/4FIGcVFL/V19osjHUfmA bN461PYDCUQ4BsXHfp7dsLiYIcuWOzmjfwQWMbxFGAv13WjwMN92wBPcejbpzMQKUu+h PLTsF6DEh9YGGXilFLjAFTnBz/nfrVMYEnc+SzT96zF+TCRbnyi2/K3cHz3Pcd8tY5l0 LFeA== X-Gm-Message-State: AOAM532eon0gv0gDRk80H85XecyKWOsDLlG3JjRmLcsKH48ZQRYa0hQD a0tjcM+NKbIWH7AEuFRtHJrWCATNuTQgOF4z8TAJeF0XvVXQDw== X-Google-Smtp-Source: ABdhPJzXi5T6VRjzA5PaQhxwTzGlenvImNHpH+G4aRR9w77GSWDa+AWX5DMiwk59o5NUqIbfb4nYmXm5kJsSTxW6lcc= X-Received: by 2002:a17:906:2454:: with SMTP id a20mr2189712ejb.294.1601463991304; Wed, 30 Sep 2020 04:06:31 -0700 (PDT) MIME-Version: 1.0 References: <10778727.YoOYBErh3j@thomas> In-Reply-To: <10778727.YoOYBErh3j@thomas> From: Vladimir Medvedkin Date: Wed, 30 Sep 2020 12:06:20 +0100 Message-ID: To: Thomas Monjalon Cc: Vladimir Medvedkin , dev@dpdk.org, david.marchand@redhat.com, jerinj@marvell.com, mdr@ashroe.eu, "Ananyev, Konstantin" , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v7 2/8] fib: make lookup function type configurable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Thomas, =D1=87=D1=82, 16 =D0=B8=D1=8E=D0=BB. 2020 =D0=B3. =D0=B2 15:32, Thomas Monj= alon : > 13/07/2020 13:56, Vladimir Medvedkin: > > Add type argument to dir24_8_get_lookup_fn() > > Now it supports 3 different lookup implementations: > > RTE_FIB_DIR24_8_SCALAR_MACRO > > RTE_FIB_DIR24_8_SCALAR_INLINE > > RTE_FIB_DIR24_8_SCALAR_UNI > > > > Add new rte_fib_set_lookup_fn() - user can change lookup > > function type runtime. > > > > Signed-off-by: Vladimir Medvedkin > [...] > > --- a/lib/librte_fib/rte_fib.h > > +++ b/lib/librte_fib/rte_fib.h > > +enum rte_fib_dir24_8_lookup_type { > > + RTE_FIB_DIR24_8_SCALAR_MACRO, > > + RTE_FIB_DIR24_8_SCALAR_INLINE, > > + RTE_FIB_DIR24_8_SCALAR_UNI > > +}; > > Doxygen missing. > > [...] > > +/** > > + * Set lookup function based on type > > + * > > + * @param fib > > + * FIB object handle > > + * @param type > > + * type of lookup function > > + * > > + * @return > > + * -EINVAL on failure > > + * 0 on success > > + */ > > +__rte_experimental > > +int > > +rte_fib_set_lookup_fn(struct rte_fib *fib, > > + enum rte_fib_dir24_8_lookup_type type); > > I think the types deserve to be documented, > explaining why using one or the other. > I'm going to get rid of extra lookup types in next releases, so there will be only well understandable SCALAR and VECTOR types > > --=20 Regards, Vladimir