From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9925BA00C4; Tue, 26 Jul 2022 13:09:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B0C340DDD; Tue, 26 Jul 2022 13:09:18 +0200 (CEST) Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by mails.dpdk.org (Postfix) with ESMTP id 7141240695 for ; Tue, 26 Jul 2022 13:09:17 +0200 (CEST) Received: by mail-lj1-f171.google.com with SMTP id p22so6308244lji.10 for ; Tue, 26 Jul 2022 04:09:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/Sf+WIYQIzKkOKTIXX0dcvUGUnOR+XAfa1v4EB5Npyw=; b=suqmZeefwXCLUdmHlHWEJoYK1Z+FDU9MylNVSnTP7rT0xBK1fLC9Lc2wkWJ819JnJ1 alyY3vp1v+s2pqDXupyYRGnv9ImlXqJ3SFDeTS3ExKAmIn01e1fBuqND+KHr06zxZr8W NzD+E6YYQt1NTrF+wXJqniPExM4dlF7mZMJFZtLkdaqYyDr/zaclhZbC2zdjQ2wA0FWU vqp56yJzYXVcQaUhwjR1av3BSBeeuNZC5uHAWLuSX5XHtDIeq+3cgxwBY+ZbJGYHx38L dqvl3d5VySb2O11OZ+81vWkTJ4LBefwBZqxn5BRln7kSMGjpKs8HAh80pymD9kyGVaSn 2wAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/Sf+WIYQIzKkOKTIXX0dcvUGUnOR+XAfa1v4EB5Npyw=; b=NdptThfdK3POfhnexniy5FP1bfv+23/4z3bRk6suaznqYnVHMsefsnIx2OPbQmd6fg //+56rHCgtv1xHGiAtJScGHDd+akVH/ZJWimVj3fMur28Tozw3VqC2+lgo34T7EVtnHR pcqtvs4uBwdM3ZOpUf/J+Ac0wnRYr4/2P9BHbd0gWOTyDvjTdlyGQos3y3VWb8EFIynb gh6eRW9TgChpbu5G90tgqmu+AU90l9vlek6Fo4bTN1ZfUUpWtMc7M0/xTdiQ6C2vVZF+ mMSw1KfaSMZoBspph3Qfy0pclYbm52qRf0eyqg3DqBCXrS8tUbqDGyIMC9ZXxRNHTC5L sK3w== X-Gm-Message-State: AJIora+DbVmXQ9heRPYb90J1OZN71a1GKhAUqIVSTHCHNmrbSJqj7zOL BqOsASw0BlAfAIGu/X4FOm1h5/P8PAOF1l4FLQgGJHIRY5HpmWpV X-Google-Smtp-Source: AGRyM1uvPDAagqG2Ew8YscM1pnM3mfJqTgnSnoBHv8vcfLEDWJRedpJmSeest/wWsd2D/MCSjJ+UeTObNDz2z5oD01c= X-Received: by 2002:a05:651c:1584:b0:25d:c6ad:6237 with SMTP id h4-20020a05651c158400b0025dc6ad6237mr5664793ljq.509.1658833756816; Tue, 26 Jul 2022 04:09:16 -0700 (PDT) MIME-Version: 1.0 References: <20220321142547.82966-1-huzaifa.rahman@emumba.com> <20220322093615.260856-1-huzaifa.rahman@emumba.com> In-Reply-To: From: Huzaifa Rahman Date: Tue, 26 Jul 2022 16:09:06 +0500 Message-ID: Subject: Re: [PATCH v2] ethtool: added help command to list all available To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: multipart/alternative; boundary="000000000000d1230105e4b35437" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000d1230105e4b35437 Content-Type: text/plain; charset="UTF-8" Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Mon, May 30, 2022 at 3:42 PM Ferruh Yigit wrote: > On 5/27/2022 6:14 AM, Huzaifa Rahman wrote: > > [CAUTION: External Email] > > Hi, > > > > The following tests are failing but my patch is not related to anything > > related to these. Please re-run the tests. > > > > Failed Tests: > > - mtu_update > > - scatter > > > > Hi Huzaifa, > > Agree, it looks unrelated, I will trigger the test again, can please > check in ~10 mins. > > > > > Thanks, > > > > Huzaifa > > > > > > > > On Tue, Mar 22, 2022 at 2:36 PM huzaifa.rahman > > > wrote: > > > > Help command is not available for ethtool example. It is needed so > user > > can see all the available commands directly from the command line > along > > with the formats. > > > > Signed-off-by: huzaifa.rahman > > > > --- > > doc/guides/sample_app_ug/ethtool.rst | 1 + > > examples/ethtool/ethtool-app/ethapp.c | 38 > +++++++++++++++++++++++++++ > > examples/ethtool/ethtool-app/ethapp.h | 1 + > > 3 files changed, 40 insertions(+) > > > > <...> > --000000000000d1230105e4b35437 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Is there any other work/changes required for this p= atch to be submitted?

Thanks

On Mon, May 30, 2022 at 3:42 PM Ferruh Yigit <ferruh.yigit@xilinx.com> wrote= :
On 5/27/2022 6:14 AM, Huzaifa Rahman wrote:
> [CAUTION: External Email]
> Hi,
>
> The following tests are failing but my patch is not related to anythin= g
> related to these. Please re-run the tests.
>
> Failed Tests:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0- mtu_update
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0- scatter
>

Hi Huzaifa,

Agree, it looks unrelated, I will trigger the test again, can please
check in ~10 mins.

>
> Thanks,
>
> Huzaifa
>
>
>
> On Tue, Mar 22, 2022 at 2:36 PM huzaifa.rahman
> <huzaifa.rahman@emumba.com <mailto:huzaifa.rahman@emumba.com>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0Help command is not available for ethtool example. = It is needed so user
>=C2=A0 =C2=A0 =C2=A0can see all the available commands directly from th= e command line along
>=C2=A0 =C2=A0 =C2=A0with the formats.
>
>=C2=A0 =C2=A0 =C2=A0Signed-off-by: huzaifa.rahman <= huzaifa.rahman@emumba.com
>=C2=A0 =C2=A0 =C2=A0<mailto:huzaifa.rahman@emumba.c= om>>
>=C2=A0 =C2=A0 =C2=A0---
>=C2=A0 =C2=A0 =C2=A0 =C2=A0doc/guides/sample_app_ug/ethtool.rst=C2=A0 |= =C2=A0 1 +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0examples/ethtool/ethtool-app/ethapp.c | 38 += ++++++++++++++++++++++++++
>=C2=A0 =C2=A0 =C2=A0 =C2=A0examples/ethtool/ethtool-app/ethapp.h |=C2= =A0 1 +
>=C2=A0 =C2=A0 =C2=A0 =C2=A03 files changed, 40 insertions(+)
>

<...>
--000000000000d1230105e4b35437--