Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues

[Huzaifa Rahman <huzaifa.rahman@emumba.com>]

[-- Attachment #1: Type: text/plain, Size: 1520 bytes --]

Hi,

Is there any other work/changes required for this patch to be submitted?

Thanks


On Tue, Oct 4, 2022 at 7:53 PM Andrew Rybchenko <
andrew.rybchenko@oktetlabs.ru> wrote:

> On 8/8/22 13:39, Joyce Kong wrote:
> > Hi Huzaifa,
> >
> > This patch looks good to me.
> > And would you please help review my memif patches?
> >
> https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/
> >
> > Thanks,
> > Joyce
> >
> >> -----Original Message-----
> >> From: huzaifa.rahman <huzaifa.rahman@emumba.com>
> >> Sent: Tuesday, July 26, 2022 6:16 PM
> >> To: jgrajcia@cisco.com
> >> Cc: dev@dpdk.org; huzaifa.rahman <huzaifa.rahman@emumba.com>
> >> Subject: [PATCH] memif: memif driver does not crashes when there's
> >> different N of TX and RX queues
> > net/memif: fix memif crash with different Tx Rx queues
> >
> >>
> >> Bugzilla ID: 734
> >>
> >> there's a bug in memif_stats_get() function due to confusion between C2S
> >> (client->server) and S2C (server->client) rings, causing a crash if
> there's a
> >> different number of RX and TX queues.
> >>
> >> this is fixed by selectiing the correct rings for RX and TX i.e for RX,
> S2C rings
> >> are selected and for TX, C2S rings are selected.
> >>
> > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD")
> > Cc: stable@dpdk.org
> >
> >> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
> > Reviewed-by: Joyce Kong <joyce.kong@arm.com>
>
> Fixed above on applying.
>
> Applied to dpdk-next-net/main, thanks.
>
>
>

[-- Attachment #2: Type: text/html, Size: 2862 bytes --]