From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AC91A04FD; Thu, 10 Nov 2022 11:03:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CF9040150; Thu, 10 Nov 2022 11:03:02 +0100 (CET) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) by mails.dpdk.org (Postfix) with ESMTP id 0493A400EF for ; Thu, 10 Nov 2022 11:03:01 +0100 (CET) Received: by mail-lf1-f43.google.com with SMTP id g7so2221599lfv.5 for ; Thu, 10 Nov 2022 02:03:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emumba-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=CVRpT4eP+A9K2ySiTayff2Kbt8lOoj1fvF+R+e3CkDA=; b=V4v2khi7Yq4X8XyoV24wvtTPpRBdk9bvW/LpSJphAuw2LMPSV02Lu1K4u+k2wOcFtg T4TmAXDvmAoNU/sk4Gs5B4rQvotchl6Tc153ErbfaOJzOmCO5W+OoWqSrla7tu1g9cTA lB6RtIqBfKMmznrifoMSHMjV5IYq3kpJJCBCbdx0PFiF77rzp8tt0FtN9qd+zoT5DrNK a/0WTGXU+9wqdvJ+csKruggKj6MZhy1r8eetM/in28bD5AKFUORdzSNiRoqF2u/u3pqn +eA+3rGCDAjG/rl4liPc3DWOqMfNhr/MBqKRcoTzm6+iaL77rjR38U7Xb5plMkh1rTlY t8rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=CVRpT4eP+A9K2ySiTayff2Kbt8lOoj1fvF+R+e3CkDA=; b=SO98wYyVzsRGXEuixD3tTEYw1gfrWZFudxqjWwPLUDYbXCL3y+9uY+ofzncpIAlCwI vwD+9cWkajcg+yP/eUGcAoKW7ULAXm3KINjc389VqYOhZpklUhpRQwAU0DSgI4dVq8bN e91Nxle0raEKJn35YPiS8NU2NpXI9rSZcMdClo2eXERZXsCqoC8D5H/FiZPja5gnJlnp NYkTioUEacbuGaKEs03NQFklgxEZXR6y6ZXknZc9WlR1nXe7B6aA3Wj42RZH6ARPB+6T THF+JqhpSg2WJWl6q6NNbcqWT+kkgX6/11qp0cadHrNmnuhZMNDHudVyVhtFUSRaVqLS mDDA== X-Gm-Message-State: ACrzQf0d8oJ8OXupOsQavIhk2sef7b0K7DZVUgM1ggJJ2Y5o8BldQ+Iu UQNDr8IMU5/ugNACZrwNSSg7KHyIqo2nOhRNV1hfJw== X-Google-Smtp-Source: AMsMyM76QRVzXUVnsgC9Xzjz3TgCJX6lsNaiQUiCfOMIS92lUFi2h9SdjEBeUexVT7pPLOXoSroS5gjliuniz5GC3z8= X-Received: by 2002:a05:6512:1592:b0:4a2:b56c:388e with SMTP id bp18-20020a056512159200b004a2b56c388emr1279949lfb.145.1668074580454; Thu, 10 Nov 2022 02:03:00 -0800 (PST) MIME-Version: 1.0 References: <20220726101628.2118564-1-huzaifa.rahman@emumba.com> In-Reply-To: From: Huzaifa Rahman Date: Thu, 10 Nov 2022 15:02:49 +0500 Message-ID: Subject: Re: [PATCH] memif: memif driver does not crashes when there's different N of TX and RX queues To: Andrew Rybchenko Cc: Joyce Kong , "jgrajcia@cisco.com" , "dev@dpdk.org" Content-Type: multipart/alternative; boundary="000000000000d3c56205ed1ae087" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --000000000000d3c56205ed1ae087 Content-Type: text/plain; charset="UTF-8" Hi, Is there any other work/changes required for this patch to be submitted? Thanks On Tue, Oct 4, 2022 at 7:53 PM Andrew Rybchenko < andrew.rybchenko@oktetlabs.ru> wrote: > On 8/8/22 13:39, Joyce Kong wrote: > > Hi Huzaifa, > > > > This patch looks good to me. > > And would you please help review my memif patches? > > > https://patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@arm.com/ > > > > Thanks, > > Joyce > > > >> -----Original Message----- > >> From: huzaifa.rahman > >> Sent: Tuesday, July 26, 2022 6:16 PM > >> To: jgrajcia@cisco.com > >> Cc: dev@dpdk.org; huzaifa.rahman > >> Subject: [PATCH] memif: memif driver does not crashes when there's > >> different N of TX and RX queues > > net/memif: fix memif crash with different Tx Rx queues > > > >> > >> Bugzilla ID: 734 > >> > >> there's a bug in memif_stats_get() function due to confusion between C2S > >> (client->server) and S2C (server->client) rings, causing a crash if > there's a > >> different number of RX and TX queues. > >> > >> this is fixed by selectiing the correct rings for RX and TX i.e for RX, > S2C rings > >> are selected and for TX, C2S rings are selected. > >> > > Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD") > > Cc: stable@dpdk.org > > > >> Signed-off-by: huzaifa.rahman > > Reviewed-by: Joyce Kong > > Fixed above on applying. > > Applied to dpdk-next-net/main, thanks. > > > --000000000000d3c56205ed1ae087 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hi,

Is there any other work/changes req= uired for this patch to be submitted?
Thanks

On Tu= e, Oct 4, 2022 at 7:53 PM Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
=
On 8/8/22 13:39, Joyce Ko= ng wrote:
> Hi Huzaifa,
>
> This patch looks good to me.
> And would you please help review my memif patches?
> https:/= /patches.dpdk.org/project/dpdk/cover/20220701102815.1444223-1-joyce.kong@ar= m.com/
>
> Thanks,
> Joyce
>
>> -----Original Message-----
>> From: huzaifa.rahman <huzaifa.rahman@emumba.com>
>> Sent: Tuesday, July 26, 2022 6:16 PM
>> To: jgrajc= ia@cisco.com
>> Cc: dev@dpdk.org= ; huzaifa.rahman <huzaifa.rahman@emumba.com>
>> Subject: [PATCH] memif: memif driver does not crashes when there&#= 39;s
>> different N of TX and RX queues
> net/memif: fix memif crash with different Tx Rx queues
>
>>
>> Bugzilla ID: 734
>>
>> there's a bug in memif_stats_get() function due to confusion b= etween C2S
>> (client->server) and S2C (server->client) rings, causing a c= rash if there's a
>> different number of RX and TX queues.
>>
>> this is fixed by selectiing the correct rings for RX and TX i.e fo= r RX, S2C rings
>> are selected and for TX, C2S rings are selected.
>>
> Fixes: 09c7e63a71f9 ("net/memif: introduce memory interface PMD&q= uot;)
> Cc: stable@dpdk.o= rg
>
>> Signed-off-by: huzaifa.rahman <huzaifa.rahman@emumba.com>
> Reviewed-by: Joyce Kong <joyce.kong@arm.com>

Fixed above on applying.

Applied to dpdk-next-net/main, thanks.


--000000000000d3c56205ed1ae087--