From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f49.google.com (mail-vk0-f49.google.com [209.85.213.49]) by dpdk.org (Postfix) with ESMTP id 3D7506947 for ; Tue, 5 Jul 2016 19:03:04 +0200 (CEST) Received: by mail-vk0-f49.google.com with SMTP id m127so213092298vkb.3 for ; Tue, 05 Jul 2016 10:03:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7syGCanZ8OXfN74dJgBmutDDgwILupgHWSB3Y36Ftak=; b=o/0ApczuFAqN4spHMsA6xRXzm4/HeqGoEVt4hZMyAlTFiv4jYicI6joDp5DSrPHk4a OIq+IgqO+0tH5SjOeBjuoTeuDduUyOy2DLntiZ5re7mHjWQORMkvE8Uh4fXQBZYuIgzF x69qJ9kBenqSJQRVFCHFa5HWj4T9CotWP3EbyQOJ61dlCGe6ZRXdlurRUX8o+ZJgIzmx 4+r8+sLeZBXRzA/uTou+v/JqaQy/KIHeBkK1Itt8irN0b2/M7qX0apvN0NFS9LZ7CqMA psWT/CTzYfpgO57562+Mj944szdLO5bf+aGvce55eW/LuLNdy2nNl5B3CbKc+e9CxGeo E3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7syGCanZ8OXfN74dJgBmutDDgwILupgHWSB3Y36Ftak=; b=b92aoG95gN97cOZ66MavNeViJwtod9ZMx8c4UJoKLSprzvsaD94y9e5NR6LECGfF4Y WjVZ/e3tBdqBuQfd6qXWH4LSRkNHp1ZUm2Jwh8Y7uywD1zORFK7hHtsWX0b+dImHpFk/ vCgPtsaRscyo9vQObGoxAOs0+R3qm4dQA+9QRu0DPgNBJLNyH911EQH4hNDLOuoKIBuw b1V/DWTFFo3DQXgfQeKnU3BkgZCh2Hkq7UmQLx/OGH8yYBJWARmd8WkVcXBkwBVCngk2 6ZFPOv73999BJCn9bGcIqcLb+j5eg7/FTNtYLPtlWMIUItlEYVyed99fKGf618tkEXGq rsgQ== X-Gm-Message-State: ALyK8tKmgWuFb8/q1WpqhIjpeVqg41Ing33pYEABQP+VrZhbpiIg+r4AaEm2jDhzKmuIQOqeBOlcXQh/VT+fCQ== X-Received: by 10.31.98.135 with SMTP id w129mr6811922vkb.106.1467738183705; Tue, 05 Jul 2016 10:03:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.36.54 with HTTP; Tue, 5 Jul 2016 10:03:03 -0700 (PDT) In-Reply-To: <20160705161918.GC26504@bricha3-MOBL3> References: <1466510763-19569-6-git-send-email-jan@semihalf.com> <1467299099-32498-1-git-send-email-jan@semihalf.com> <1467299099-32498-7-git-send-email-jan@semihalf.com> <577B7539.3000007@intel.com> <20160705161918.GC26504@bricha3-MOBL3> From: =?UTF-8?Q?Jan_M=C4=99dala?= Date: Tue, 5 Jul 2016 19:03:03 +0200 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Alexander Matushevsky , Jakub Palider Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 17:03:04 -0000 Bruce, That'd be very kind of you if you can fix trailing zeros. This patch Fixes: b5b8cd9 ("ena: update of ENA communication layer") Regards, Jan 2016-07-05 18:19 GMT+02:00 Bruce Richardson : > On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > > On 6/30/2016 4:04 PM, Jan Medala wrote: > > > Signed-off-by: Alexander Matushevsky > > > Signed-off-by: Jakub Palider > > > Signed-off-by: Jan Medala > > > > The compilation error to fix is [1], it may be good to add what to fix > > into commit log. > > > > [1] > > == Build drivers/net/ena > > CC ena_ethdev.o > > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): error > > #188: enumerated type mixed with another type > > struct ena_com_create_io_ctx ctx = { 0 }; > > ^ > > > > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): error > > #188: enumerated type mixed with another type > > struct ena_com_create_io_ctx ctx = { 0 }; > > ^ > > ... > > > > > --- a/drivers/net/ena/ena_ethdev.c > > > +++ b/drivers/net/ena/ena_ethdev.c > > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_dev > *dev, > > > __rte_unused unsigned int socket_id, > > > __rte_unused const struct rte_eth_txconf > *tx_conf) > > > { > > > - struct ena_com_create_io_ctx ctx = { 0 }; > > > + struct ena_com_create_io_ctx ctx = > > > + /* policy set to _HOST just to satisfy icc compiler */ > > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST, > > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 }; > > > > Trailing "0" are not required, compiler will take care of them. > > > Jan, > > any comment on this? If you want, I can remove the trailing zeros on apply > rather than needing a V3. Is that ok? > > Again a fixes line is missing, can you supply one. > > /Bruce >