From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <jan@semihalf.com>
Received: from mail-vk0-f47.google.com (mail-vk0-f47.google.com
 [209.85.213.47]) by dpdk.org (Postfix) with ESMTP id 93C9F5699
 for <dev@dpdk.org>; Thu, 17 Mar 2016 14:48:01 +0100 (CET)
Received: by mail-vk0-f47.google.com with SMTP id q138so10594697vkb.3
 for <dev@dpdk.org>; Thu, 17 Mar 2016 06:48:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=semihalf-com.20150623.gappssmtp.com; s=20150623;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc; bh=1Ni2kBN3JsgS/f4IpHpOvJLHgTqoBukP9WR4kTvU4oY=;
 b=tdHAjHNXvTLDY20+V5rSDddrcFIEeqXny7eOJ3G9bIhRCmIRW5q6/BVm6ppcRtb2Rd
 42euwbu2Av0VROYbLdM0GOUcYkVF8NGcyr4ebnBVzmSTWP6WALQeEcYKAhMCd3IaT0HJ
 1hfFuNM2Uud0pwc5lyh+mcAlX9Hlb0mEtxUQeuaG0P4s0AuHF4McZJ0odmRDa5sMrXii
 gWYHC/gE+EhfQpau8R/ocpvYor6vxucuHAmoEDUHQIMxlZQNXQJkryOKh82bTQvlEeRT
 PJnj47CG2KLhOzfp9f0nd3U4dnvZ1x/FbbLKahwrgC18jJXlhtjKxfvaK4QDdLtGz+ty
 ZdlA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:date
 :message-id:subject:from:to:cc;
 bh=1Ni2kBN3JsgS/f4IpHpOvJLHgTqoBukP9WR4kTvU4oY=;
 b=IhME1YVk1Xidh/du5nujHEW5oWJWxY/pXaYbX6pei49BRfY+rW46ZZCc8GX914QKL7
 cUQhXwPl7b3tAxVKo65YxVgzEqLmZammZDrNkctf2xFpYOhGns7nzCS17ZDqulr0thsK
 cYWAwQBMaT0Tp/XGw4nNHzOQqc/E9tRXnKU3qPBwp8EglrgxPMdNTSpyegc/SzZygXbJ
 dRktOhFtynqdfE9hKZ261v+2mx6RjkbCl8Vp41TgC4Fe1myD6vZ+Qm/JYvPBKHGPE7YG
 Utz8pQB/C32vuWj9+3mWhoFQYrhBOw7CpKmwlRVIB1sQXf60mXaYMWFyghxUZmz2TnL8
 r1vQ==
X-Gm-Message-State: AD7BkJKV/mFdcaIe6N77KD5QB+R184CrEsbuFxnFAfrnAH5R7ZfgPzGY+BZXMSTtGhz/jS3lE8OtVjGE/Zd+EQ==
MIME-Version: 1.0
X-Received: by 10.31.6.130 with SMTP id 124mr10671208vkg.106.1458222481088;
 Thu, 17 Mar 2016 06:48:01 -0700 (PDT)
Received: by 10.176.2.151 with HTTP; Thu, 17 Mar 2016 06:48:01 -0700 (PDT)
In-Reply-To: <20160316143407.GA10288@bricha3-MOBL3>
References: <1458052810-18418-1-git-send-email-jan@semihalf.com>
 <1458052810-18418-5-git-send-email-jan@semihalf.com>
 <20160316143407.GA10288@bricha3-MOBL3>
Date: Thu, 17 Mar 2016 14:48:01 +0100
Message-ID: <CANw_3ZeANtJCKQf+mvY_wgNM_p8C+3H8D8sB--ZAOo4+mJDqnA@mail.gmail.com>
From: =?UTF-8?Q?Jan_M=C4=99dala?= <jan@semihalf.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Alexander Matushevsky <matua@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>, Jakub Palider <jpa@semihalf.com>
Content-Type: text/plain; charset=UTF-8
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v7 4/4] ena: DPDK polling-mode driver for
 Amazon Elastic Network Adapters (ENA)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2016 13:48:01 -0000

>
> >  #
> > +# Compile burst-oriented Amazon ENA PMD driver
> > +#
> > +CONFIG_RTE_LIBRTE_ENA_PMD=y
> > +CONFIG_RTE_LIBRTE_ENA_DEBUG_INIT=y
>
> Do you really want initialization debuggin to be on by default? Normally,
> we
> keep all debug options disabled.

This is actually error logging, so it's silent for user until there is
something wrong with initialization.
Do you want me to rename it to point more accurately it's role?

  Jan