From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f41.google.com (mail-vk0-f41.google.com [209.85.213.41]) by dpdk.org (Postfix) with ESMTP id 15BEB6004 for ; Wed, 6 Jul 2016 10:50:31 +0200 (CEST) Received: by mail-vk0-f41.google.com with SMTP id k68so209319682vkb.0 for ; Wed, 06 Jul 2016 01:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cT9O/iASR9EHp2KJj/CGpXa4p12LfON5s5kYxdH3kH8=; b=zdvvfZcdNUuQ/MdBb9XI2pH1SRtTnufeFft0LsLDnlWINNwfWpgKLvryec0+us07a3 iAVAXjNUr1ssWmJ1uWjZIeOOfa4GYG779KwH0JejXFvpsHCSvYwTnBTuj1s2AVwfPufM 4PkRKhToS0uWH1UbuvyI9DT/0uh2ftQkVKoqfCxcC14CU+xqvXAPSgayX5LuwaEIII/B rP4PIokbN4Jt876QGMINyXyOfRhFeKOB9gGTHnVLNSMTh3ueRVP/r67To1NeyuYD7R3D wCJJLOKJsl53YqQk1ufxKRFUh0PKYnO0zuPpXVRNjLoFPXJ5zDdHJUH4Qx4cSYdwMUUx tDFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cT9O/iASR9EHp2KJj/CGpXa4p12LfON5s5kYxdH3kH8=; b=S4rDUw+E7VtnQDYITt9HmfVzBMhC5lC9PNMt3bFHCaRzXt8SsOFpAZI8rmeOQdjnOr v8QbgVdTnbiPdmWO+YmobB5Bx4qluo4xSL5kH00ZhMqAM7B5EvijCeqUTsn/RPr8NDPx GsxVuKO4hfG7nySF3ccAP4hBKE4Pj/U2OcL+iq9O1RlVypSFmVw6HZceGUVPgkh9465/ sy3IM1sukMVqAfwC3TkUUEitXp9thJMfcksJvwCqhodwdsUZceZyXcmO70E0lkyHHQAk JFOe/CeHFOXI7lyC7M7ePxQZEo3iUNsvMcOjZ940yztNudMwk/JAgc4JlMJvzfMRB0Ud sGMA== X-Gm-Message-State: ALyK8tJSRP746ufAURHNnPdcJBrEWUJ9TZUV6zqKUyotb1WyJu6zPSUDLWrUD0r8cX7Wx/5uvMVhikegYjfALA== X-Received: by 10.31.189.20 with SMTP id n20mr9549242vkf.24.1467795030547; Wed, 06 Jul 2016 01:50:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.36.54 with HTTP; Wed, 6 Jul 2016 01:50:29 -0700 (PDT) In-Reply-To: <20160706081449.GB17404@bricha3-MOBL3> References: <1466510763-19569-6-git-send-email-jan@semihalf.com> <1467299099-32498-1-git-send-email-jan@semihalf.com> <1467299099-32498-7-git-send-email-jan@semihalf.com> <577B7539.3000007@intel.com> <20160705161918.GC26504@bricha3-MOBL3> <20160706081449.GB17404@bricha3-MOBL3> From: =?UTF-8?Q?Jan_M=C4=99dala?= Date: Wed, 6 Jul 2016 10:50:29 +0200 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Alexander Matushevsky , Jakub Palider Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Jul 2016 08:50:31 -0000 There are no obstacles. We first produced patches 1-5, then tested on different compilers so patch no. 6 was made. Thank you Bruce for support! I'm still learning DPDK's submission/upstream process so all comments and gained knowledge will easier future patches. Jan 2016-07-06 10:14 GMT+02:00 Bruce Richardson : > On Tue, Jul 05, 2016 at 07:10:54PM +0200, Jan M=C4=99dala wrote: > > Let me point it this way: > > =E2=80=8B=E2=80=8BThis patch fixes: [dpdk-dev,v3,1/6] ena: update of EN= A communication > layer > > > > Jan > > Since it fixes another patch in the same series, I think the two patches > could > actually be merged, rather than adding code with a known issue and later > having > a two-line(ish) patch to fix it. > I will merge the two on apply, if there is no objection. > > /Bruce > > > > > 2016-07-05 19:04 GMT+02:00 Jan M=C4=99dala : > > > > > Uhm, wait, I think that sha is wrong, please let me check it double > time. > > > > > > Jan > > > > > > 2016-07-05 19:03 GMT+02:00 Jan M=C4=99dala : > > > > > >> Bruce, > > >> > > >> > > >> That'd be very kind of you if you can fix trailing zeros. > > >> > > >> > > >> This patch > > >> > > >> Fixes: b5b8cd9 ("ena: update of ENA communication layer") > > >> > > >> > > >> Regards, > > >> > > >> Jan > > >> > > >> 2016-07-05 18:19 GMT+02:00 Bruce Richardson < > bruce.richardson@intel.com>: > > >> > > >>> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: > > >>> > On 6/30/2016 4:04 PM, Jan Medala wrote: > > >>> > > Signed-off-by: Alexander Matushevsky > > >>> > > Signed-off-by: Jakub Palider > > >>> > > Signed-off-by: Jan Medala > > >>> > > > >>> > The compilation error to fix is [1], it may be good to add what t= o > fix > > >>> > into commit log. > > >>> > > > >>> > [1] > > >>> > =3D=3D Build drivers/net/ena > > >>> > CC ena_ethdev.o > > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): > error > > >>> > #188: enumerated type mixed with another type > > >>> > struct ena_com_create_io_ctx ctx =3D { 0 }; > > >>> > ^ > > >>> > > > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036)= : > > >>> error > > >>> > #188: enumerated type mixed with another type > > >>> > struct ena_com_create_io_ctx ctx =3D { 0 }; > > >>> > ^ > > >>> > ... > > >>> > > > >>> > > --- a/drivers/net/ena/ena_ethdev.c > > >>> > > +++ b/drivers/net/ena/ena_ethdev.c > > >>> > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct > > >>> rte_eth_dev *dev, > > >>> > > __rte_unused unsigned int socket_id, > > >>> > > __rte_unused const struct > rte_eth_txconf > > >>> *tx_conf) > > >>> > > { > > >>> > > - struct ena_com_create_io_ctx ctx =3D { 0 }; > > >>> > > + struct ena_com_create_io_ctx ctx =3D > > >>> > > + /* policy set to _HOST just to satisfy icc compiler > */ > > >>> > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST, > > >>> > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 }; > > >>> > > > >>> > Trailing "0" are not required, compiler will take care of them. > > >>> > > > >>> Jan, > > >>> > > >>> any comment on this? If you want, I can remove the trailing zeros o= n > > >>> apply > > >>> rather than needing a V3. Is that ok? > > >>> > > >>> Again a fixes line is missing, can you supply one. > > >>> > > >>> /Bruce > > >>> > > >> > > >> > > > >