From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jan@semihalf.com>
Received: from mail-vk0-f52.google.com (mail-vk0-f52.google.com
[209.85.213.52]) by dpdk.org (Postfix) with ESMTP id BEF80697B
for <dev@dpdk.org>; Tue, 5 Jul 2016 19:04:48 +0200 (CEST)
Received: by mail-vk0-f52.google.com with SMTP id k68so186098575vkb.0
for <dev@dpdk.org>; Tue, 05 Jul 2016 10:04:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=semihalf-com.20150623.gappssmtp.com; s=20150623;
h=mime-version:in-reply-to:references:from:date:message-id:subject:to
:cc; bh=l02SPrrl6RiXrDsd3FTmd3aBCtZp3FLOzBwyRtirDZ0=;
b=DijFTwiKIZcniI+M68vsTiaqpwFyg/Js6YQXBhJMi9FdCcJX+v4EyUbGQB7Q0qBM+D
Fbda7e9uDoo3LwvTyFrxG11nofKJC6LRjOdXbKLDpVP7oJ1n7fXHOXwTlU3izVInGI4z
6gof69Q5BklXkrzCczKswIWG6dD0cTHVvXKs9tFmr4F9HnhDar6fA7w8ZGaZgeWn5ZGu
61jgbHEjogeWDJ0DZHgSxAOsIYJmnSQkXhVr7SWr4/1r4kGnZGJFW2Y77jSowCSJhGIO
66eradzILf7oQ7MvDgf/gIFIvk6cMllmm8gN6YYKJGXdUpQbV0AohZPlnKIPo1WJNP/8
c0/g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20130820;
h=x-gm-message-state:mime-version:in-reply-to:references:from:date
:message-id:subject:to:cc;
bh=l02SPrrl6RiXrDsd3FTmd3aBCtZp3FLOzBwyRtirDZ0=;
b=AJAKUWpOvnpCO3Gu2lRd8OvInMdwEK5fm7w6jmRDZ4BbEiYiaAmJWq/MUCXsXDLQuJ
RKTKOLDvPokG8HAfXgieckvXCm8Mpfx7PXvkMiiiW5ihd3pUpopRGZuanraaof6Vf0zz
jsCBT+WGkuxqmEEDqrzwIGTiA2PUmLkQZXC9gtKeT1QDYy6WZjOM9FwzIjpT8RAYAH5b
EEP4LSvG6h4F6wXpJm3WtljSPK+aR8spPHL8SMdubGq+3Yn69m3Gkc9cTbH7XOvtzc/Q
JaxzPmoRf8XUI7dxqh+8he2pYP6bx0bvXCbc8GSbsSmjqO75Cg8G/RpozG7ylgedQ8t6
8W6Q==
X-Gm-Message-State: ALyK8tLAmyZmdGFguSbZ/8byA1YGwIbSVKpZL2yqwDMU4rn4zyxiXMUSTQ/mLg/Fx+Wqj/mEyJ8z159mie29jg==
X-Received: by 10.31.226.133 with SMTP id z127mr5181190vkg.116.1467738288333;
Tue, 05 Jul 2016 10:04:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.159.36.54 with HTTP; Tue, 5 Jul 2016 10:04:47 -0700 (PDT)
In-Reply-To: <CANw_3Zd1egLWOBmFYHMkhTfsZpQcnorA7HG1TNCs5o+Vq4PY7Q@mail.gmail.com>
References: <1466510763-19569-6-git-send-email-jan@semihalf.com>
<1467299099-32498-1-git-send-email-jan@semihalf.com>
<1467299099-32498-7-git-send-email-jan@semihalf.com>
<577B7539.3000007@intel.com> <20160705161918.GC26504@bricha3-MOBL3>
<CANw_3Zd1egLWOBmFYHMkhTfsZpQcnorA7HG1TNCs5o+Vq4PY7Q@mail.gmail.com>
From: =?UTF-8?Q?Jan_M=C4=99dala?= <jan@semihalf.com>
Date: Tue, 5 Jul 2016 19:04:47 +0200
Message-ID: <CANw_3Zf=ja8j3Dut7U3gFLi0uWGUj1P7Ru_LbXv1r0UUOfr4Og@mail.gmail.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org,
Alexander Matushevsky <matua@amazon.com>, Jakub Palider <jpa@semihalf.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Jul 2016 17:04:49 -0000
Uhm, wait, I think that sha is wrong, please let me check it double time.
Jan
2016-07-05 19:03 GMT+02:00 Jan M=C4=99dala <jan@semihalf.com>:
> Bruce,
>
>
> That'd be very kind of you if you can fix trailing zeros.
>
>
> This patch
>
> Fixes: b5b8cd9 ("ena: update of ENA communication layer")
>
>
> Regards,
>
> Jan
>
> 2016-07-05 18:19 GMT+02:00 Bruce Richardson <bruce.richardson@intel.com>:
>
>> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote:
>> > On 6/30/2016 4:04 PM, Jan Medala wrote:
>> > > Signed-off-by: Alexander Matushevsky <matua@amazon.com>
>> > > Signed-off-by: Jakub Palider <jpa@semihalf.com>
>> > > Signed-off-by: Jan Medala <jan@semihalf.com>
>> >
>> > The compilation error to fix is [1], it may be good to add what to fix
>> > into commit log.
>> >
>> > [1]
>> > =3D=3D Build drivers/net/ena
>> > CC ena_ethdev.o
>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): erro=
r
>> > #188: enumerated type mixed with another type
>> > struct ena_com_create_io_ctx ctx =3D { 0 };
>> > ^
>> >
>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): err=
or
>> > #188: enumerated type mixed with another type
>> > struct ena_com_create_io_ctx ctx =3D { 0 };
>> > ^
>> > ...
>> >
>> > > --- a/drivers/net/ena/ena_ethdev.c
>> > > +++ b/drivers/net/ena/ena_ethdev.c
>> > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct rte_eth_de=
v
>> *dev,
>> > > __rte_unused unsigned int socket_id,
>> > > __rte_unused const struct rte_eth_txconf
>> *tx_conf)
>> > > {
>> > > - struct ena_com_create_io_ctx ctx =3D { 0 };
>> > > + struct ena_com_create_io_ctx ctx =3D
>> > > + /* policy set to _HOST just to satisfy icc compiler */
>> > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST,
>> > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 };
>> >
>> > Trailing "0" are not required, compiler will take care of them.
>> >
>> Jan,
>>
>> any comment on this? If you want, I can remove the trailing zeros on app=
ly
>> rather than needing a V3. Is that ok?
>>
>> Again a fixes line is missing, can you supply one.
>>
>> /Bruce
>>
>
>