From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk0-f49.google.com (mail-vk0-f49.google.com [209.85.213.49]) by dpdk.org (Postfix) with ESMTP id D6A716947 for ; Tue, 5 Jul 2016 19:10:55 +0200 (CEST) Received: by mail-vk0-f49.google.com with SMTP id v6so3240481vkb.2 for ; Tue, 05 Jul 2016 10:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bjeRemR6IE5BbZOSTMIVepgXAliKYttFapHniW3Rz7A=; b=aykhuBK9EcMRhaLWY9Fo2SpG5W4dI7D/rTzmBgVrDO98lnylMURIkqfO789fxTbrfp QYIigCpIn38R1ffgYA9mVd0Jp4dEUyfFqtR3AFyCCshXA3Zy5JqeJ3CqGYjEVvfqJDVI 3iwmryANgLo2sbz1ZH1nGDwDL4gqRuohHlcR4K6tdgAQEj7AyQ1v1URZAQXruGTCKK58 umOVXG8WMa2s5scQy1gN2EIhyq+VYrVYZQkk4qCaeUJHyNKgMgG7A7xGD9hbf211qbX2 drocXJM1lWOjFAlm21dZTn8t3zccOyoSTW+NJ11AvbMxG5ebyM6dCuOfVbddFLa5mqrA CPrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bjeRemR6IE5BbZOSTMIVepgXAliKYttFapHniW3Rz7A=; b=aLDSAoo8KEJLrCEpVS79peOvdkOThNyjRUGfktrKG+P3Kdgr9P8sM5atJ2u0VJUCXh 95tZGd1aegBaeaEcvCQY9DFY7gki0vaiESseY2fJPAxJ8mZYvVlltSxjQtgiFZ7Pg3MS 73KaJuBMlmt0TJbr9DoRyrzNwQc9dvvkKMEijGx/H/mR1FW/2ClbVLxo3+GDDdpJ6zvd 0Ht+2OqpgSkbUJqkjbzLOtngu7TMjFkNrpGXw4b87TfZ8M5FBISgvkbNYND7oNIJvUEz YJnIkKNwedtB7nmRrlBTUIeFTS39vlkzDmYXsMTu/xeurOitmUSWoLlvESCrjEEaR/+3 Dt3Q== X-Gm-Message-State: ALyK8tJoVj5kz1H40IoeWUvXW7cYcTSeya+xRF042QYsoQcoi8QqbzybPWZ5PBoLEqlrSt1PR6x3x8WalM+VDA== X-Received: by 10.159.41.231 with SMTP id s94mr7970041uas.74.1467738655321; Tue, 05 Jul 2016 10:10:55 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.36.54 with HTTP; Tue, 5 Jul 2016 10:10:54 -0700 (PDT) In-Reply-To: References: <1466510763-19569-6-git-send-email-jan@semihalf.com> <1467299099-32498-1-git-send-email-jan@semihalf.com> <1467299099-32498-7-git-send-email-jan@semihalf.com> <577B7539.3000007@intel.com> <20160705161918.GC26504@bricha3-MOBL3> From: =?UTF-8?Q?Jan_M=C4=99dala?= Date: Tue, 5 Jul 2016 19:10:54 +0200 Message-ID: To: Bruce Richardson Cc: Ferruh Yigit , dev@dpdk.org, Alexander Matushevsky , Jakub Palider Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 6/6] ena: fix for icc compiler X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2016 17:10:56 -0000 Let me point it this way: =E2=80=8B=E2=80=8BThis patch fixes: [dpdk-dev,v3,1/6] ena: update of ENA co= mmunication layer Jan 2016-07-05 19:04 GMT+02:00 Jan M=C4=99dala : > Uhm, wait, I think that sha is wrong, please let me check it double time. > > Jan > > 2016-07-05 19:03 GMT+02:00 Jan M=C4=99dala : > >> Bruce, >> >> >> That'd be very kind of you if you can fix trailing zeros. >> >> >> This patch >> >> Fixes: b5b8cd9 ("ena: update of ENA communication layer") >> >> >> Regards, >> >> Jan >> >> 2016-07-05 18:19 GMT+02:00 Bruce Richardson = : >> >>> On Tue, Jul 05, 2016 at 09:52:09AM +0100, Ferruh Yigit wrote: >>> > On 6/30/2016 4:04 PM, Jan Medala wrote: >>> > > Signed-off-by: Alexander Matushevsky >>> > > Signed-off-by: Jakub Palider >>> > > Signed-off-by: Jan Medala >>> > >>> > The compilation error to fix is [1], it may be good to add what to fi= x >>> > into commit log. >>> > >>> > [1] >>> > =3D=3D Build drivers/net/ena >>> > CC ena_ethdev.o >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(943): err= or >>> > #188: enumerated type mixed with another type >>> > struct ena_com_create_io_ctx ctx =3D { 0 }; >>> > ^ >>> > >>> > /tmp/dpdk_maintain/ena_v3/dpdk/drivers/net/ena/ena_ethdev.c(1036): >>> error >>> > #188: enumerated type mixed with another type >>> > struct ena_com_create_io_ctx ctx =3D { 0 }; >>> > ^ >>> > ... >>> > >>> > > --- a/drivers/net/ena/ena_ethdev.c >>> > > +++ b/drivers/net/ena/ena_ethdev.c >>> > > @@ -940,7 +940,10 @@ static int ena_tx_queue_setup(struct >>> rte_eth_dev *dev, >>> > > __rte_unused unsigned int socket_id, >>> > > __rte_unused const struct rte_eth_txconf >>> *tx_conf) >>> > > { >>> > > - struct ena_com_create_io_ctx ctx =3D { 0 }; >>> > > + struct ena_com_create_io_ctx ctx =3D >>> > > + /* policy set to _HOST just to satisfy icc compiler */ >>> > > + { ENA_ADMIN_PLACEMENT_POLICY_HOST, >>> > > + ENA_COM_IO_QUEUE_DIRECTION_TX, 0, 0, 0, 0 }; >>> > >>> > Trailing "0" are not required, compiler will take care of them. >>> > >>> Jan, >>> >>> any comment on this? If you want, I can remove the trailing zeros on >>> apply >>> rather than needing a V3. Is that ok? >>> >>> Again a fixes line is missing, can you supply one. >>> >>> /Bruce >>> >> >> >