From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f169.google.com (mail-qt0-f169.google.com [209.85.216.169]) by dpdk.org (Postfix) with ESMTP id 3BBD42B83 for ; Tue, 17 Jan 2017 13:51:39 +0100 (CET) Received: by mail-qt0-f169.google.com with SMTP id k15so155192680qtg.3 for ; Tue, 17 Jan 2017 04:51:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cVRcv55Bvm/O03kUlIJi4s+ZEs6Zl+RVp9JTVuMilc4=; b=QPHoUl2DQISSWLSXf8QjUZaJFgHXPExFdvUHqTclTq1Pqb1xgxouRwxNFM3jvdRTob fIFGT6xysx8sFoA2OUgzmahITlQCfTUC2LjLyOuH17lHiQ92lGzTRK1/lbbvvSSbHRNY gTs9VI/bISL6WRPi0cG7YzB6Ueun9NO+p/uKKV+bHSSLm9v/kD1YmcdfyBemZvJIS1Zj 21azhCyXIVcel/8VrHRlxDqt8G1ZVxl8nrb8tgUlehrCxqIpMcXDkRimkQfkvKpigyC5 x4Hcrs4TU3dU4TB9hHgsRlltt+3gGZRWu7pDb6zTwZiJvtEyE7MqMj9Y+fpT40n5GqxP btvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cVRcv55Bvm/O03kUlIJi4s+ZEs6Zl+RVp9JTVuMilc4=; b=CNfw6NAMHXs+6OGnL1xxcYgqK9x5OZ3ggzkhPnfXCN3/s5iggSemMduWmCJOiaTTAh PEsWwOqiNUTSbhHKU63/47330nU+xAem6dirgnax1EF5cTuLE6MS68KS12UakxATzaCR E30r2sapXSE7HQgKKdcABhm0xOyqOcW4zgvO6mDzxFulv4z97D9cCB80xHwV8eC6Au7L JCFwSFt3dlc+vGtiSc7uIdoeDwedFH2NpdG8MoAWpb9oMQCXNFjaZZa+/jVr2UAO4cOi pwuL4+o1QGBfJaHaROPpmEPlWXvGXnYr5mjKqO3mPX/Ob8LyohzG/nKPrUfSx6R5IyeY JSGw== X-Gm-Message-State: AIkVDXJUWuWxj0n7VwIA8+w63XRiICE8rhQSVmTkTHtSsXiXZSrv3YOldQAwDBzs5H1SLxPDJPROQKzO6n3H3g== X-Received: by 10.200.46.248 with SMTP id i53mr32800111qta.281.1484657498464; Tue, 17 Jan 2017 04:51:38 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.154.69 with HTTP; Tue, 17 Jan 2017 04:51:38 -0800 (PST) In-Reply-To: <1484637244-7548-21-git-send-email-jerin.jacob@caviumnetworks.com> References: <1484212646-10338-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484637244-7548-1-git-send-email-jerin.jacob@caviumnetworks.com> <1484637244-7548-21-git-send-email-jerin.jacob@caviumnetworks.com> From: =?UTF-8?Q?Jan_M=C4=99dala?= Date: Tue, 17 Jan 2017 13:51:38 +0100 Message-ID: To: Jerin Jacob , Santosh Shukla Cc: dev@dpdk.org, "Ananyev, Konstantin" , Thomas Monjalon , Bruce Richardson , jianbo.liu@linaro.org, viktorin@rehivetech.com, Jakub Palider Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 20/29] net/ena: use eal I/O device memory read/write API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 12:51:39 -0000 Jerin, Santosh, As you are introducing improved I/O access API, I would like to ask to change ENA platform code to: * #define ENA_REG_WRITE32(value, reg) rte_write32_relaxed((value), (reg))* * #define ENA_REG_READ32(reg) rte_read32_relaxed((reg))* There is no more need to have read/write functions within platform code ( *readl()*, *writel()*, *writel_relaxed()*), as we can directly map our API macro to DPDK platform implementation. Also I would prefer to keep API within *drivers/net/ena/base/ena_eth_com.h* and map define ENA_REG_WRITE32 to relaxed version (when barrier is needed we call it explicitly in driver code, there is no need to have ENA_REG_WRITE32_RELAXED). That will help us to manage code together between the different platforms. Should I do the change for ENA or do you want to keep the current flow and take care of it? =E2=80=8BBest regards Jan