From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF815A31F3 for ; Sat, 19 Oct 2019 20:26:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D12F01BF40; Sat, 19 Oct 2019 20:26:21 +0200 (CEST) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by dpdk.org (Postfix) with ESMTP id 2E4EA1BE9F for ; Sat, 19 Oct 2019 20:26:20 +0200 (CEST) Received: by mail-io1-f52.google.com with SMTP id n26so11235881ioj.8 for ; Sat, 19 Oct 2019 11:26:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=atCE3PhG0h0h7a3W8K6nNQKEex1sPlXI9BlRNvQCzP8=; b=BEa695TmoAeSfQAGC/F/e7YejjwNZhbccuuncutgAqv7GPxWduf9SCA9hiBK84g3I6 JWiQlLQIgE3Uq96rV0frJZLW1znd9M4iOTwKuNlomXO4j1vttvw1RYVdaN9xpoViD3Q2 p1VQTkWY/l1ki8o2uinLrHMZyjGCHq/d8euUda7YgLxVae4kD1UD2IsuUpc3NE9qRPGK eEzbxwZvIfgpq+bQwdq1uA/qVwavzLlGAZLg/I/FUyYyN07CKe5f5EiUswJJd5hbHYsR OWp1kFpDHE6eUUSkWP8UwOdaKf2A+MyWq9YwB552ntjzHE4CsyBjX043j5YaBcfAjAMU tCEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=atCE3PhG0h0h7a3W8K6nNQKEex1sPlXI9BlRNvQCzP8=; b=KL0VbPxK0nXWrQ5/JMYBzPoBrAJKfZSzlzIuViXKXfDQEeUF84uP5Pc4p7ZEPw8nIt hkgp7zXuvKV7WmxmNU3qG0HP4f9DtP61r38NrynGKRK/BBklqcYVOBrdiHsBxga6h5sn yg9nxeiG9UNEY8a0Ge3iM/iVtMaQFv6uchsbTzWNB5rDlON7waq2KRFSFgkzFHP4Q82o Zg3kG1smqiu8EgZnuuHcvPtakNmEqsHBrGc9RUuOCNW8fyq2EaCBt6DKOWzLKvKIxGl6 lvU6sLA/x0MDx6Aa/2u2D4HvXyu/Y4hMZ9kIyvLpncZ++RtC4OGR+aLKgMB88vjcVqAN ZwbA== X-Gm-Message-State: APjAAAUlkYADgLuLfRR/BSn75hJXtlDxfnNRcETPASOlMqPhrAHy6JAB ekpFOgTShurLNXcYml1ndRI7BneB7q3DnEqoL0VOHg== X-Google-Smtp-Source: APXvYqzVNqKI0C5CrKgyusZhMv6nenUFGwcBCixGV6MroL0bF9c+UX5EirrI8W1xSJZzVhhtl9nJe4O5ewbE4CIjkWg= X-Received: by 2002:a5d:8156:: with SMTP id f22mr14707492ioo.234.1571509579172; Sat, 19 Oct 2019 11:26:19 -0700 (PDT) MIME-Version: 1.0 From: kumaraparameshwaran rathinavel Date: Sat, 19 Oct 2019 23:56:08 +0530 Message-ID: To: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Admin Queue ENA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, In the ENA poll mode driver I see that every request in the admin queue is associated with a completion context and this is preallocated during the device initialisation. When the completion context is used we check for occupied to be true in the 16.X version if the occupied flag is set to true we assert and in the latest version I see that this is an error log. But there is a time window where if the completion context would be available to the other consumer but still the old consumer did not set the occupied to false. The new consumer holds the admin queue lock to get the completion context but the update by the old consumer to set the the occupied flag is not done under lock. So should we make sure that the new consumer should get the completion context only when the occupied flag is set to false. Any thoughts on this? If required I can try to make a patch where the completion context would be available only after setting the occupied flag to false. Thanks, Param.