From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62A3042CC4; Thu, 15 Jun 2023 11:16:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EBD7640DDA; Thu, 15 Jun 2023 11:16:20 +0200 (CEST) Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by mails.dpdk.org (Postfix) with ESMTP id 76C3D40A84 for ; Thu, 15 Jun 2023 11:16:19 +0200 (CEST) Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-5701eaf0d04so11387737b3.2 for ; Thu, 15 Jun 2023 02:16:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686820579; x=1689412579; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=To5Mj21uinbI4tnNMkGB/auPAr2teH7nI0XeXb+IWX0=; b=Bc32HyE1zEthTTZcy6sYxsOeqVv8O2hScbVa+/aAztr/bwsrdRw/ES08uZ6FYasGou rtd9DlhxH2jHzrWSMiaZRuNVoFbXSSqD1ksUxAbR/LTiZ7AmGgHm6tIxZkmj3o7AFJHH vlQNVP96e7Di90E0N85ZZi7j1BZWUWv+t61uKelIyJ3qzRoiME1iL+aplMpXWoOFiT50 w51/EpLhCJbpgPGLrbhHhs77dvVni0QN7BSvtfFZ+Zy7ZzHLfTdGb5wOagwyVOFSohHq eXVh1XZ9m1YG3QJg0FwVTHMqNk3AlrL2XYVbNcIk7ekePCZasRhjFr22uzyvRr4EHpge C4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686820579; x=1689412579; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=To5Mj21uinbI4tnNMkGB/auPAr2teH7nI0XeXb+IWX0=; b=M0X7dLlGB7ct94Oh37Sb+/qc/uqUAJc4DakcmRM9BQAal9DoV7m1d9lQTe+CgEY9Ds 0FEHUvKhtUv7kC1PaLlTPl0Kdm2w2VHZl30hphIUowXkL+CU8QjHDtnAdj9IHBw85zZi yD9z/Njlf3ILGppovB3BWYaDeFW9wy2grZntG4lotIjGiWfBX/Sx54MM1p7cLfozlVrY VPjk1e1Og0dsridHNbWk+d10SEQDC5ULqLJ1BkY9/9x7Xr7lDsfHRNh+Wi62ViGeHa2H xkC6bVvpJ5FCgsIcb/wZMos6yUpYZi+8HhIIHmQL5D3auHR3WFCTMnZq+0qVrnjZLXeS QA5w== X-Gm-Message-State: AC+VfDwc8eFB0HfbxfBvDnz2eV+APVmrGUSHF+hp9P/A1qHKQjKLFGSB WVqHEHMu426kwG/KAheIr1lQdpvVgrlNZ96D/Hv+SEwr X-Google-Smtp-Source: ACHHUZ7bR/v15MqPOmnoz5jAzxbEmgwWbBkLgRCDvCd7Ar+fb1bvsMEXjsfq4uJUIAo845cswfEfH/xuvp96fyE/7nw= X-Received: by 2002:a81:7488:0:b0:56d:4f2e:6f83 with SMTP id p130-20020a817488000000b0056d4f2e6f83mr4496918ywc.4.1686820578715; Thu, 15 Jun 2023 02:16:18 -0700 (PDT) MIME-Version: 1.0 References: <20221020181425.48006-1-kumaraparmesh92@gmail.com> <20230615062028.22773-1-kumaraparamesh92@gmail.com> In-Reply-To: From: kumaraparameshwaran rathinavel Date: Thu, 15 Jun 2023 14:46:07 +0530 Message-ID: Subject: Re: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 To: "Hu, Jiayu" Cc: "dev@dpdk.org" Content-Type: multipart/alternative; boundary="00000000000064eab305fe27859c" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000064eab305fe27859c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jun 15, 2023 at 1:31=E2=80=AFPM Hu, Jiayu wrot= e: > Hi Kumara, > > > -----Original Message----- > > From: Kumara Parameshwaran > > Sent: Thursday, June 15, 2023 2:20 PM > > To: Hu, Jiayu > > Cc: dev@dpdk.org; Kumara Parameshwaran > > > > Subject: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6 > > > > The patch adds GRO support for TCP/ipv6 packets. This does not include > the > > support for vxlan, udp ipv6 packets. > > > > Signed-off-by: Kumara Parameshwaran > > --- > > v1: > > * Changes to support GRO for TCP/ipv6 packets. This does not > > include > > vxlan changes. > > * The GRO is performed only for ipv6 packets that does not contai= n > > extension headers. > > * The logic for the TCP coalescing remains the same, in ipv6 head= er > > the source address, destination address, flow label, version > fields > > are expected to be the same. > > * Re-organised the code to reuse certain tcp functions for both > ipv4 > > and > > ipv6 flows. > > v2: > > * Fix comments in gro_tcp6.h header file. > > > > v3: > > * Adderess review comments to fix code duplication for v4 and v6 > > > > v4: > > * Addresses review comments for v3, do not use callbacks > > > > v5: > > * Address review comments > > > > v6: > > * Fix warning and coding style issues > > > > v7: > > * Fix build compilation issue > > > > v8: > > * Use gro_tcp_internal.h for functions used for gro_tcp4 and > > gro_tcp6 and use > > gro_tcp.h for data structures and functions used across > > gro_vxlan_tcp4 > > > > v9: > > * Resolve merge conflict and add gro_tcp.h in proper path > > > > .../generic_receive_offload_lib.rst | 21 +- > > doc/guides/rel_notes/release_23_07.rst | 2 + > > lib/gro/gro_tcp.h | 187 ++++++++++++ > > lib/gro/gro_tcp4.c | 177 +++--------- > > lib/gro/gro_tcp4.h | 170 +---------- > > lib/gro/gro_tcp6.c | 268 ++++++++++++++++++ > > lib/gro/gro_tcp6.h | 160 +++++++++++ > > lib/gro/gro_tcp_internal.h | 128 +++++++++ > > lib/gro/gro_vxlan_tcp4.c | 22 +- > > lib/gro/gro_vxlan_tcp4.h | 2 +- > > lib/gro/meson.build | 1 + > > lib/gro/rte_gro.c | 83 +++++- > > lib/gro/rte_gro.h | 3 + > > 13 files changed, 883 insertions(+), 341 deletions(-) create mode > 100644 > > lib/gro/gro_tcp.h create mode 100644 lib/gro/gro_tcp6.c create mode > > 100644 lib/gro/gro_tcp6.h create mode 100644 lib/gro/gro_tcp_internal.= h > > > > Reviewed-by: Jiayu Hu > > Hi Kumara, > > I notice you write Intel in the license header. Is it intended or mistake= n? > >> >> Hi Jiyau, This is intentional. >> >> Thanks, >> Kumara. >> > > Thanks, > Jiayu > --00000000000064eab305fe27859c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Thu, Jun 15, 2023 at 1:31=E2=80=AF= PM Hu, Jiayu <jiayu.hu@intel.com> wrote:
Hi= Kumara,

> -----Original Message-----
> From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> Sent: Thursday, June 15, 2023 2:20 PM
> To: Hu, Jiayu <jiayu.hu@intel.com>
> Cc: dev@dpdk.org= ; Kumara Parameshwaran
> <ku= maraparamesh92@gmail.com>
> Subject: [PATCH v9] gro : ipv6 changes to support GRO for TCP/ipv6
>
> The patch adds GRO support for TCP/ipv6 packets. This does not include= the
> support for vxlan, udp ipv6 packets.
>
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> ---
> v1:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Changes to support GRO for TCP/ipv6 packet= s. This does not
> include
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0vxlan changes.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* The GRO is performed only for ipv6 packets= that does not contain
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 extension headers.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* The logic for the TCP coalescing remains t= he same, in ipv6 header
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0the source address, destination addre= ss, flow label, version fields
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0are expected to be the same.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Re-organised the code to reuse certain tcp= functions for both ipv4
> and
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ipv6 flows.
> v2:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Fix comments in gro_tcp6.h header file. >
> v3:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Adderess review comments to fix code dupli= cation for v4 and v6
>
> v4:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Addresses review comments for v3, do not u= se callbacks
>
> v5:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Address review comments
>
> v6:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Fix warning and coding style issues
>
> v7:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Fix build compilation issue
>
> v8:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Use gro_tcp_internal.h for functions used = for gro_tcp4 and
> gro_tcp6 and use
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0gro_tcp.h for data structures and fun= ctions used across
> gro_vxlan_tcp4
>
> v9:
>=C2=A0 =C2=A0 =C2=A0 =C2=A0* Resolve merge conflict and add gro_tcp.h i= n proper path
>
>=C2=A0 .../generic_receive_offload_lib.rst=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0|=C2=A0 21 +-
>=C2=A0 doc/guides/rel_notes/release_23_07.rst=C2=A0 =C2=A0 =C2=A0 =C2= =A0 |=C2=A0 =C2=A02 +
>=C2=A0 lib/gro/gro_tcp.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0| 187 ++++++++++= ++
>=C2=A0 lib/gro/gro_tcp4.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 177 +++---------
>=C2=A0 lib/gro/gro_tcp4.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 170 +----------
>=C2=A0 lib/gro/gro_tcp6.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 268 ++++++++++++++++= ++
>=C2=A0 lib/gro/gro_tcp6.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 160 +++++++++++
>=C2=A0 lib/gro/gro_tcp_internal.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 | 128 +++++++++
>=C2=A0 lib/gro/gro_vxlan_tcp4.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 22 +-
>=C2=A0 lib/gro/gro_vxlan_tcp4.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A02 +-
>=C2=A0 lib/gro/meson.build=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A01 +
>=C2=A0 lib/gro/rte_gro.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 83 +++++= -
>=C2=A0 lib/gro/rte_gro.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A03 = +
>=C2=A0 13 files changed, 883 insertions(+), 341 deletions(-)=C2=A0 crea= te mode 100644
> lib/gro/gro_tcp.h=C2=A0 create mode 100644 lib/gro/gro_tcp6.c=C2=A0 cr= eate mode
> 100644 lib/gro/gro_tcp6.h=C2=A0 create mode 100644 lib/gro/gro_tcp_int= ernal.h
>

Reviewed-by: Jiayu Hu <Jiayu.hu@intel.com>

Hi Kumara,

I notice you write Intel in the license header. Is it intended or mistaken?=

Hi= Jiyau, This is intentional.=C2=A0

Thanks,
Ku= mara.

Thanks,
Jiayu
--00000000000064eab305fe27859c--