From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E94145FA5; Thu, 2 Jan 2025 04:53:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8662E4021E; Thu, 2 Jan 2025 04:53:21 +0100 (CET) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by mails.dpdk.org (Postfix) with ESMTP id 9C87540151 for ; Thu, 2 Jan 2025 04:53:19 +0100 (CET) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-aaf900cc7fbso95005266b.3 for ; Wed, 01 Jan 2025 19:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1735789999; x=1736394799; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a9x/vUXZwYUZ9VE4SptjFif5kAUB0gRs+G4HeOvhQuI=; b=FBVByrXYTAoOnvzqYea7oQtXyXpl8zckvJi3NYbaTlffsx4GVkc1bJitglCRljBYy0 QfFbl165rLgLQJjI2LNYR0vw0OXxThkC/I7GSUXiWFNnsVRPgY7taBHwS8faCcYMhxnI 25zUxqMHIlIrQWge3GiR3zBGWH+NntycBCEe4f1B3lV2TzEkbexaiHyIGtXyqQN220Qr 1nzSTSSD9QDBvbbPRp9E9AYhKTsp224cSJipDPp5M+j89RAdQEwknZO8znjHquJsxAgL SYoY1gUfLjrwvUtS0VhWLs/ZKMhRWm+4gj52SMjEmxtK6uvvW+OV+8SsaN9NeU5gE1uC Fy/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735789999; x=1736394799; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a9x/vUXZwYUZ9VE4SptjFif5kAUB0gRs+G4HeOvhQuI=; b=Dce1c1LqsWaJDVFYVacVCnrHnrIjS+fS4sJYFMA8wEFvUKPXOiqnB12CSSIVbRig5a 3LHqJEndQzlLZYwgpfdHCzSOvwCdzOF/k54E6yS1AWWny/ZWJ22U+OM4PiEuy2YJmsPc c0Nax5jtdE86uK0ZY9pUs0iM/6KVbNCj1lXNnK5Xnj1MvFHpNuhKwS2mFCmtnvsPrMaF /aFntE5iVDuP1c3SaCr2R8TRVp+rRuKTWgxqZwvaVdMeEhMxPHV6xE1vnbO7cO81QB5p blfh0aKuju/jxGKWs1imEW6h5uHX02RMaN6xCtmyWmbCeEPrNuJgk/NJLj+k/uTzk1yI rlBQ== X-Forwarded-Encrypted: i=1; AJvYcCXfGbcrSi/4h/oCLZ5n5in7Qx6v/n3g9j/miHLHxGCO5x0V9Lk4ybDo5OiSiyhBBBNKeuY=@dpdk.org X-Gm-Message-State: AOJu0YxrJ4rh5phg93XaAmDV/cAwvefD7J2cAUkM91mucIDpaJePpahW AnnfxzpKhp8VBmjltZThrmLqSRI+0FhG6q7RZBdujwTf8S51lvHfCIol8qgQrB//jfSN83D/4XM lAjy1dDsuC2B78iG/fRC8MIXSQG4= X-Gm-Gg: ASbGnct2JqEatxrXvCKKV6kEuBijw14fvnL9bjVkGrUswyv6ABdF0/Cjwrfs41s3doU Lm7O1BsMJKK1gTe6RfadTenDDqCH0ly6QLZEt9SEw X-Google-Smtp-Source: AGHT+IGuoplq0qajJsJGCm1A6X3dXdlskBRVt3o7EZ1mTgnPhgrndfV7xXVv55LHLbMPfXJNEqQghq38ujHqi2iDoag= X-Received: by 2002:a17:907:360e:b0:aa6:1e9a:e45a with SMTP id a640c23a62f3a-aac334ec999mr3964440266b.46.1735789998888; Wed, 01 Jan 2025 19:53:18 -0800 (PST) MIME-Version: 1.0 References: <20250101093735.95271-1-kumaraparamesh92@gmail.com> <20250101092138.4fb5fdee@fedora> In-Reply-To: <20250101092138.4fb5fdee@fedora> From: kumaraparameshwaran rathinavel Date: Thu, 2 Jan 2025 09:23:06 +0530 Message-ID: Subject: Re: [PATCH] lib/gro: use hash function for flow lookup To: Stephen Hemminger Cc: hujiayu.hu@foxmail.com, dev@dpdk.org Content-Type: multipart/alternative; boundary="00000000000049deda062ab11a8e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000049deda062ab11a8e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Jan 1, 2025 at 10:51=E2=80=AFPM Stephen Hemminger < stephen@networkplumber.org> wrote: > On Wed, 1 Jan 2025 15:07:35 +0530 > Kumara Parameshwaran wrote: > > > From: Kumara Parameshwaran > > To: hujiayu.hu@foxmail.com > > Cc: dev@dpdk.org, Kumara Parameshwaran > > Subject: [PATCH] lib/gro: use hash function for flow lookup > > Date: Wed, 1 Jan 2025 15:07:35 +0530 > > X-Mailer: git-send-email 2.47.1 > > > > optimize the GRO lookup using hash based > > implementation > > > > Signed-off-by: Kumara Parameshwaran > > Rather than open coding a hash table with collision chains, please use th= e > existing DPDK cuckoo hash which is faster and you can also prevent hash > DoS chain attacks. > >>Sure, I was thinking to use cuckoo hash, but then thought if this coul= d > be an overkill to for this implementation. > Alternatively, use a better hash function such as siphash which is > resistent > to DoS attacks. >> Yes, sure. Will change it. Had used that to get an idea for the overall implementation itself. > --00000000000049deda062ab11a8e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable



On Wed, Jan 1, 2025 at 10:51=E2=80= =AFPM Stephen Hemminger <stephen@networkplumber.org> wrote:
On Wed,=C2=A0 1 Jan 2025 15:07:3= 5 +0530
Kumara Parameshwaran <kumaraparamesh92@gmail.com> wrote:

> From: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> To: hujiay= u.hu@foxmail.com
> Cc: dev@dpdk.org= ,=C2=A0 Kumara Parameshwaran <kumaraparamesh92@gmail.com>
> Subject: [PATCH] lib/gro: use hash function for flow lookup
> Date: Wed,=C2=A0 1 Jan 2025 15:07:35 +0530
> X-Mailer: git-send-email 2.47.1
>
> optimize the GRO lookup using hash based
> implementation
>
> Signed-off-by: Kumara Parameshwaran <kumaraparamesh92@gmail.com>

Rather than open coding a hash table with collision chains, please use the<= br> existing DPDK cuckoo hash which is faster and you can also prevent hash
DoS chain attacks.
=C2=A0>>Sure, I was thinking to use cuckoo hash= , but then thought if this could be an overkill to for this implementation.= =C2=A0

Alternatively, use a better hash function such as siphash which is resisten= t
to DoS attacks.
=C2=A0 =C2=A0 >> Yes, sure. Will cha= nge it. Had used that to get an idea for the overall implementation itself.= =C2=A0=C2=A0
=C2=A0<= /blockquote>
--00000000000049deda062ab11a8e--