On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng wrote: > > > > -----Original Message----- > > From: Ferruh Yigit > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng ; Richardson, Bruce > > > > Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta > > > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > > > > > > > >> -----Original Message----- > > >> From: Ferruh Yigit > > >> Sent: Wednesday, April 12, 2023 16:50 > > >> To: Guo, Junfeng ; Richardson, Bruce > > >> > > >> Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta > > >> > > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > >> > > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > >> > > >> Hi Junfeng, message moved down. > > >> > > >>> > > >>>> -----Original Message----- > > >>>> From: Rushil Gupta > > >>>> Sent: Tuesday, April 11, 2023 12:59 > > >>>> To: Zhang, Qi Z ; ferruh.yigit@amd.com > > >>>> Cc: Richardson, Bruce ; > > dev@dpdk.org; > > >>>> Rushil Gupta ; Guo, Junfeng > > >>>> > > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO > > >>>> > > >>>> Update gve base code to support DQO. > > >>>> > > >>>> This patch is based on this: > > >>>> > > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=* > > >>>> > > >>>> Signed-off-by: Rushil Gupta > > >>>> Signed-off-by: Junfeng Guo > > >>> Hi Ferruh & Bruce, > > >>> > > >>> This patch contains few lines change for the MIT licensed gve base > > code. > > >>> Note that there is no new files added, just some minor code update. > > >>> > > >>> Do we need to ask for special approval from the Tech Board for this? > > >>> Please help give some advice and also help review this patch. Thanks! > > >>> > > >> > > >> Once the MIT license exception is in place, as far as I know no more > > >> approval is required per change. > > > > > > Got it, thanks the comment! > > > > > > Then we may also need your help to review, as well as the coming patch > > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance! > > > > > >> > > >>> BTW, Google will also help replace all the base code under MIT > > license > > >>> with the ones under BSD-3 license soon, which would make things > > more > > >>> easier. > > >>> > > >> > > >> Is this different from base code under DPDK is changing license [1] ? > > >> > > >> > > >> [1] > > >> > > https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar > > >> chive=both > > >> > > > > > > The patch set of the above link only contains the processing of replace > > the > > > MIT licensed base code with the BSD-3 licensed base code. After some > > > discussion, we think Google is in the right place to do that work. And > > they > > > are working on that now. > > > > > > > Is the Google GVE driver [2] in the process of changing license from MIT > > to BSD-3? > > > > > > [2] > > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet- > > linux/tree/v1.3.0/google/gve > > > > I'm not sure, I don't know much about Google's plans. > Maybe they could provide some info here. Thanks! > > @Rushil Gupta > > > > > > > > This patch is mainly for the feature upstreaming of DPDK 23.07. It > > contains > > > only the code part, following previous license statements, without any > > > license change. > > > > > > This patch is separated and sent by Google, to ensure there is no > license > > > violation. > > > > > > BTW, about the feature of GVE PMD enhancement, the rest code are all > > > about BSD-3 licensed files, and that patch set will be sent out soon. > > > > > > Thanks! > > I have got the green light internally to switch to BSD-3 license for code under base directory. If it is ok with the tech board, I can send a patch right away with all of the base files changed to BSD-3 which can be merged after this patch. Please let me know what you think. We are also about to upstream driver code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.