DPDK patches and discussions
 help / color / mirror / Atom feed
From: Rushil Gupta <rushilg@google.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	 "Wu, Jingjing" <jingjing.wu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	 "Guo, Junfeng" <junfeng.guo@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 Joshua Washington <joshwash@google.com>,
	Jeroen de Borst <jeroendb@google.com>
Subject: Re: [PATCH 2/2] net/gve: update copyright holders
Date: Thu, 30 Mar 2023 08:18:51 -0700	[thread overview]
Message-ID: <CANzqiF7G06u++O99ntGaH-kszzV7qO7PtKKOEkkesAdn_8v5ww@mail.gmail.com> (raw)
In-Reply-To: <9576586.lOV4Wx5bFT@thomas>

[-- Attachment #1: Type: text/plain, Size: 3304 bytes --]

We were just trying to comply with the BSD license to get
rid of the exception. You have the MIT license for control path/admin-queue
code. Since admin-queue path is similar across linux, freebsd and dpdk the
code is similar but not exactly the same,
We are about to upstream driver code to FreeBSD under BSD license as well
so you will see this code under BSD license soon. I will consult the
lawyers on my end as well.

On Thu, Mar 30, 2023 at 6:14 AM Thomas Monjalon <thomas@monjalon.net> wrote:

> 30/03/2023 09:20, Guo, Junfeng:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 28/03/2023 11:35, Guo, Junfeng:
> > > > The background is that, in the past (DPDK 22.11) we didn't get the
> > > approval
> > > > of license from Google, thus chose the MIT License for the base code,
> > > and
> > > > BSD-3 License for GVE common code (without the files in /base
> folder).
> > > > We also left the copyright holder of base code just to Google Inc,
> and
> > > made
> > > > Intel as the copyright holder of GVE common code (without /base
> > > folder).
> > > >
> > > > Today we are working together for GVE dev and maintaining. And we
> > > got
> > > > the approval of BSD-3 License from Google for the base code.
> > > > Thus we dicided to 1) switch the License of GVE base code from MIT to
> > > BSD-3;
> > > > 2) add Google LLC as one of the copyright holders for GVE common
> > > code.
> > >
> > > Do you realize we had lenghty discussions in the Technical Board,
> > > the Governing Board, and with lawyers, just for this unneeded
> exception?
> > >
> > > Now looking at the patches, there seem to be some big mistakes like
> > > removing some copyright. I don't understand how it can be taken so
> > > lightly.
> > >
> > > I regret how fast we were, next time we will surely operate
> differently.
> > > If you want to improve the reputation of this driver,
> > > please ask other copyright holders to be more active and responsive.
> > >
> >
> > Really sorry for causing such severe trouble.
> >
> > Yes, we did take lots of efforts in the Technical Board and the Governing
> > Board about this MIT exception. We really appreciate that.
> >
> > About this patch set, it is my severe mistake to switch the MIT License
> > directly for the upstream-ed code in community, in the wrong way.
> > In the past we upstream-ed this driver with MIT License followed from
> > the kernel community's gve driver base code. And now we want to
> > use the code with BSD-3 License (approved by Google).
> > So I suppose that the correct way may be 1) first remove all these code
> > under MIT License and 2) then add the new files under BSD-3 License.
>
> The code under BSD is different of the MIT code?
> If it is the same with a new approved license, you can just change the
> license.
>
> > Please correct me if there are still misunderstanding in my statement.
> > Thanks Thomas for pointing out my mistake. I'll be careful to fix this.
> >
> > Copyright holder for the gve base code will stay unchanged. Google LLC
> > will be added as one of the copyright holders for the gve common code.
> > @Rushil Gupta Please also be more active and responsive for the code
> > review and contribution in the community. Thanks!
>
>
>
>

[-- Attachment #2: Type: text/html, Size: 4056 bytes --]

  reply	other threads:[~2023-03-30 15:19 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28  2:08 [PATCH 0/2] update license and copyright Junfeng Guo
2023-03-28  2:08 ` [PATCH 1/2] net/gve: switch copyright from MIT to BSD-3 Junfeng Guo
2023-03-28  8:51   ` Ferruh Yigit
2023-03-28  8:57     ` Guo, Junfeng
2023-03-28  8:55   ` Ferruh Yigit
2023-03-28  9:06     ` Guo, Junfeng
2023-03-28  9:09       ` Ferruh Yigit
2023-03-28  9:35         ` Guo, Junfeng
2023-03-28  2:08 ` [PATCH 2/2] net/gve: update copyright holders Junfeng Guo
2023-03-28  8:56   ` Ferruh Yigit
2023-03-28  9:35     ` Guo, Junfeng
2023-03-28 10:10       ` Ferruh Yigit
2023-03-29 14:07       ` Thomas Monjalon
2023-03-30  7:20         ` Guo, Junfeng
2023-03-30 13:14           ` Thomas Monjalon
2023-03-30 15:18             ` Rushil Gupta [this message]
2023-03-30 15:26             ` Rushil Gupta
2023-03-31  2:32             ` Guo, Junfeng
2023-03-28  9:28 ` [PATCH v2 0/3] update license and " Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-28  9:28   ` [PATCH v2 3/3] net/gve: add maintainers for GVE Junfeng Guo
2023-03-28  9:45   ` [PATCH v3 0/3] update license and copyright holders Junfeng Guo
2023-03-28  9:45     ` [PATCH v3 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-28 10:36       ` Ferruh Yigit
2023-03-29  2:35         ` Guo, Junfeng
2023-03-28  9:45     ` [PATCH v3 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-28 10:37       ` Ferruh Yigit
2023-03-28 22:11         ` Rushil Gupta
2023-03-28  9:45     ` [PATCH v3 3/3] net/gve: add maintainers for GVE Junfeng Guo
2023-03-28 10:00       ` Guo, Junfeng
2023-03-28 10:34         ` Ferruh Yigit
2023-03-29  2:54           ` Guo, Junfeng
2023-03-29  2:26     ` [PATCH v4 0/3] update license and copyright holders Junfeng Guo
2023-03-29  2:27       ` [PATCH v4 1/3] net/gve: switch license from MIT to BSD-3 Junfeng Guo
2023-03-29  8:08         ` Ferruh Yigit
2023-03-29  2:27       ` [PATCH v4 2/3] net/gve: update copyright holders Junfeng Guo
2023-03-29  2:27       ` [PATCH v4 3/3] net/gve: add maintainers for GVE Junfeng Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANzqiF7G06u++O99ntGaH-kszzV7qO7PtKKOEkkesAdn_8v5ww@mail.gmail.com \
    --to=rushilg@google.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=jeroendb@google.com \
    --cc=jingjing.wu@intel.com \
    --cc=joshwash@google.com \
    --cc=junfeng.guo@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).